A caption appearing after first post of a thread is not properly linked!

100bitcoin

sr. member

Activity: 860

Merit: 423

Quote from: theymos on November 06, 2019, 10:04:43 PM

I found it, it was a bug in the random rotation. Rarely (5-10% of the time before I fixed it, though growing with an increasing set of captions+votes), it would assign the wrong link to a caption during random rotation.

Thanks!

Awesome work.

I just noticed the following, while voting on https://bitcointalk.org/captions.php ...

Caption: Good Captions

Link: https://bitcointalksearch.org/topic/m.28856522

I could not understand the co-relation between the two! What does Merit & new rank requirements have to do with Good Captions?

theymos

administrator

Activity: 5222

Merit: 13032

I found it, it was a bug in the random rotation. Rarely (5-10% of the time before I fixed it, though growing with an increasing set of captions+votes), it would assign the wrong link to a caption during random rotation.

Thanks!

TryNinja

legendary

Activity: 2758

Merit: 6830

Quote from: theymos on November 06, 2019, 07:32:19 PM

Does anyone else see this? I can't reproduce it. I don't know how it could be a client-side issue either, though.

I spent some minutes trying to reproduce it as well but I couldn't. Saw 4 captions and all of them were right.

100bitcoin

sr. member

Activity: 860

Merit: 423

Quote from: theymos on November 06, 2019, 07:32:19 PM

Does anyone else see this? I can't reproduce it. I don't know how it could be a client-side issue either, though.

This could be CloudFlare caching issue. CloudFlare may hold previous 'src' value in a hyperlink, while rendering a new 'title'. Try purging CloudFlare or turn on development mode.

Last of the V8s

legendary

Activity: 1652

Merit: 4393

Be a bank

yes same problem here
link should be 'bitcoin's 10th anniversary'
but goes to https://bitcointalksearch.org/topic/m.2513302 your 'Activity & new membergroup limits' thread

theymos

administrator

Activity: 5222

Merit: 13032

Does anyone else see this? I can't reproduce it. I don't know how it could be a client-side issue either, though.

100bitcoin

sr. member

Activity: 860

Merit: 423

Oops. There appears to be another...

Caption: I AM HODLING

Proper link: https://bitcointalksearch.org/topic/m.4022997 (appearing in https://bitcointalk.org/captions.php)

Wrong Link: https://bitcointalksearch.org/topic/m.42776661 (appearing in forum ad section)

Please check the bottom left corner of my screenshot. I AM HODLING is in red because I touched cursor to it. The associated link is shown at the bottom left corner, which is ending with #msg42776661, i.e. the Wrong Link.

I am sure, you have some mapping issue while showing captions in forum ad. Because, link is showing correct in https://bitcointalk.org/captions.php.

100bitcoin

sr. member

Activity: 860

Merit: 423

Quote from: theymos on November 06, 2019, 06:49:50 PM

That is what the link is. I don't understand what issue you're seeing.

That is the correct link. I forgot to capture the wrong link.

Just found another.

Caption: First Bitcoin Inflation Bug

Proper link: https://bitcointalksearch.org/topic/m.9474 (appearing in https://bitcointalk.org/captions.php)

Wrong Link: https://bitcointalksearch.org/topic/m.1643833 (appearing in forum ad section)

theymos

administrator

Activity: 5222

Merit: 13032

That is what the link is. I don't understand what issue you're seeing.

100bitcoin

sr. member

Activity: 860

Merit: 423

Caption: Satoshi admits he's a wet blanket

Proper link: https://bitcointalksearch.org/topic/m.1976

Linking is correct in https://bitcointalk.org/captions.php, but wrong when appearing in a thread after first post.

I, somehow, missed the wrong link and it is not appearing for me again. Undecided

But I am sure theymos can correct it.

Topic: A caption appearing after first post of a thread is not properly linked! (Read 301 times)