Topic: assert(...) with side effects (Read 532 times)
It's probably better to just define a custom CHECK macro that is always active. It's better to crash the node in production than to enter an undefined state.
In main.cpp the following line within ConnectBlock has side effects which would be skipped if -DNDEBUG were to be defined.
It should be, indeed, but we don't support compiling without asserts. This is a known wart. There are a couple of other similar places that ought to be fixed. I might as well go fix it. 
In main.cpp the following line within ConnectBlock has side effects which would be skipped if -DNDEBUG were to be defined.
Seems to me the code should be
Code:
assert(view.SetBestBlock(pindex->GetBlockHash()));
Seems to me the code should be
Code:
bool success = view.SetBestBlock(pindex->GetBlockHash());
assert(success);
Jump to: