This part is not right. Electrum uses AES-256-CBC which is, to my knowledge, a pretty strong way of encrypting the wallet file for security.
I agree with this user.
He is wrong. AES-256-CBC is used in many wallets. So no difference between them. Look at multibit hd beta 0.5 any why it is early. It uses AES-256-CBC and scrypt for key-stretching. Electrum uses SHA256d for key-stretching, same as mining. In this picture you can see brute force attacks with a normal computer. All the wallets use AES-256-CBC. The question is about offline computer. Is encryption important when offline?
https://imgur.com/b59utxl (if it does not load, click)
Then what is your explanation for this: http://docs.electrum.org/en/latest/faq.html#what-encryption-is-used-for-wallets
I will add the link to code on GitHub if I can find it since I am bad at python.
Also the picture you have included here is out of context and does not say anything.
What is this result of?
Is it result of brute forcing encrypted wallet files?
How old is this?
How strong or weak was the passwords which were used? (the length of the password for example was it "123" or was it "2Fd#4dlR&jfh8"?
How many tests were performed on how many variations of passwords?
The graph shows brute force attack on wallets. The numbers are passwords/s. It is from my research 2 month ago. All wallets you see use AES-256-CBC. That is not important. If your password is strong, brute force is not working. With electrum you must have a strong password, with others not so much. I will show you in source if it helps.
Here is defined Hash(x), here it is used as secret for encryption. This is normal and called key-stretching or key derivation function. It is used because a password does not have the correct bits.
Now we look at bitcoin core. Here is encryption and look here is benchmark to help find a good number of sha512 rounds. In my research the wallets used 128675 to 240718 rounds. Think what would take longer 128000 rounds sha512 or two rounds sha256. AES is the same for all, it does not matter.
And question again, why is the password and key-stretching important if the computer is offline? Offline computer can have simple or no password.