Author

Topic: Bounty for CPFP Enabled Wallet (Read 2545 times)

legendary
Activity: 1512
Merit: 1009
August 26, 2015, 11:43:30 AM
#14
We included CPFP in breadwallet a few months back (two months before the bounty was created) for when the user spends unconfirmed non-change inputs. Happy to let the bounty go to Andreas though. Andreas and co. are doing good work.

https://github.com/voisine/breadwallet/blob/v0.5.1/BreadWallet/BRWallet.m#L382

Wasn't aware that one of my favorite wallets already had it Smiley Nice job. It will probably come in handy some day Grin
member
Activity: 115
Merit: 19
August 26, 2015, 11:26:16 AM
#13
We included CPFP in breadwallet a few months back (two months before the bounty was created) for when the user spends unconfirmed non-change inputs. Happy to let the bounty go to Andreas though. Andreas and co. are doing good work.

https://github.com/voisine/breadwallet/blob/v0.5.1/BreadWallet/BRWallet.m#L382
jr. member
Activity: 47
Merit: 16
July 26, 2015, 06:49:44 PM
#12

A bit OT, but which other nodes/wallets implement CPFP already out-of-the-box?
Only Android Bitcoin-Wallet...

No others that I've seen, which is why it won the bounty.
hero member
Activity: 517
Merit: 501
July 26, 2015, 06:15:18 PM
#11

A bit OT, but which other nodes/wallets implement CPFP already out-of-the-box?
legendary
Activity: 1512
Merit: 1009
July 21, 2015, 11:24:48 AM
#10
Good news that this has been implemented... However I don't use the software in which it was Cheesy Hoping this at least makes it to the Core wallet.
full member
Activity: 210
Merit: 101
“Create Your Decentralized Life”
July 21, 2015, 11:02:30 AM
#9
The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37
Awarded
to Andreas Schildbach

congrats!
https://blockchain.info/tx/8ec943be37e8e45ba60e0c3ae82323cade5e084b25e9154714e86a5d80a1a44b
full member
Activity: 210
Merit: 101
“Create Your Decentralized Life”
July 17, 2015, 12:16:24 PM
#8
The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37
All over it... Thx... I assume the "test" is testnet.
hero member
Activity: 483
Merit: 501
July 17, 2015, 11:18:50 AM
#7
The feature is now finished, merged and starts to roll out to 10% of users.

If you feel like skipping the queue you can download directly from here:

https://github.com/schildbach/bitcoin-wallet/releases/tag/v4.37
hero member
Activity: 483
Merit: 501
July 16, 2015, 11:06:38 AM
#6
I just updated our branch so that it supports encrypted wallets (spending PIN).
full member
Activity: 210
Merit: 101
“Create Your Decentralized Life”
July 15, 2015, 11:49:48 AM
#5
Does the CPFP patch have to make it into the stable build released by the developers of the wallets or can it just be a patch that you apply yourself?
I added a rules section to OP
Quote
Rules:
  • Must be a wallet featured on the bitcoin homepage
  • Must be either accepted into primary build branch of (1), or available in a production / beta / dev build of (1)
staff
Activity: 3374
Merit: 6530
Just writing some code
July 15, 2015, 11:40:58 AM
#4
Does the CPFP patch have to make it into the stable build released by the developers of the wallets or can it just be a patch that you apply yourself?
full member
Activity: 210
Merit: 101
“Create Your Decentralized Life”
July 15, 2015, 11:09:42 AM
#3
We're already working on getting child-pays-for-parent into Bitcoin Wallet. The branch is here: https://github.com/schildbach/bitcoin-wallet/commits/fee-cpfp

It's still a bit rough and needs work. The biggest missing part is PIN entry, so you currently need to unset your PIN before raising the fee.

Any code review is appreciated.
Wow... fantastic news.... I'll be happy to look at it...

Setting up an android build server will take a bit.  If no one beats me too it, I'll try to post a testnet build from the branch... expect it to take a while.
hero member
Activity: 483
Merit: 501
July 15, 2015, 05:41:53 AM
#2
We're already working on getting child-pays-for-parent into Bitcoin Wallet. The branch is here: https://github.com/schildbach/bitcoin-wallet/commits/fee-cpfp

It's still a bit rough and needs work. The biggest missing part is PIN entry, so you currently need to unset your PIN before raising the fee.

Any code review is appreciated.
full member
Activity: 210
Merit: 101
“Create Your Decentralized Life”
July 15, 2015, 04:12:27 AM
#1
CPFP (Child Pays for Parent) Bounty
3FEUByMeaxrNmBCVYjvsnhyAjiUdat5i7M

Anyone who can put a CPFP transaction creation feature into any wallet featured on the bitcoin homepage can claim this bounty.  

I outlined the basic idea of the bounty in this BIP proposal before I was educated on CPFP.

To claim the bounty / pizza you will need to convince the following holders of the multisig

Rules:
  • Must be a wallet featured on the bitcoin homepage
  • Must be either accepted into primary build branch of (1), or available in an official release / beta / dev build of (1)

References:
Jump to: