Bug on the merit system? | Bitcointalksearch.org

lobcmt2

full member

Activity: 462

Merit: 155

Quote from: vit05 on January 29, 2019, 08:48:15 PM

I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. Cheesy

Tks theymos.

You are a nice case study for the improvements made by theymos weeks ago.
After the improvements, meriters can not send their sMerits to the same posts with same amount of sMerits when they double click in the duration of 60 seconds.

Quote from: theymos on December 28, 2018, 08:15:15 PM

Alright, you now can't merit the same post with the same amount within 60 seconds.

seoincorporation

legendary

Activity: 3346

Merit: 3125

Quote from: vit05 on January 29, 2019, 08:48:15 PM

I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. Cheesy

Tks theymos.

lol, i haven't get the message yet, but that was a nice answer.

So, we this we fix the double spending merit problem, next goal? fix the double spending bitcoin problem Tongue

Thanks theymos.

vit05

hero member

Activity: 672

Merit: 526

I guess no one has shown the image that appears. So just to show that the system seems to be working very well, avoiding double spending and Merits inflation. Cheesy

Tks theymos.

seoincorporation

legendary

Activity: 3346

Merit: 3125

Quote from: ?? on ??

Can there be some relaxation in this Merit System? It don't allow the members to grow in ranks now. I mean my account is stuck at member since the introduction of this system and i think that is the case with alot of other people.

Well, to become Full Member you need at least 100 merits, for more information take a look to:

Quote

FAQ: Everything you need to know about forum 'activity, account ranks and merit

https://bitcointalksearch.org/topic/faq-everything-you-need-to-know-about-forum-activity-account-ranks-and-merit-2766177

To get those 90 merits you will have to post some good quality stuff. Good luck.

DdmrDdmr

legendary

Activity: 2338

Merit: 10802

There are lies, damned lies and statistics. MTwain

Quote from: aervin11 on December 29, 2018, 10:05:32 AM

<...>

Well the bug is no longer an issue, and has run the full software development cycle in a short amount of time: reported, measure of impact, resolved and rolled-out, tested, twitched and rolled-out, re-tested, verified and settled.

Note: I looked through the list of cases I compiled with the 317 TXs (out of which half were likely due to the double/triple click ex-bug effect), and found no obvious case of the scenario you hypothesize (all lower ranked cases involved as Senders had enough sMerits to cover the double send at the time, and higher-ranked are more likely due to airdropped sMerit).

Quote from: Buttermellow on December 29, 2018, 11:10:40 AM

<…>

I wouldn’t really call it a user negligence … anyway, it was a minor incident that has been fixed or software-shaped to be avoided.

Buttermellow

member

Activity: 462

Merit: 14

Quote from: DdmrDdmr on December 28, 2018, 11:06:26 AM

I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP, grouping by exact time would not catch these cases, so I went on to giving a 2 second margin (searching for all TXs within a 2 second gap with the same implied users and message and date).

I make it 317 TXs historically by the above criteria (see https://docs.google.com/spreadsheets/d/1JmMF_SZX0oWgK8L2BL-lkB0aDMAIW7HB2OWJKXxtrag/edit?usp=sharing), with 155 different real intended TX sends (the others are side effects of double or triple clicking the send button).

No too many cases, and roughly let’s say half of the implied sMerits being non-intentional (602 sMerits -> would mean 301 non-intentional sent sMerits historically).

So there is no really bug with the merit system and it shows probably the slow internet connection which could not load up to the next page after sending the merit or pressing the send button. It is a due negligence of the user on how careful he was in sending the merit.

seoincorporation

legendary

Activity: 3346

Merit: 3125

Quote from: theymos on December 28, 2018, 09:41:13 PM

Quote from: vit05 on December 28, 2018, 09:17:32 PM

I just did.

OK, now it should be impossible no matter how much you try.

Thanks for your reply and for fixing the bug. Isn't a real destructive bug, but 301 non-intentional sent sMerits is something since merits are an unreversible action.

And want to thanks the community too, thanks guys for your help to solve this issue, not let's enjoy the last weekend of the year. Wink

Quote from: aervin11 on December 29, 2018, 10:05:32 AM

Since this is a bug, is this double click double merit thing only works if you have enough spendable merit? I mean If I have one spendable merit, then this won't work on me right?

No, with one merit shouldn't work.

aervin11

full member

Activity: 602

Merit: 103

Since this is a bug, is this double click double merit thing only works if you have enough spendable merit? I mean If I have one spendable merit, then this won't work on me right?

The Cryptovator

legendary

Activity: 2394

Merit: 2223

Signature space for rent

Quote from: theymos on December 28, 2018, 09:41:13 PM

Quote from: vit05 on December 28, 2018, 09:17:32 PM

I just did.

OK, now it should be impossible no matter how much you try.

Yes, now working fine. I just tried to merit you with different 2 window but it's not possible now. I think now merit abuser can't excuse that I have sent by mistake. I have remembered few abuser excuse like this.

Quote from: LoyceV on December 29, 2018, 05:28:52 AM

Quote from: theymos on December 28, 2018, 08:15:15 PM

Alright, you now can't merit the same post with the same amount within 60 seconds.

Different amounts still work, I'm fine with this workaround to protect users against their double click habits

Doesn't matter if different amount, because amount different means you are fully aware that you are going to send another amount of merit to same post.

LoyceV

legendary

Activity: 3290

Merit: 16489

Thick-Skinned Gang Leader and Golden Feather 2021

Quote from: theymos on December 28, 2018, 08:15:15 PM

Alright, you now can't merit the same post with the same amount within 60 seconds.

Different amounts still work, I'm fine with this workaround to protect users against their double click habits

OgNasty

donator

Activity: 4760

Merit: 4323

Leading Crypto Sports Betting & Casino Platform

Quote from: DdmrDdmr on December 28, 2018, 11:06:26 AM

I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP

I was on my mobile and when I tapped the button to submit merit, it registered as a double tap submitting twice. Nobody asked but figured I’d explain anyway.

JusticeForYou

vip

Activity: 490

Merit: 271

Quote from: vit05 link=topic=5090492.msg48940012#msg48940012

I just did.

https://bitcointalk.org/index.php?action=merit;u=194811

I have opened two windows to send merit and when I hit the second one, I merit two times.

This could be the best sacrifice of merits to upgrade the merit system. Great work bro! Wink

cabalism13

legendary

Activity: 1428

Merit: 1166

🤩Finally Married🤩

Quote from: Vod on December 29, 2018, 12:20:05 AM

And you sir, got five merits by mistake. :/

I knew it!, well you did it again on me

(see Merit History) haha well anyway thanks. And No worries I'm gonna spend this on worthies

Vod

legendary

Activity: 3668

Merit: 3010

Licking my boob since 1970

Quote from: cabalism13 on December 28, 2018, 10:37:38 PM

Quote from: theymos on December 28, 2018, 09:41:13 PM

OK, now it should be impossible no matter how much you try.

[+1]

@vit05 you did a great job pal, you certainly got theymos back there hahaha

And you sir, got five merits by mistake. :/

Vod

legendary

Activity: 3668

Merit: 3010

Licking my boob since 1970

Quote from: theymos on December 28, 2018, 09:41:13 PM

Quote from: vit05 on December 28, 2018, 09:17:32 PM

I just did.

OK, now it should be impossible no matter how much you try.

Ok, I think that was a cheap trick to get extra merits... Tongue

cabalism13

legendary

Activity: 1428

Merit: 1166

🤩Finally Married🤩

Quote from: theymos on December 28, 2018, 09:41:13 PM

OK, now it should be impossible no matter how much you try.

[+1]

@vit05 you did a great job pal, you certainly got theymos back there hahaha

theymos

administrator

Activity: 5222

Merit: 13032

Quote from: vit05 on December 28, 2018, 09:17:32 PM

I just did.

OK, now it should be impossible no matter how much you try.

vit05

hero member

Activity: 672

Merit: 526

Quote from: theymos on December 28, 2018, 08:15:15 PM

Alright, you now can't merit the same post with the same amount within 60 seconds.

I just did.

https://bitcointalk.org/index.php?action=merit;u=194811

I have opened two windows to send merit and when I hit the second one, I merit two times.

theymos

administrator

Activity: 5222

Merit: 13032

Alright, you now can't merit the same post with the same amount within 60 seconds.

mikeywith

legendary

Activity: 2394

Merit: 6581

be constructive or S.T.F.U

Quote from: pugman on December 28, 2018, 06:19:34 PM

Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything.

first thing first, he probably means 1Gbps and that's 125mBps , also i don't think he is referring to the the ISP bandwidth but rather his local network router. which could be the gateway to an old slow dial up connection with only 56 kbit/s.

with that being said, the speed of how fast you can actually post/merit which basically an "update or insert" command into the database of bitcointalk is irrelevant. even if you were using the fastest internet speed on planet earth you will still be limited by the speed of the database engine as well as the server it runs on. so the fast merits you done there are nothing but result of your fast "hands" rather than the speed of your internet or computer.

-------------------------------------------

as for the bug, i noticed that too, i think the easiest solution would be to be to close the page after the button is clicked, since the merit page is useless after having sent the merit as it opens in a new tab. so that will be more like hitting 2 birds with 1 stone.

pugman

legendary

Activity: 2383

Merit: 1551

dogs are cute.

Quote from: jackg on December 28, 2018, 02:08:40 PM

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

Its fairly plausible. Its more likely to happen by a person who's bound to use shortcuts and whose hands work faster than the brain.

Also, where the fuck do you live to get 1GBps WiFi? If you don't mind me asking, I'm guessing wales, but i don't want to assume anything.

Will this bug or whatever you wanna call it ever be patched?

jackg

copper member

Activity: 2856

Merit: 3071

https://bit.ly/387FXHi lightning theory

Quote from: seoincorporation on December 28, 2018, 02:52:35 PM

The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. Wink

A 1 second delay might be enough but I'm not entirely sure how you'd do it, the current implementation for the 1 second delay would mean you'd still end up refreshing your screen and double spending merit as there is a global one second delay for everything on the forum when a new page loads (other than the merit one clearly)...

seoincorporation

legendary

Activity: 3346

Merit: 3125

Quote from: jackg on December 28, 2018, 02:08:40 PM

Quote from: LoyceV on December 28, 2018, 01:56:39 PM

Quote from: Obiwankenodium on December 28, 2018, 01:39:53 PM

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

Quote

and it wouldt harm the rapid merit senders.

See:

Code:

October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to audaciousbeing for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to figmentofmyass for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to KonstantinosM for Re: Universal Basic Income Is Silicon Valley’s Latest Scam

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point Grin

.

With that hardware, you could run a lot of virtual machines and give one merit from each one at the same time with iMacros.

Quote from: jackg on December 28, 2018, 02:08:40 PM

Quote from: Obiwankenodium on December 28, 2018, 01:39:53 PM

Quote from: Yeahpro on December 28, 2018, 01:14:54 PM

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

10 seconds would probably harm me sometimes...

The server shouldn't let you send merits on the same second, for a reason it doesn't let us make posts on that time rate, and that's the first bug. That bug could be fixed with a cooldown of 1 or 2 seconds. The second bug is on the 'Send' button, it shouldn't be clickable after we already make click. Wink

jackg

copper member

Activity: 2856

Merit: 3071

https://bit.ly/387FXHi lightning theory

Quote from: LoyceV on December 28, 2018, 01:56:39 PM

Quote from: Obiwankenodium on December 28, 2018, 01:39:53 PM

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

Quote

and it wouldt harm the rapid merit senders.

See:

Code:

October 13, 2018, 09:18:22 AM: 1 to Indamuck for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to audaciousbeing for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to figmentofmyass for Re: Universal Basic Income Is Silicon Valley’s Latest Scam
October 13, 2018, 09:18:22 AM: 1 to KonstantinosM for Re: Universal Basic Income Is Silicon Valley’s Latest Scam

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

I'm guessing you read a lot of posts and just start opening the merit link in a new tab ready to hammer the 1 and the send button. I think this is just proof that you're a bit though from this point Grin

.

Quote from: Obiwankenodium on December 28, 2018, 01:39:53 PM

Quote from: Yeahpro on December 28, 2018, 01:14:54 PM

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

10 seconds would probably harm me sometimes...

LoyceV

legendary

Activity: 3290

Merit: 16489

Thick-Skinned Gang Leader and Golden Feather 2021

Quote from: Obiwankenodium on December 28, 2018, 01:39:53 PM

A cooldown of 10-30 secons would be enough i guess

The 4 seconds between reporting posts is already annoying and slowing me down!

Quote from: jackg on December 28, 2018, 02:08:40 PM

I still can't understand how you were that fast. On my 1GBps WiFi with a brand new hexadec 4.5 GHz (16 cores) I still don't think I'd be that fast.

All it takes is 4 clicks

Obiwankenodium

copper member

Activity: 322

Merit: 15

Quote from: Yeahpro on December 28, 2018, 01:14:54 PM

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

A cooldown of 10-30 secons would be enough i guess and it wouldt harm the rapid merit senders.

Yeahpro

member

Activity: 72

Merit: 12

A cool down time has been suggested, but i think there are some members who send merits rather quickly and would not appreciate a gap between merit awarding.

An issue that should be resolved is the '0' that is by default on the box for selecting number of merits to send.
The number of merits has to be delicately positioned after the 0, or the zero cleared first.
It adds nothing, as it's impossible to send zero merits and there's the chance a user could send 10 merits when trying to send 1. This poses an issue to members with lots of smerits available.

jackg

copper member

Activity: 2856

Merit: 3071

https://bit.ly/387FXHi lightning theory

I don't think it was worth making a thread on it, but if you hit the button on public WiFi it can send twice (if there's more than one router and you get switched between the two during that time, I was sat very near one of the routers too so I don't know why I was moved across.

As the others have said, this is a known thing as well as refreshing the merit sent page. It's not a bug, I think it was theymos intention.

Findingnemo

hero member

Activity: 2366

Merit: 793

Bitcoin = Financial freedom

Already reported by many people,having cool down time between the two merit transaction will help to resolve this issue.Hopefully theymos will identify this bug and sort of the problem.

Two AI were fighting so hard to beat satoshi on merit list. Grin

DdmrDdmr

legendary

Activity: 2338

Merit: 10802

There are lies, damned lies and statistics. MTwain

I was taking a look into this too. Since there was a 1 second gap in the @OgNasty -> @seoincorporation example in the OP, grouping by exact time would not catch these cases, so I went on to giving a 2 second margin (searching for all TXs within a 2 second gap with the same implied users and message and date).

I make it 317 TXs historically by the above criteria (see https://docs.google.com/spreadsheets/d/1JmMF_SZX0oWgK8L2BL-lkB0aDMAIW7HB2OWJKXxtrag/edit?usp=sharing), with 155 different real intended TX sends (the others are side effects of double or triple clicking the send button).

No too many cases, and roughly let’s say half of the implied sMerits being non-intentional (602 sMerits -> would mean 301 non-intentional sent sMerits historically).

LoyceV

legendary

Activity: 3290

Merit: 16489

Thick-Skinned Gang Leader and Golden Feather 2021

seoincorporation

legendary

Activity: 3346

Merit: 3125

So, a couple of days ago i realize there is a bug on the merit engine.

When we are in the merit box ready to spend our merits:

If we click two times the button it will send double merit before the forum send us to 'Merit sent!' page.

And that way some users are getting double merits, sending double merits already happened to me once while i was sending merit to user bomj as you can see on the next image.

And i think i get two merits on a publication for the same bug:

Topic: Bug on the merit system? (Read 831 times)