Checklocktimeverify | Bitcointalksearch.org

gmaxwell

staff

Activity: 4284

Merit: 8808

Quote from: bitcreditscc on March 26, 2015, 04:50:28 PM

Just saw this, i think it's amazing. I'm wondering what it wasn't included in version 0.10.x?

https://github.com/bitcoin/bitcoin/compare/master...petertodd:checklocktimeverify

Because it's not a finished proposal according to its author (and it was created too late for 0.10 in any case.)

bitcreditscc

hero member

Activity: 602

Merit: 501

Quote from: Cryddit on March 26, 2015, 07:39:50 PM

What do you not see that you think should be there?

They incremented the version,
Moved nLockTime to another file,
Converted OP_NOP2 to OP_CHECKLOCKTIMEVERIFY,
Added a parameter (with a default value) to CScriptNum,
and added a bunch of test cases to make sure that OP_CHECKLOCKTIMEVERIFY does exactly what it's supposed to.

I don't see a problem with these changes. Are you just thinking that something should have been done sooner?

If I were a betting man, I'd bet on the test cases not having been ready in time for v.0.10, but I don't actually know. In any case, don't push for quicker feature inclusion in something that has security implications - you really want them to take the time to be absolutely sure it's right before they put it in there.

Yeah, the code isn't in the main repo, that is what i am saying. I'll include it in mine and run some tests, maybe report back here.

Either way it's a great idea and will allow more to be possible. Do you know any other OPs that are on hold?

Cryddit

legendary

Activity: 924

Merit: 1132

What do you not see that you think should be there?

They incremented the version,
Moved nLockTime to another file,
Converted OP_NOP2 to OP_CHECKLOCKTIMEVERIFY,
Added a nMaxNumSize parameter (with a default value) to CScriptNum,
and added a bunch of test cases to make sure that OP_CHECKLOCKTIMEVERIFY does exactly what it's supposed to.

I don't see a problem with these changes. Are you just thinking that something should have been done sooner?

If I were a betting man, I'd bet on the test cases not having been ready in time for v.0.10, but I don't actually know. In any case, don't push for quicker feature inclusion in something that has security implications - you really want them to take the time to be absolutely sure it's right before they put it in there.

bitcreditscc

hero member

Activity: 602

Merit: 501

Just saw this, i think it's amazing. I'm wondering what it wasn't included in version 0.10.x?

https://github.com/bitcoin/bitcoin/compare/master...petertodd:checklocktimeverify

Topic: Checklocktimeverify (Read 873 times)