Bandwith and traffic.
There is literally not a single good reason to connect your electrum server and electrum client via Tor if both of them share the same local network.
You not only decrease the security and potentially the privacy, but also increase your bandwith and overall traffic.
Do you see an advantage doing this instead of keeping it all inside of your local network? If so, which is it?
Thank you.
I came to same conclusion recently.
I disabled all services in ElectrumX except for SSL connection with certificate. All peers now are connecting using my Let's Encrypt cert, including my LAN wallets. LAN wallets are connecting directly, on Ethernet, via SSL connection. Everything works perfectly fine and I will leave it at that.
I may revisit the problem later, as I am trying to make ElectrumX tor-only, but I have trouble connecting my wallets when I use self-signed certificate (which is required in Tor-only mode). Only Let's Encrypt certificate works now. I will keep digging.
Thanks for all your insights folks!