explain the bugs fixed with 0.16.3 version

digital_mine

member

Activity: 99

Merit: 14

Quote from: seoincorporation on September 28, 2018, 12:33:08 AM

Quote from: bones261 on September 22, 2018, 09:46:10 AM

Quote from: digital_mine on September 22, 2018, 09:38:13 AM

Thank you!!
I have some CLAM and I know it is a bitcoin clone, so I'll go to check in order to understand if my funds are safe

It appears Clam's last commit was in January 2017. This was before the vulnerability in Bitcoin Core was introduced. Your coins are safe.

Yep, i ask to the clam community if they where affected to the bug and looks like they doesn't because their cone is based on a old version of bitcoin core,

The explanation from bones was great, i just want to add a couple of points, from what i understand:

1.-This bug could be only exploited by miners, and if they do it, they could lost the $80k reward, so wasn't even a good deal.
2.-The bug allow to create new coins, and this wouldn't be the first time it happens.

I've asked as well on the clam thread and I got the same reply as you got!
I think that it is time for them to upgrade by the way

seoincorporation

legendary

Activity: 3346

Merit: 3130

Quote from: bones261 on September 22, 2018, 09:46:10 AM

Quote from: digital_mine on September 22, 2018, 09:38:13 AM

Thank you!!
I have some CLAM and I know it is a bitcoin clone, so I'll go to check in order to understand if my funds are safe

It appears Clam's last commit was in January 2017. This was before the vulnerability in Bitcoin Core was introduced. Your coins are safe.

Yep, i ask to the clam community if they where affected to the bug and looks like they doesn't because their cone is based on a old version of bitcoin core,

The explanation from bones was great, i just want to add a couple of points, from what i understand:

1.-This bug could be only exploited by miners, and if they do it, they could lost the $80k reward, so wasn't even a good deal.
2.-The bug allow to create new coins, and this wouldn't be the first time it happens.

digital_mine

member

Activity: 99

Merit: 14

Quote from: bones261 on September 22, 2018, 09:46:10 AM

Quote from: digital_mine on September 22, 2018, 09:38:13 AM

Thank you!!
I have some CLAM and I know it is a bitcoin clone, so I'll go to check in order to understand if my funds are safe

It appears Clam's last commit was in January 2017. This was before the vulnerability in Bitcoin Core was introduced. Your coins are safe.

Nice to know!!
thanks a lot mate

bones261

legendary

Activity: 1806

Merit: 1828

Quote from: digital_mine on September 22, 2018, 09:38:13 AM

Thank you!!
I have some CLAM and I know it is a bitcoin clone, so I'll go to check in order to understand if my funds are safe

It appears Clam's last commit was in January 2017. This was before the vulnerability in Bitcoin Core was introduced. Your coins are safe.

digital_mine

member

Activity: 99

Merit: 14

Quote from: bones261 on September 22, 2018, 08:52:11 AM

Quote from: digital_mine on September 22, 2018, 07:44:29 AM

Please explain to me in simple word, what the important bug fixed with the new version could have done?

Plus I would like to know if the clone coins that basically copy paste the wallet code could be effected by the old bug.

Thank you very much

Any clone coin which forked off of Bitcoin core 0.14.x through 0.16.2, is probably affected. This also includes coins that update their code by porting over changes made by Bitcoin Core.
Here is one of the lines of code in the validation.cpp that needed to be patched. ( https://github.com/bitcoin/bitcoin/commit/d1dee205473140aca34180e5de8b9bbe17c2207d?diff=split#diff-24efdb00bfbe56b140fb006b562cc70bL3035 )

Bug code:

Code:

if (!CheckTransaction(*tx, state, false))

Patched code:

Code:

if (!CheckTransaction(*tx, state, true))

You may what to go to a particular wallet's/coin's git to see if it's latest update has the buggy line of code in the validation.cpp. However, some wallet/coin devs tend to change the code slightly, so this check might not be foolproof.

I know for sure that Bitcoin ABC (BCH) and Litecoin implemented the patch. However, I am not certain about the 100's of other altcoins out there.

Thank you!!
I have some CLAM and I know it is a bitcoin clone, so I'll go to check in order to understand if my funds are safe

bones261

legendary

Activity: 1806

Merit: 1828

Quote from: digital_mine on September 22, 2018, 07:44:29 AM

Please explain to me in simple word, what the important bug fixed with the new version could have done?

Plus I would like to know if the clone coins that basically copy paste the wallet code could be effected by the old bug.

Thank you very much

Any clone coin which forked off of Bitcoin core 0.14.x through 0.16.2, is probably affected. This also includes coins that update their code by porting over changes made by Bitcoin Core.
Here is one of the lines of code in the validation.cpp that needed to be patched. ( https://github.com/bitcoin/bitcoin/commit/d1dee205473140aca34180e5de8b9bbe17c2207d?diff=split#diff-24efdb00bfbe56b140fb006b562cc70bL3035 )

Bug code:

Code:

if (!CheckTransaction(*tx, state, false))

Patched code:

Code:

if (!CheckTransaction(*tx, state, true))

You may want to go to a particular wallet's/coin's git to see if it's latest update has the buggy line of code in the validation.cpp. However, some wallet/coin devs tend to change the code slightly, so this check might not be foolproof.

I know for sure that Bitcoin ABC (BCH) and Litecoin implemented the patch. However, I am not certain about the 100's of other altcoins out there.

digital_mine

member

Activity: 99

Merit: 14

Quote from: butka on September 22, 2018, 08:14:15 AM

Check out this thread by @theymos:

https://bitcointalksearch.org/topic/m.46014777

In particular, read the first paragraph, and you will get the answer to your first question.

I don't think there are copy/paste coins that could be affected, but I don't know for sure.

Thank you for pointing me in the right direction

butka

full member

Activity: 434

Merit: 246

Check out this thread by @theymos:

https://bitcointalksearch.org/topic/m.46014777

In particular, read the first paragraph, and you will get the answer to your first question.

I don't think there are copy/paste coins that could be affected, but I don't know for sure.

digital_mine

member

Activity: 99

Merit: 14

Please explain to me in simple word, what the important bug fixed with the new version could have done?

Plus I would like to know if the clone coins that basically copy paste the wallet code could be effected by the old bug.

Thank you very much

Topic: explain the bugs fixed with 0.16.3 version (Read 263 times)