gettransaction for non-wallet transactions?

Herbert

hero member

Activity: 488

Merit: 500

Cool, got it working :-)

CMerkleTx is the class to use:

Code:

// construct COutPoint to satisfy ReadFromDisk method
COutPoint dummyOutp(hash, 0);
CMerkleTx mtx;
mtx.ReadFromDisk(dummyOutp);
mtx.SetMerkleBranch(NULL);

Passing NULL into SetMerkleBranch actually triggers reading/loading it from the transactionDB. Spent some time thinking how to obtain a CBlock* untill i realized that Roll Eyes

Wrapped this up in some rpc glue code and got my shiny new "getanytransaction" rpc command running Grin

Thanks for your help!

Edit:
In case someone finds this usefull - the code is on github: https://github.com/TripleSpeeder/bitcoin

blueadept

full member

Activity: 225

Merit: 101

Quote from: Herbert on December 08, 2011, 11:13:53 AM

Quote from: etotheipi on December 07, 2011, 02:18:57 PM

It sounds like you have a tx hash and you want to retrieve the tx. Yes, that should be an easy modification to bitcoind.

Yes, that's what i want to do.

Glancing at the code the current implementation is completely wallet-centric. GetTransaction() from main.cpp walks through all wallets and calls wallet->getTransaction(), and also returns wallet-specific CWalletTx object. So it does not really look like a trivial patch :-/

Is there already a patch existing somewhere providing this feature? Alternatively any hints where i should start doing my own patch are welcome ;-)

I'm not super familiar with the code, but non-wallet transactions HAVE TO BE indexed for validation of incoming transactions/blocks. Each new transaction contains inputs which are outputs of previous transactions, referenced by the hash of the previous transaction and the index of the output used as the input so fast lookup is essential for validating new transactions/blocks. You're more likely to find what you want in db.h and db.cpp (look for CTxDB::ReadDiskTx(...) methods).

Herbert

hero member

Activity: 488

Merit: 500

Quote from: etotheipi on December 07, 2011, 02:18:57 PM

It sounds like you have a tx hash and you want to retrieve the tx. Yes, that should be an easy modification to bitcoind.

Yes, that's what i want to do.

Glancing at the code the current implementation is completely wallet-centric. GetTransaction() from main.cpp walks through all wallets and calls wallet->getTransaction(), and also returns wallet-specific CWalletTx object. So it does not really look like a trivial patch :-/

Is there already a patch existing somewhere providing this feature? Alternatively any hints where i should start doing my own patch are welcome ;-)

etotheipi

legendary

Activity: 1428

Merit: 1093

Core Armory Developer

Quote from: Pieter Wuille on December 07, 2011, 10:31:41 AM

Not true, you don't need a rescan to find an arbitrary transaction, if you have the block chain database. It's just not implemented.

My bad. I thought you asked about looking up transactions for a given address. It sounds like you have a tx hash and you want to retrieve the tx. Yes, that should be an easy modification to bitcoind.

Pieter Wuille

legendary

Activity: 1072

Merit: 1181

Not true, you don't need a rescan to find an arbitrary transaction, if you have the block chain database. It's just not implemented.

dogisland

sr. member

Activity: 262

Merit: 250

There's an import/export private key patch.

https://bitcointalksearch.org/topic/pull-private-key-and-wallet-exportimport-8091

I believe this does a rescan on each import.

etotheipi

legendary

Activity: 1428

Merit: 1093

Core Armory Developer

Your bitcoind would have to do a full rescan of the blockchain, which it is probably prohibitively slow in the Satoshi client. I'm sure the client could be hacked to do this, though.

Herbert

hero member

Activity: 488

Merit: 500

Hi,

I understand that the gettransactions command only will return transactions concerning the users wallet. Is there a way to query bitcoind for any transaction, independent of the users wallet?

Thanks!

Topic: gettransaction for non-wallet transactions? (Read 1754 times)