Github Brainwallet is not the same as Brainwallet.org

happygeorge

full member

Activity: 146

Merit: 100

In da Jungle!

Quote from: wingsuit on April 05, 2013, 10:54:04 AM

Quote from: happygeorge on April 05, 2013, 10:28:25 AM

OH MY GOD!!!

I FOUND THE PROBLEM!!!

i wanted to upload the two images of the old vs new versions!!!

I didn't notice, but the COMPRESSED/UNCOMPRESSED menu/buttons have changed!

------------------------------------------------
NEW VERSION:

Point Conversion: COMPRESSED UNCOMPRESSED

------------------------------------------------
OLD VERSION:

Point Conversion: UNCOMPRESSED COMPRESSED

------------------------------------------------

I didn't notice that the default Point Conversion has been changed. So everything is cool, I had my passphrase in the old version in Uncompressed mode, and so I now have to Click on Uncompressed to get the same public/private keypair

[thanks to CIYAM for giving a PM hint to what it may have been]

--- one more thing: I wanted to post screengrabs of this, but I couldn't post any images here, help? --

happygeorge is happy?

YES!

I wish I could put a huge grin/happy face pic here!

wingsuit

member

Activity: 64

Merit: 10

2100 trillion sats baby

Quote from: happygeorge on April 05, 2013, 10:28:25 AM

OH MY GOD!!!

I FOUND THE PROBLEM!!!

i wanted to upload the two images of the old vs new versions!!!

I didn't notice, but the COMPRESSED/UNCOMPRESSED menu/buttons have changed!

------------------------------------------------
NEW VERSION:

Point Conversion: COMPRESSED UNCOMPRESSED

------------------------------------------------
OLD VERSION:

Point Conversion: UNCOMPRESSED COMPRESSED

------------------------------------------------

I didn't notice that the default Point Conversion has been changed. So everything is cool, I had my passphrase in the old version in Uncompressed mode, and so I now have to Click on Uncompressed to get the same public/private keypair

[thanks to CIYAM for giving a PM hint to what it may have been]

--- one more thing: I wanted to post screengrabs of this, but I couldn't post any images here, help? --

happygeorge is happy?

happygeorge

full member

Activity: 146

Merit: 100

In da Jungle!

OH MY GOD!!!

I FOUND THE PROBLEM!!!

i wanted to upload the two images of the old vs new versions!!!

I didn't notice, but the COMPRESSED/UNCOMPRESSED menu/buttons have changed!

------------------------------------------------
NEW VERSION:

Point Conversion: COMPRESSED UNCOMPRESSED

------------------------------------------------
OLD VERSION:

Point Conversion: UNCOMPRESSED COMPRESSED

------------------------------------------------

I didn't notice that the default Point Conversion has been changed. So everything is cool, I had my passphrase in the old version in Uncompressed mode, and so I now have to Click on Uncompressed to get the same public/private keypair

[thanks to CIYAM for giving a PM hint to what it may have been]

--- one more thing: I wanted to post screengrabs of this, but I couldn't post any images here, help? --

happygeorge

full member

Activity: 146

Merit: 100

In da Jungle!

Quote from: Stephen Gornick on April 05, 2013, 06:13:02 AM

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

The core of the code shouldn't change with time should it

The .html, .css and .js may see updates. Several were just made:
- https://github.com/brainwallet/brainwallet.github.com/commits/master

I believe there are no changes that are not backward compatible. (i.e., the new page will work with your old keys.)

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

[the current github files generate the same codes as the website!]

Correct. What is in the Github project repo and what is served on brainwallet.org are currently in sync.

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

How can I include here the zip of the Github files I download back then?

Well, unfortunately the project isn't getting tagged with version numbers that align with the source, so it could be hard for you to know what was the last commit that matches what you currently have.

If your .zip includes the .git project directory, you can see the hash for it:
$ git rev-list --max-count=1 HEAD

That will let you see where in the list of commits your version is at and from that you can see what has been done since.

I am on windows xp Sad

I do not see a .git directory on my old or even the new version. The only thing is that the old .zip files say "© Brainwallet 2012" at the bottom left of the page, the new viersion says: "© Brainwallet 2012-2013"

Shouldn't these be backwards compatible?

Stephen Gornick

legendary

Activity: 2506

Merit: 1010

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

The core of the code shouldn't change with time should it

The .html, .css and .js may see updates. Several were just made:
- https://github.com/brainwallet/brainwallet.github.com/commits/master

I believe there are no changes that are not backward compatible. (i.e., the new page will work with your old keys.)

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

[the current github files generate the same codes as the website!]

Correct. What is in the Github project repo and what is served on brainwallet.org are currently in sync.

Quote from: happygeorge on April 05, 2013, 02:31:34 AM

How can I include here the zip of the Github files I download back then?

Well, unfortunately the project isn't getting tagged with version numbers that align with the source, so it could be hard for you to know what was the last commit that matches what you currently have.

If your .zip includes the .git project directory, you can see the hash for it:
$ git rev-list --max-count=1 HEAD

That will let you see where in the list of commits your version is at and from that you can see what has been done since.

happygeorge

full member

Activity: 146

Merit: 100

In da Jungle!

I just checked to see if the Brainwallet js I downloaded from github a few months ago (in 2012) still matches results given by the brainwallet.org site

THEY DON'T MATCH!!!

... this is scary because I generated my super secret VAULT addresses offline,and if they can't be recreated without my saved zip version, that sucks!

The core of the code shouldn't change with time should it... do i understand this wrong?

[the current github files generate the same codes as the website!]

How can I include here the zip of the Github files I download back then?

Topic: Github Brainwallet is not the same as Brainwallet.org (Read 1538 times)