Topic: Has someone actually revised the entire code? (Read 1969 times)
Yeah, you are right, sorry about that. It is not the right thread. I just read Gavin's answer. Thanks.
Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.
If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
Not the right thread, and gavin answered it at https://bitcointalksearch.org/topic/m.99523 1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.
If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
Steps to reproduce:
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.
If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
1) withdraw X BTC from Mt.Gox;
2) then you will get it with 0.3.21;
3) try to send it to some address.
If you will close 0.3.21 and run <0.3.21 - it will send without any fee.
We could pass all revisions through Gerrit to enforce Code review and sign-off... 
I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. 
??
Explain.
I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. Not sure what you mean by this? Normal transactions remain free.
Ha, didn't know his forum name 
There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.
https://code.google.com/p/bitcoinj/
https://code.google.com/p/bitcoinj/
That guy was even the first to respond in this thread
There is even a guy who implemented an entire bitcoin client in Java, so I guess he's looked at the entire source.
https://code.google.com/p/bitcoinj/
https://code.google.com/p/bitcoinj/
I've looked through most of it. All the important parts for payment verification anyway.
What you think about the 0.3.21 release? It seems that it requires mandatory fee. 
Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
You don't get total coverage by separately reviewing every part of the code, because the different parts of the code may interact in ways that were not anticipated.
Many people have each revised parts of the code. Every part of the code has been revised by someone. good enough?
Several people are working on different bitoin parts and propose patches (see : https://github.com/bitcoin/bitcoin/pulls).
So we can't say with that that all code has been reviewed, but it's a good start :p
So we can't say with that that all code has been reviewed, but it's a good start :p
I've looked through most of it. All the important parts for payment verification anyway. I think a few others have too (Hal, for one).
Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated.
Now, that doesn't mean I'm fully convinced it's correct. BitCoin is VERY complicated.
So the code is open-source and revisable wich is good, but has someomne actully looked through the entire code?
Jump to: