How to upgrade wallet for taproot support in versions <23?

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Quote from: TracaChang on April 11, 2022, 01:21:06 PM

Does it means that when it will be implemented it will be also easier to create a watch only wallet to create unsigned transactions? For now what I do is create a wallet offline, get the descriptors info with "listdescriptors" and export to the watch only wallet as mentioned here: https://bitcointalksearch.org/topic/bitcoin-core-create-a-watch-only-wallet-and-sign-transactions-offline-tutorial-5392824

No, you will still need to get the descriptors explicitly to make a watch only wallet. It is not enough to just have a xpub.

Quote from: TracaChang on April 11, 2022, 01:21:06 PM

I was wondering that when taproot descriptors are added for old descriptor wallets I would just repeat the same steps, is that correct or another way to do it will be possible?

There will be a new RPC rather than reusing upgradewallet.

TracaChang

jr. member

Activity: 32

Merit: 128

Quote from: achow101 on April 10, 2022, 09:04:44 PM

That's expected behavior. The feature is not yet implemented as there is a prerequisite refactor that has not been merged yet.

Thanks for the answer, I will close the github issue.

Reading the pull request you mention https://github.com/bitcoin/bitcoin/pull/23417

Quote

This allows us to have a concept of a wallet HD key for descriptor wallets. This makes it easier to add new single key descriptors that use the same HD master key as the rest of the autogenerated descriptors (e.g. for taproot). Multisigs will also be easier as an xpub belonging to the wallet can be exported without needing to do weird things like descriptor introspection and guessing about which descriptor's key to use.

Does it means that when it will be implemented it will be also easier to create a watch only wallet to create unsigned transactions? For now what I do is create a wallet offline, get the descriptors info with "listdescriptors" and export to the watch only wallet as mentioned here: https://bitcointalksearch.org/topic/bitcoin-core-create-a-watch-only-wallet-and-sign-transactions-offline-tutorial-5392824

I was wondering that when taproot descriptors are added for old descriptor wallets I would just repeat the same steps, is that correct or another way to do it will be possible?

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

That's expected behavior. The feature is not yet implemented as there is a prerequisite refactor that has not been merged yet.

TracaChang

jr. member

Activity: 32

Merit: 128

Quote from: nc50lc on April 07, 2022, 12:21:49 AM

Try to open a new issue - feature request: something like "add an option to create taproot descriptor for old descriptor wallets".

Thank you. I've just opened a new issue-feature request: https://github.com/bitcoin/bitcoin/issues/24801

nc50lc

legendary

Activity: 2534

Merit: 6080

Self-proclaimed Genius

I can't find any PR that added any "taproot upgrade" wallet command or GUI feature, it's only added by default for newly created descriptor wallets.

For now, you can manually import a new tr() parent descriptor for it to be able to create Bech32m addresses.
The steps are similar to this post: bitcoin.stackexchange.com/questions/108006/how-to-make-a-taproot-transaction-with-bitcoin-cli
But instead of xpub, use xprv.

That version is still in development so it's still open for updates.
Try to open a new issue - feature request: something like "add an option to create taproot descriptor for old descriptor wallets".

TracaChang

jr. member

Activity: 32

Merit: 128

I am trying Bitcoin Core v 23.0 RC3,

I create a new wallet and in receiving tab I can choose Bech32m(taproot).

Using a wallet created with descriptors=true with the precedent version 22.0 does not allow me to receive Bech32taproot (which is normal, since by that time "desc": "tr was not present), so I was wondering how could I upgrade the wallet.

I have tried to upgrade with

Code:

upgradewallet

But it is already updated:

Code:

{
  "wallet_name": "wallet_22.0",
  "previous_version": 169900,
  "current_version": 169900,
  "result": "Already at latest version. Wallet version unchanged."
}

Thank you

Topic: How to upgrade wallet for taproot support in versions <23? (Read 156 times)