Rounding is a major concern on just about anything that does a significant amount of calculation.. It wouldn't be surprising at all if mtgox got that bit wrong... compared to some of the other stuff I wouldn't even consider that an issue right now. OTOH from the initial 1BTC example it looks right (0.0065 rounds to 0.006 using bankers rounding).
btw. you never compare floats for equality.. you compare within a tolerance, or don't use float. I'm not sure why mtgox would need to be comparing floats anyway.. mostly they're showing the results of simple calculations.
That 0.2222 error.. I've made that kind of mistake myself by rounding too early.. it happens. It'll probably be fixed by the code rewrite and if it isn't then's the time to point it out, not now.
Topic: mtgox fee calculations not accurate. (Read 1814 times)
mtgox fees appear to be inaccurate. I thought they charged 0.65%
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
Didn't they drop the fees for the next month due to the website compromise?
Yup, check my signature.
This makes it all the more embarrassing for you.
You should give up. Making comments about programming when you clearly don't have a clue is bound to be embarrassing for you.
Yup, check my signature.
Anyway you are wrong and it seems you cant see it. I give up.
+1, Funny!
It's actually very, very easy to get maths wrong on computers, that's why there's fields of study and university courses about it. If it was simple, this would not be needed.
What's that, bash scripting? Which language uses $ in front of a variable? Anyway you are wrong and it seems you cant see it. I give up.
PHP uses $.
Any floating-point calculation can easily be not exact. That's why floats and doubles should be avoided when working with financial data.
When MtGox comes back up, it will have an entirely new backend. The old backend was built by the previous owner and MagicalTux has beeem working on a rewrite since right after he purchased the site. Discussing an issue with the previous backend us pointless at this point. Wait until it is back up and then check. If it's still an issue, open a ticket and let us know.
That's good to hear. It was just a point of concern.. and I understand if it's not a priority just now.
What's that, bash scripting? Which language uses $ in front of a variable?
perl, tcl, php.. The language is irrelevant.
Anyway you are wrong and it seems you cant see it. I give up.
You should give up. Making comments about programming when you clearly don't have a clue is bound to be embarrassing for you.
When MtGox comes back up, it will have an entirely new backend. The old backend was built by the previous owner and MagicalTux has beeem working on a rewrite since right after he purchased the site. Discussing an issue with the previous backend us pointless at this point. Wait until it is back up and then check. If it's still an issue, open a ticket and let us know.
Who told you the exchange rate was exactly $17.29 and has not been rounded?
The logs show it as $17.29000 - and I'm fairly sure I asked for the trade to occur at 17.29!
It is simply not legitimate to show it with this many decimal places if it was rounded off at 2DP.
Quote
It's very hard to mess up an easy task like multiplying 2 numbers when you program.
No. This is the problem with amateur programmers who try to code with currency.
It is *very easy* to get apparently simple things wrong.
e.g 0.1 * 21.55
depending on the precision used could come out as say 2.1550000000000002
now store that in a variable $x
check if you have the expected value $x == 2.155 and the program returns FALSE.
In this example, I've used floats - just to demonstrate one pitfall.
Rounding during intermediate calculations is another way to introduce inaccuracies and it looks to me as though this is what mt gox is doing.
What's that, bash scripting? Which language uses $ in front of a variable? Anyway you are wrong and it seems you cant see it. I give up.
Who told you the exchange rate was exactly $17.29 and has not been rounded?
The logs show it as $17.29000 - and I'm fairly sure I asked for the trade to occur at 17.29!
It is simply not legitimate to show it with this many decimal places if it was rounded off at 2DP.
Quote
It's very hard to mess up an easy task like multiplying 2 numbers when you program.
No. This is the problem with amateur programmers who try to code with currency.
It is *very easy* to get apparently simple things wrong.
e.g 0.1 * 21.55
depending on the precision used could come out as say 2.1550000000000002
now store that in a variable $x
check if you have the expected value $x == 2.155 and the program returns FALSE.
In this example, I've used floats - just to demonstrate one pitfall.
Rounding during intermediate calculations is another way to introduce inaccuracies and it looks to me as though this is what mt gox is doing.
It's just rounded. Shown value is different form the actual value.
the 2nd is 0.0065 and the 1st is 0.013.
What evidence do you have for that?
Look at this USD fee:
1.98000000 ฿TC at $17.29000 (fee) $0.22220
By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
What makes you think it's a rounding for *display* and not a rounding of the underlying value?
Does/did mtgox have a displayed policy on how they round anyway?
Who told you the exchange rate was exactly $17.29 and has not been rounded? It's very hard to mess up an easy task like multiplying 2 numbers when you program.
This is surely a big no-no. This is as bad as using floats for currency.
Doesn't anyone else have concerns about this?
I do. But I think the best course would be to let them handle the current, more pressing issues... once the site is back up and things are returning to normal, and MagicalTux actually gets to have a full night's sleep, then see if you can open a ticket with them about it.
I agree... it's not something I want to hassle them about right now.. but I do think it warrants discussion and should be public knowledge.
Quote
1.98000000 ฿TC at $17.29000 (fee) $0.22220
By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
The only way I could come up with something close to 0.2222 - was to round during the intermediate calculation.By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
This is surely a big no-no. This is as bad as using floats for currency.
Doesn't anyone else have concerns about this?
I do. But I think the best course would be to let them handle the current, more pressing issues... once the site is back up and things are returning to normal, and MagicalTux actually gets to have a full night's sleep, then see if you can open a ticket with them about it.
Quote
1.98000000 ฿TC at $17.29000 (fee) $0.22220
By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
The only way I could come up with something close to 0.2222 - was to round during the intermediate calculation.
This is surely a big no-no. This is as bad as using floats for currency.
Doesn't anyone else have concerns about this?
It's just rounded. Shown value is different form the actual value.
the 2nd is 0.0065 and the 1st is 0.013.
What evidence do you have for that?
Look at this USD fee:
1.98000000 ฿TC at $17.29000 (fee) $0.22220
By my calculations, at 0.65% - the fee should be $0.22252230
If they're rounding - it's not at a consistent number of DP for BTC compared to USD... and how the hell did they come up with 0.22220 anyway??
What makes you think it's a rounding for *display* and not a rounding of the underlying value?
Does/did mtgox have a displayed policy on how they round anyway?
mtgox fees appear to be inaccurate. I thought they charged 0.65%
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
It's just rounded. Shown value is different form the actual value.
the 2nd is 0.0065 and the 1st is 0.013.
mtgox fees appear to be inaccurate. I thought they charged 0.65%
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
Here is an example:
bought 2 BTC - fee charged: 0.01300000 ฿TC
bought 1 BTC - fee charged: 0.00600000 ฿TC
They undercharged me on the 1BTC trade. (should have been 0.00650000 ฿TC)
I also saw some undercharging on USD values when selling.
So far these minor miscalulations work in the users favour - so I guess nobody is really complaining - but have mtgox said anything about this?
If they're not accurate in charging these fees.. what else are they not accurate in calculating?
Jump to: