Need Math for Halving Interval and Subsidy

marvic4

newbie

Activity: 27

Merit: 0

Quote from: odolvlobo on September 05, 2020, 08:46:12 PM

Quote from: marvic4 on September 05, 2020, 02:41:07 AM

Code:

CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams)
{
    ...
    // Force block reward to zero when right shift is undefined.
    if (halvings >= xxx) --------------Sample
        return 0;
    ...
}

That should be the following regardless of any of the parameters:

Code:

CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams)
{
    ...
    // Force block reward to zero when right shift is undefined.
    if (halvings >= sizeof(nSubsidy) * CHAR_BIT)
        return 0;
    ...
}

In Bitcoin Core, they use the literal 64, which is ok until something changes and then it becomes a bug.

Thanks for replay.

odolvlobo

legendary

Activity: 4466

Merit: 3391

Quote from: marvic4 on September 05, 2020, 02:41:07 AM

Code:

CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams)
{
    ...
    // Force block reward to zero when right shift is undefined.
    if (halvings >= xxx) --------------Sample
        return 0;
    ...
}

That should be the following regardless of any of the parameters:

Code:

CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams)
{
    ...
    // Force block reward to zero when right shift is undefined.
    if (halvings >= sizeof(nSubsidy) * CHAR_BIT)
        return 0;
    ...
}

In Bitcoin Core, they use the literal 64, which is ok until something changes and then it becomes a bug.

marvic4

newbie

Activity: 27

Merit: 0

Quote from: vjudeu on September 05, 2020, 07:55:58 AM

Exactly 7391250, but you can round it to 7400000.
4 years = 126144000 seconds
126144000/600 = 210240 blocks per halving
30 years = 946080000 seconds
946080000/128 = 7391250 blocks per halving

Quote

30% premine

Ouch. It will fail.

Thanks,

vjudeu

hero member

Activity: 813

Merit: 1944

Exactly 7391250, but you can round it to 7400000.
4 years = 126144000 seconds
126144000/600 = 210240 blocks per halving
30 years = 946080000 seconds
946080000/128 = 7391250 blocks per halving

Quote

30% premine

Ouch. It will fail.

marvic4

newbie

Activity: 27

Merit: 0

Quote from: pooya87 on September 05, 2020, 05:09:16 AM

when you keep getting stuck on basic things such as creating genesis block, mining a new block, setting block rewards, total supply,... (according to your post history) then maybe it is a sign that you are on a wrong path and should start by first learning what each of these topics you struggle with are and why they are designed like that instead of just trying to change variables and see which one works to create a new altcoin that has been created thousands of times before in the same exact way.

Thanks, for reading my previous posts, I am aware of basic things how to fork a coin(Older versions, few coins launched). But not expert Like YOU.

Those forked coins have lots of problems (newer versions ). I used to have Genesis tool generators, which work for some coins and won't work most of the coins. That is main thing (tool generator)

That is the reason why i ask a question here. If your not interested in answering it is fine.

Now I asked simple Math, Some one will help. I do help many devs.

Thanks.

pooya87

legendary

Activity: 3472

Merit: 10611

when you keep getting stuck on basic things such as creating genesis block, mining a new block, setting block rewards, total supply,... (according to your post history) then maybe it is a sign that you are on a wrong path and should start by first learning what each of these topics you struggle with are and why they are designed like that instead of just trying to change variables and see which one works to create a new altcoin that has been created thousands of times before in the same exact way.

marvic4

newbie

Activity: 27

Merit: 0

I Need a math here,

max_coin is 30M
30% premine,
30 Years reward goal,
Tragetspacing is 2 * 64 (128 sec)

So, I need to calculate Halving Interval (blocks)
consensus.nSubsidyHalvingInterval = ??

As per above data, how to modify this GetBlockSubsidy()

Code:

CAmount GetBlockSubsidy(int nHeight, const Consensus::Params& consensusParams)
{
    if(nHeight <= consensusParams.nLastBigReward)
       ( return xxxxx * COIN;) --------Sample

    int halvings = (nHeight - consensusParams.nLastBigReward - 1) / consensusParams.nSubsidyHalvingInterval;
    // Force block reward to zero when right shift is undefined.
    if (halvings >= xxx) --------------Sample
        return 0;

    CAmount nSubsidy = xxx * COIN; -----------------Sample
    // Subsidy is cut in half every xxxxxx blocks which will occur approximately every 4 years.
    nSubsidy >>= halvings; 
    return nSubsidy;
}

Thanks,

Topic: Need Math for Halving Interval and Subsidy (Read 165 times)