Author

Topic: Peter Todd: Monero is atrociously bad (Read 1011 times)

hero member
Activity: 723
Merit: 503
July 21, 2015, 09:53:29 AM
#13
"Yup! Rather have cleaned up bad code w/ good crypto over bad crypto.."

https://twitter.com/petertoddbtc/status/622081863008436225
legendary
Activity: 2968
Merit: 1198
July 21, 2015, 09:53:21 AM
#12
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?

Broken (possibly left that way deliberately as an exploit), but also very obscure and undocumented. It was fixed by rewriting it.

I call bullshit.  Probably Smooth never rewrote anything.  Most of what these guys say is 100% bullshit trying to make it sound they are doing lots of work and Monero is really different to cryptonote.  Except the wallet is 8 months old as everyone knows so i cant be that different can it. 

Notice, he didn't say which code he 'fixed', or ya know link to the before and after code, so everyone can go back to sleep.

As I said on the other thread where you are spewing the same nonsense, GTFO

https://github.com/monero-project/bitmonero/commit/2ef0aee81d20c002ed50d6dec4baceee1ac40b44

https://twitter.com/petertoddbtc/status/622081863008436225

Like I said on the other thread, he said the code-base was atrociously bad.  So what else did you change in the code-base to fix it? Answer: Nothing, because Smooth is a total bullshit artist.

GTFO

1. Read his (almost year old) tweet. He referenced a specific file, which was rewritten (as cited above)

2. Sure, "nothing" except 1059 commits: http://pastebin.com/fSJM8m0v
newbie
Activity: 28
Merit: 0
July 21, 2015, 09:45:46 AM
#11
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?

Broken (possibly left that way deliberately as an exploit), but also very obscure and undocumented. It was fixed by rewriting it.

I call bullshit.  Probably Smooth never rewrote anything.  Most of what these guys say is 100% bullshit trying to make it sound they are doing lots of work and Monero is really different to cryptonote.  Except the wallet is 8 months old as everyone knows so i cant be that different can it.  

Notice, he didn't say which code he 'fixed', or ya know link to the before and after code, so everyone can go back to sleep.

As I said on the other thread where you are spewing the same nonsense, GTFO

https://github.com/monero-project/bitmonero/commit/2ef0aee81d20c002ed50d6dec4baceee1ac40b44

https://twitter.com/petertoddbtc/status/622081863008436225

Like I said on the other thread, he said the code-base was atrociously bad.  So what else did you change in the code-base to fix it? Answer: Nothing, because Smooth is a total bullshit artist.
legendary
Activity: 2968
Merit: 1198
July 21, 2015, 09:41:51 AM
#10
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?

Broken (possibly left that way deliberately as an exploit), but also very obscure and undocumented. It was fixed by rewriting it.

I call bullshit.  Probably Smooth never rewrote anything.  Most of what these guys say is 100% bullshit trying to make it sound they are doing lots of work and Monero is really different to cryptonote.  Except the wallet is 8 months old as everyone knows so i cant be that different can it.  

Notice, he didn't say which code he 'fixed', or ya know link to the before and after code, so everyone can go back to sleep.

As I said on the other thread where you are spewing the same nonsense, GTFO

https://github.com/monero-project/bitmonero/commit/2ef0aee81d20c002ed50d6dec4baceee1ac40b44

https://twitter.com/petertoddbtc/status/622081863008436225
newbie
Activity: 28
Merit: 0
July 21, 2015, 09:15:02 AM
#9
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?

Broken (possibly left that way deliberately as an exploit), but also very obscure and undocumented. It was fixed by rewriting it.

I call bullshit.  Probably Smooth never rewrote anything.  Most of what these guys say is 100% bullshit trying to make it sound they are doing lots of work and Monero is really different to cryptonote.  Except the wallet is 8 months old as everyone knows so i cant be that different can it.  

Notice, he didn't say which code he 'fixed', or ya know link to the before and after code, so everyone can go back to sleep.

legendary
Activity: 2968
Merit: 1198
July 21, 2015, 08:15:26 AM
#8
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?

Broken (possibly left that way deliberately as an exploit), but also very obscure and undocumented. It was fixed by rewriting it.
hero member
Activity: 546
Merit: 500
AKA The Rubber Monkey
July 21, 2015, 08:04:20 AM
#7
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.



Just curious, was the bad code that you guys cleaned up just "ugly", or was it bad in that it was unstable or broken?
legendary
Activity: 1256
Merit: 1009
July 21, 2015, 07:55:30 AM
#6
Quote
The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.

Thank you for the clarification.  Appreciate what you guys are accomplishing.
legendary
Activity: 2968
Merit: 1198
July 21, 2015, 07:52:23 AM
#5
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The specific C code he was referring to has been entirely cleaned up, either by rewriting it (in the case of tree-hash referenced above) or documenting where it came from (a well-known crypto library) and verifying that it is unmodified. The rest of the code base was never that bad, but of course can nevertheless be improved, so that process does continue.

hero member
Activity: 546
Merit: 500
AKA The Rubber Monkey
July 21, 2015, 07:48:29 AM
#4
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

That's interesting, but irrelevant and has nothing to do with his latest comments concerning DASH.
legendary
Activity: 1256
Merit: 1009
July 21, 2015, 07:48:01 AM
#3
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!

I'd say "Process of being cleaned up" is probably more appropriate.

The dynamic blocksize limits are probably starting to look attractive to bitcoin.  Speaking of which ... have any of the bitcoin clones implemented a self adjusting blocksize limit?  Might be a good move for darkcoin if it hasn't been done yet.
legendary
Activity: 930
Merit: 1010
July 21, 2015, 07:40:37 AM
#2
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c

This is from a year ago. It has been cleaned up very much since then. But nice try!
legendary
Activity: 2114
Merit: 1090
=== NODE IS OK! ==
July 21, 2015, 07:35:01 AM
#1
https://twitter.com/petertoddbtc/status/507427225927708672

The Cryptonote/Bytecoin codebase #XMR is based on is atrociously bad, orders of magnitude worse than #Bitcoin. WTF: https://raw.githubusercontent.com/amjuarez/bytecoin/master/src/crypto/tree-hash.c
Jump to: