Thanks for the tip !
Note that another advantage of making SHARE_PERIOD larger is that it lowers the amount of traffic between nodes and between nodes and the load on them.
It marginally lowers the amount of traffic between miners and nodes (less longpolls or stratum equivalents: the nodes send less data to miners) but it should be negligible.
Where in p2p.py in version changes needed to force new protocol version ?
in ?
self.send_version(
version=1100,
I'll have to check the code to answer this. But I don't think you want to update this at this point. There are 2 reasons :
- You probably have enough control on the nodes on your network to switch to the updated configuration with very few other people being impacted (details below).
- You probably want to be included in the main P2Pool codebase (this means defining a new network instead of overriding litecoin) or fetch updates from it at some point and upgrading the protocol version would make this impractical.
How to handle the switch to a new configuration:
- change the list of seeds to new ones in your git fork
- start new nodes on these seeds with the new code
- announce your change publicly (with a notice that old nodes will be shut down in 24h for example)
- point people wanting to install a P2Pool node connecting to yours to your git tree so that they can make the switch. recommend them to install their node from scratch instead of trying to upgrade in place (which might let them connected to nodes on the old network and would put unnecessary load on their node without impacting yours as they would act like a filter discarding the data from these nodes)
To be included in the main codebase, you should probably try to reach the main developper (forrestv) here or on IRC. There are contributors in the #p2pool IRC channel that might help too.
