Topic: Segwit raw transaction decoder (Read 238 times)

    for w in witness_stack: # for each input
        signed_transaction += create_varint(len(w)) # stack element count
        witness_bytes = b""
        for w_elem in w:
            witness_bytes += create_varint(len(w_elem)) + w_elem # element varint length + count
        signed_transaction += witness_bytes # Push only the stack itself, we must not include a varint length for the stack here like we would in legacy P2PKH/P2SH (!)

$ grep -r "superfluous" .
./test/functional/p2p_segwit.py:        self.test_superfluous_witness()
./test/functional/p2p_segwit.py:    def test_superfluous_witness(self):
./doc/release-notes/release-notes-0.18.1.md:- #15893 Add test for superfluous witness record in deserialization (instagibbs)
./doc/release-notes/release-notes-0.20.0.md:- #17537 Cleanup and move opportunistic and superfluous TopUp()s (achow101)
Binary file ./src/test/test_bitcoin-script_tests.o matches
Binary file ./src/test/test_bitcoin matches
./src/test/script_tests.cpp:                                "P2SH(P2WPKH) with superfluous push in scriptSig", SCRIPT_VERIFY_WITNESS | SCRIPT_VERIFY_P2SH, true, WitnessMode::PKH
./src/test/data/script_tests.json:    "P2SH(P2WPKH) with superfluous push in scriptSig"
./src/txrequest.cpp:                // requested and/or completed for other reasons and this is just a superfluous RequestedTx call.
./src/script/signingprovider.cpp:    // Also note that having superfluous scripts in the keystore never hurts.
./src/secp256k1/examples/examples_util.h:     *    might try to eliminate "superfluous" memsets.
./src/support/cleanse.cpp:     *    might try to eliminate "superfluous" memsets.
./src/wallet/test/wallet_tests.cpp://! until after it is loaded. The notifications are superfluous in this case, so
./src/wallet/scriptpubkeyman.cpp:        // Related CScripts are not removed; having superfluous scripts around is
./src/wallet/rpc/backup.cpp:        auto subscript = std::move(import_data.redeemscript); // Remove redeemscript from import_data to check for superfluous script later.
./src/wallet/rpc/backup.cpp:        auto subscript = std::move(import_data.witnessscript); // Remove redeemscript from import_data to check for superfluous script later.
./src/wallet/rpc/backup.cpp:            // RecurseImportData() removes any relevant redeemscript/witnessscript from import_data, so we can use that to discover if a superfluous one was provided.

{"error":"Transaction has superfluous witness data"}