Simple logic to avoid confusing tx fee with transaction amount

Itoo

jr. member

Activity: 33

Merit: 1

Quote from: achow101 on May 11, 2016, 11:21:03 PM

Bitcoin core will reject and transaction with an "absurdly high fee". This means that it will not accept it to the mempool and will not relay it. I don't remember what the exact threshold for this is, but I think it is actually fairly low.

Aah, I ran into fRejectAbsurdFee while looking into it. I have yet to figure out the criteria for an absurd fee but I'll post it here when/if I do.

Itoo

jr. member

Activity: 33

Merit: 1

Quote from: goregrind on May 12, 2016, 03:30:55 AM

The reason this simple logic doesn't work is because there are valid transactions where the amount transferred is less than the tx fee.

I mentioned just showing a warning, that allows users to still do what they want....

But why would anyone do this regularly? I can think of some fringe scenarios, but unless you're the miner collecting the fee, you lose money on the deal. So it doesn't make sense for someone to do intentionally under normal circumstances.

fbueller

sr. member

Activity: 412

Merit: 287

It's possible the person wasn't using Bitcoin Core at all, and crafted the transaction themselves.

I just find it unlikely someone would spend 9x 30BTC outputs in a raw transaction that was only a test, and ignore the absurdly high fee warning .

shorena

copper member

Activity: 1498

Merit: 1528

No I dont escrow anymore.

Quote from: achow101 on May 11, 2016, 11:21:03 PM

Bitcoin core will reject and transaction with an "absurdly high fee". This means that it will not accept it to the mempool and will not relay it. I don't remember what the exact threshold for this is, but I think it is actually fairly low.

AFAIK its still accepted and relayed, its just refused if you create a TX with a fee over x*min_relay_fee or 0.1 BTC. Not exact numbers just from memory.

goregrind

full member

Activity: 149

Merit: 100

Quote from: Itoo on May 11, 2016, 11:06:05 PM

I was thinking about the person that accidentally sent about 300 btc as a fee and .001 as the transaction amount, and it occurred to me that some simple logic could be put in place to avoid that. Just add a check to see whether the tx fee is larger than the amount being transferred and if so, either warn the user or reject the transaction or whatever. I don't recall what wallet he was using, but I haven't heard that any wallet has such simple logic yet....

The reason this simple logic doesn't work is because there are valid transactions where the amount transferred is less than the tx fee.

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Bitcoin core will reject and transaction with an "absurdly high fee". This means that it will not accept it to the mempool and will not relay it. I don't remember what the exact threshold for this is, but I think it is actually fairly low.

Itoo

jr. member

Activity: 33

Merit: 1

And just as I post that I see frejectAbsurdFee in main.cpp. I'll see if my limited skills can determine if that fits the bill

Itoo

jr. member

Activity: 33

Merit: 1

I was thinking about the person that accidentally sent about 300 btc as a fee and .001 as the transaction amount, and it occurred to me that some simple logic could be put in place to avoid that. Just add a check to see whether the tx fee is larger than the amount being transferred and if so, either warn the user or reject the transaction or whatever. I don't recall what wallet he was using, but I haven't heard that any wallet has such simple logic yet....

Topic: Simple logic to avoid confusing tx fee with transaction amount (Read 1034 times)