Typo in key.h | Bitcointalksearch.org

Carlton Banks

legendary

Activity: 3430

Merit: 3080

Quote from: Blinken on March 16, 2017, 12:02:27 AM

I am not registered so I cannot submit bugs.

There is an error in this sentence. Bugs cannot be submitted to github repositories, but bug reports can be submitted.

Please correct your error, others reading may be confused by the lack of clarity. Sorry if this seems nitpicky.

gmaxwell

staff

Activity: 4284

Merit: 8808

Quote from: Blinken on March 16, 2017, 12:02:27 AM

In the bitcoin core file key.h there is a typo:

//! Check whether the 32-byte array pointed to be vch is valid keydata.
bool static Check(const unsigned char* vch);

The comment should read:

//! Check whether the 32-byte array pointed to by vch is valid keydata.

I am not registered so I cannot submit bugs. Maybe somebody who works with the code base can fix it.

Thanks for pointing this out-- only takes a second to register on github... but if you don't it'll get picked up eventually.

Please feel free to report any other issues you find (though best on github!)

achow101

staff

Activity: 3458

Merit: 6793

Just writing some code

Typos, especially just comment typos, are generally very low priority and don't need their own pull requests for every single typo, especially one character ones like this. These are usually batched into big "typo fix" PRs. There really isn't any need to fix typos anyways, the comments are generally understandable.

Blinken

sr. member

Activity: 338

Merit: 253

In the bitcoin core file key.h there is a typo:

//! Check whether the 32-byte array pointed to be vch is valid keydata.
bool static Check(const unsigned char* vch);

The comment should read:

//! Check whether the 32-byte array pointed to by vch is valid keydata.

I am not registered so I cannot submit bugs. Maybe somebody who works with the code base can fix it.

Topic: Typo in key.h (Read 861 times)