300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 3.

grazcoin

sr. member

Activity: 284

Merit: 250

Quote from: ripper234 on March 15, 2014, 11:53:30 AM

Quote from: jeroenn13 on March 15, 2014, 10:58:04 AM

So there is no way to cancel my selling order?

Hmm, I was about to point you towards masterchain for that, but I can't find the Cancel function on it at all Sad

(I opened a bug on this as well).

Let's see if we can at least get an explanation of how to do this using the mastercoin-tools python script.

I just answered on this issue on github:
cancel is not available on masterchain.info, but it is available on demo.masterchain.info.
simply visit the same sell offer on demo, and you'll see the button.

jeroenn13

hero member

Activity: 644

Merit: 500

Quote from: ripper234 on March 15, 2014, 01:28:13 PM

Quote from: jeroenn13 on March 15, 2014, 10:58:04 AM

So there is no way to cancel my selling order?

Quote from: zathras on March 15, 2014, 12:17:09 PM

Craig just pinged me to say there was a critical bug with cancelling sell orders - sorry about that guys - committed a fix (here). 4AM & need to sleep so heading offline again

Thanks
Zathras

I did tell Craig to wait until it's 8 AM your time before waking you

I confirmed it now and the fix seems to be working.

jeroenn13 - can you verify on your end?

I can confirm it works now.
https://masterchest.info/lookuptx.aspx?txid=1260b28bb77ce470d31725294a65b3c5f920f8ebef3fbd0449f48c9ecd6e5956

Thank you

ripper234

legendary

Activity: 1358

Merit: 1003

Ron Gross

Quote from: jeroenn13 on March 15, 2014, 10:58:04 AM

So there is no way to cancel my selling order?

Quote from: zathras on March 15, 2014, 12:17:09 PM

Craig just pinged me to say there was a critical bug with cancelling sell orders - sorry about that guys - committed a fix (here). 4AM & need to sleep so heading offline again

Thanks
Zathras

I did tell Craig to wait until it's 8 AM your time before waking you

I confirmed it now and the fix seems to be working.

jeroenn13 - can you verify on your end?

jakecnn

newbie

Activity: 34

Merit: 0

Quote from: ripper234 on March 15, 2014, 12:00:22 PM

Quote from: jakecnn on March 15, 2014, 11:53:47 AM

I just encountered the same problem, can't cancel my order.

Also, the message 'ping?' isn't really helpful at masterchain.info when trying to create a sell offer while another one is active. When I try to cancel the offer(that is using 0 as amount), I also get 'ping?' after a long delay.

Understood - please open a bug - https://github.com/grazcoin/mastercoin-tools/issues

I think something is wrong with the server, trying to accept an offer returns the same message.

zathras

sr. member

Activity: 266

Merit: 250

Craig just pinged me to say there was a critical bug with cancelling sell orders - sorry about that guys - committed a fix (here). 4AM & need to sleep so heading offline again

Thanks
Zathras

jakecnn

newbie

Activity: 34

Merit: 0

Another weird thing is the timelimit: I made an offer today and someone accepted and payed 15 minutes later(issued the tx at least). Now the timelimit was set to 20 blocks and I think it took about 24 blocks until the payment was confirmed... So basically I got free bitcoin while the other person payed in a timely manner from his point of view(15 minutes), but due to the nature of complexer transactions, fees and the mercy of miners his transaction got delayed. It was just a tiny amount(0.00012), but if people are unaware of this, it can cause quite some financial damage to them.
This system appears unreliable to me. There should at least be warnings in the wallets/clients if users want to issue/accept an offer with an unreasonable short time limit.

ripper234

legendary

Activity: 1358

Merit: 1003

Ron Gross

Quote from: jakecnn on March 15, 2014, 11:53:47 AM

I just encountered the same problem, can't cancel my order.

Also, the message 'ping?' isn't really helpful at masterchain.info when trying to create a sell offer while another one is active. When I try to cancel the offer(that is using 0 as amount), I also get 'ping?' after a long delay.

Understood - please open a bug - https://github.com/grazcoin/mastercoin-tools/issues

jakecnn

newbie

Activity: 34

Merit: 0

I just encountered the same problem, can't cancel my order.

Also, the message 'ping?' isn't really helpful at masterchain.info when trying to create a sell offer while another one is active. When I try to cancel the offer(that is using 0 as amount), I also get 'ping?' after a long delay.

ripper234

legendary

Activity: 1358

Merit: 1003

Ron Gross

Quote from: jeroenn13 on March 15, 2014, 10:58:04 AM

So there is no way to cancel my selling order?

Hmm, I was about to point you towards masterchain for that, but I can't find the Cancel function on it at all Sad

(I opened a bug on this as well).

Let's see if we can at least get an explanation of how to do this using the mastercoin-tools python script.

jeroenn13

hero member

Activity: 644

Merit: 500

So there is no way to cancel my selling order?

jeroenn13

hero member

Activity: 644

Merit: 500

Quote from: ripper234 on March 15, 2014, 07:54:50 AM

Quote from: jeroenn13 on March 15, 2014, 07:50:02 AM

The cancelsell uses TMSC as currency even if I selected MSC this makes my cancelsell invalid.
Could anyone take a look at this?

Tx: https://masterchest.info/lookuptx.aspx?txid=0b23746a4c699be7b2d64c90b25b45928487bb1942d716c265b7c64ebd21b2d3

Thanks for reporting!

I opened an issue on this - in the future can you just open an issue directly on https://github.com/zathras-crypto/masterchest-wallet/issues ?

Can you add to the issue I opened steps to reproduce / screenshots?

(Including a screenshot is easy - just alt-printscreen to capture the current window, and paste directly into github)

Thanks again for reporting, sounds like a high priority issue.

Done, thank you for responding

ripper234

legendary

Activity: 1358

Merit: 1003

Ron Gross

Quote from: jeroenn13 on March 15, 2014, 07:50:02 AM

The cancelsell uses TMSC as currency even if I selected MSC this makes my cancelsell invalid.
Could anyone take a look at this?

Tx: https://masterchest.info/lookuptx.aspx?txid=0b23746a4c699be7b2d64c90b25b45928487bb1942d716c265b7c64ebd21b2d3

Thanks for reporting!

I opened an issue on this - in the future can you just open an issue directly on https://github.com/zathras-crypto/masterchest-wallet/issues ?

Can you add to the issue I opened steps to reproduce / screenshots?

(Including a screenshot is easy - just alt-printscreen to capture the current window, and paste directly into github)

Thanks again for reporting, sounds like a high priority issue.

jeroenn13

hero member

Activity: 644

Merit: 500

The cancelsell uses TMSC as currency even if I selected MSC this makes my cancelsell invalid.
Could anyone take a look at this?

Tx: https://masterchest.info/lookuptx.aspx?txid=0b23746a4c699be7b2d64c90b25b45928487bb1942d716c265b7c64ebd21b2d3

ripper234

legendary

Activity: 1358

Merit: 1003

Ron Gross

Great job zathas pulling it off like that - I know it wasn't easy!
Get some rest over the weekend, I know you need it...

zathras

sr. member

Activity: 266

Merit: 250

OK. Finally got alpha 0.3 up (here). Transaction processing is a bit slow in this build as I haven't had a chance to optimize the new DEx payment stuff yet (please be patient). I'll continue to work on optimizing and UX improvements over the coming days

Thanks
Zathras

zathras

sr. member

Activity: 266

Merit: 250

Hey guys,

Been a crazy 24 hours, but pleased to say the rewrite is done - just in the nick of time

Whilst payments don't carry Master Protocol messages they are nonetheless now treated as MP messages and queued along with them. Payments can now be used as independent entities (rather than metadata for the accept transaction).

This should align me with Masterchain & sort the remaining consensus issues, though I think I have to clear up a potential rounding issue. New code is straight to live (I've done limited bug fixing myself).

Wallet alpha with real MSC enabled will be up in the next hour or so. Remember, this is alpha software so test with tiny amounts.

Thanks

Zathras

Bitoy

sr. member

Activity: 449

Merit: 250

Grazcoin,

Please take a look at
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb

We are in consensus before I sent a Cancel Sell Offer.
MM=46.63879623 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=47.72567223

Difference 1.086876

Was there a change in your code (ie invalidating some transactions discussed earlier)?

udecker

full member

Activity: 142

Merit: 252

58 blocks to go until the DEx is live!

Blog update on the week’s progress now posted at: http://blog.mastercoin.org/

Craig

zathras

sr. member

Activity: 266

Merit: 250

Quote from: grazcoin on March 14, 2014, 07:04:23 AM

Quote from: zathras on March 13, 2014, 04:20:19 PM

Hey Graz,

Shame we couldn't have you on the dev sync this morning Sad

Re the same block discussion, I actually agree with your logic but it's not how Masterchest is coded. I put forward your case for allowing different parts of a DEx transaction to occur same block & as much as it means extra changes for me we suggested that it's the better way to go. This has been accepted by J.R. & Craig, so I will now (attempt) to code to match you guys.

Re an address buying coins from its own sell order, it's been agreed there is no use case for this so it doesn't matter one way or the other - it's a question of what's easiest to get consensus - me allowing it or you guys disallowing it. I'm taking a look over my code now.

EDIT: OK, Class B requires that change is returned to sender, so where the sender is an output that output is determined to be change. This transaction https://blockchain.info/tx/a4be2bc89c0b11977ed907605993680ea893ebe316878586f05bd755275f559b has effectively two change outputs and no reference address. As I start to review my code I'm thinking an address buying coins from its own sell will raise problems and solve none. Can you guys disallow this?

Thanks
Zathras

Hi Zathras,

Sorry, but I couldn't join at that time.
Although I think for protocol beauty reasons, there shouldn't be rules against buying from specific addresses ("self address"), I don't mind adding this rule if it takes us in a smoother way closer to consensus. It doesn't have any affect of balance consensus - only on transaction consensus.
I do insist on the option to send coins to one self - as I think it is important (having in mind a 3rd level protocol on top of mastercoin one day - but I think you support send to self anyway).

So bottom line:
If you see that it makes your life much easier, I'll code the change and request mymastercoin to follow.

So... Tired...

Doing a chunk of rewriting and taking far longer than I expected - have added a 'btcpayment' mastercoin transaction type and am rewriting the lib & engine to make each bitcoin payment a separate coin purchase transaction (so changing the logic/architecture to be the same as you & Bitoy)... This will then allow me to process payments in blockchain order regardless of block boundaries.

Will keep you guys updated...

Thanks
Zathras

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: grazcoin on March 14, 2014, 07:04:23 AM

Hi Zathras,

Sorry, but I couldn't join at that time.
Although I think for protocol beauty reasons, there shouldn't be rules against buying from specific addresses ("self address"), I don't mind adding this rule if it takes us in a smoother way closer to consensus. It doesn't have any affect of balance consensus - only on transaction consensus.
I do insist on the option to send coins to one self - as I think it is important (having in mind a 3rd level protocol on top of mastercoin one day - but I think you support send to self anyway).

So bottom line:
If you see that it makes your life much easier, I'll code the change and request mymastercoin to follow.

Send to self works well in bitcoins because it consolidates the coins into one transaction. Which will save space next time you send.

In mastercoin there is no small change coins. But we already allowed sending to ones address so it's ok now.

Please advise the changes to that I can update the codes.

(Ps Busy preparing for vacation will update it soon as I get back

Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 3. (Read 129205 times)