300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 30.

grazcoin

sr. member

Activity: 284

Merit: 250

Quote from: grazcoin on December 15, 2013, 08:48:16 AM

I start with the first consensus conflict.

The second consensus conflict on zathras's list is the address 139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz
This is due to accepting simple send with multiple change addresses.
Did it get already into the spec?
There are 3 such transactions. One of them is:
on blockchain.info:
https://blockchain.info/tx/8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665
on masterchest.info:
https://masterchest.info/lookuptx.aspx?txid=8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665
on masterchain.info - it is an invalid mastercoin tx, so it is parsed as bitcoin payment:
https://masterchain.info/btcpayment.html?tx=8175fcd0221ee5cda1808f48861bef5c2d5e8b9acf91a7b0fade5768d35f6665

If it does get into the spec - are multiple change addresses allowed also in multisig?

grazcoin

sr. member

Activity: 284

Merit: 250

I start with the first consensus conflict on zathras's list, which is the address 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7.
I was digging, and I found the root cause to be the parsing of the following tx:
https://masterchest.info/lookuptx.aspx?txid=725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac
http://mastercoin-explorer.com/transactions/725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac

The sequence numbers in that tx are:
[84, 205, 233]

As far as I understood, we do the peek_and_decode only in the ambiguous sequence and perfect sequence cases, and this case is non of them.

Was there another decision regarding peek_and_decode?

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: zathras on December 15, 2013, 05:37:37 AM

Those addresses where only Mymastercoins had values were a bug (just squashed) - I query all implementations for their list of addresses, it just so happens that Bitoy's is first on the list. There is whitespace in his JSON output so it was throwing off my address matching. A couple of handy trim functions and it's working again.

Re filter, I haven't built in parameters into that page for filters (though I do intend to), in the mean time will this do? https://masterchest.info/consensus_tachikoma.aspx

The link above makes checking much easier.

Sorry for the spaces. Will update the script and also the numbers.

grazcoin

sr. member

Activity: 284

Merit: 250

Quote from: zathras on December 15, 2013, 04:58:54 AM

Consensus checker - automatically compares the various implementations for consensus (addresses for now, transactions to come) - https://masterchest.info/consensus.aspx

That's great!
Now it is easy to see the mistakes Wink

I was just working on wallet side, so the correct parsing got neglected ...

zathras

sr. member

Activity: 266

Merit: 250

Quote from: Tachikoma on December 15, 2013, 05:06:30 AM

Awesome additions! Especially like the consensus check, I still have a half finished product so I'm glad yours is working right now!

I think we need a way to easily discuss these transactions and explain why we parse them a certain way. Although right now it seems Masterchest has a lot of other values compared to the other implementations. Could you see if there is something obvious that can be done to fix those differences?

Could also you perhaps add a filter to hide addresses that match on all implementations?

Those addresses where only Mymastercoins had values were a bug (just squashed) - I query all implementations for their list of addresses, it just so happens that Bitoy's is first on the list. There is whitespace in his JSON output so it was throwing off my address matching. A couple of handy trim functions and it's working again.

Re filter, I haven't built in parameters into that page for filters (though I do intend to), in the mean time will this do? https://masterchest.info/consensus_tachikoma.aspx

Quote from: Bitoy on December 15, 2013, 05:28:07 AM

Nice consensus check.

Starting at address
1RavenHqiZ7euZ1ETKkKP74h5SPLovdF6

Only Mymastercoins column has value on the consensus, but when I checked at the website masterchest and master-explorer have values also for this address.

Yeah see above that was a bug - if it helps I noticed you have some whitespace in your output (eg {"address": "1rdyat8oxM33EUHBaGPvEUBiBgAvXHe5M ", "balance": "0.003"}) and a couple of format issues (eg {"address": "139Dx25QXHBJD1tfLQMwASAAJrWFiM4BPz", "balance": "1E-08"}).

Thanks guys

EDIT: Looks like the link I was using for Grazcoin's implementation was wrong, corrected.

Bitoy

sr. member

Activity: 449

Merit: 250

Nice consensus check.

Starting at address
1RavenHqiZ7euZ1ETKkKP74h5SPLovdF6

Only Mymastercoins column has value on the consensus, but when I checked at the website masterchest and master-explorer have values also for this address.

Tachikoma

hero member

Activity: 938

Merit: 1000

Awesome additions! Especially like the consensus check, I still have a half finished product so I'm glad yours is working right now!

I think we need a way to easily discuss these transactions and explain why we parse them a certain way. Although right now it seems Masterchest has a lot of other values compared to the other implementations. Could you see if there is something obvious that can be done to fix those differences?

Could also you perhaps add a filter to hide addresses that match on all implementations?

zathras

sr. member

Activity: 266

Merit: 250

Hi all,

Latest update to masterchest.info is complete. Rolled a bunch of bugfixes and a couple of features from dev into prod, notables:

Peek & decode support
Clean up (invalidate) leftover real MSC DEx transactions
Multi change output support - alpha
Verification API - addresses only at this stage (https://masterchest.info/mastercoin_verify/addresses.aspx)
Consensus checker - automatically compares the various implementations for consensus (addresses for now, transactions to come) - https://masterchest.info/consensus.aspx

Thanks!

aTriz

hero member

Activity: 1232

Merit: 683

Tontogether | Save Smart & Win Big

Quote from: Bitoy on December 15, 2013, 02:46:29 AM

Quote from: aTriz on December 15, 2013, 02:40:35 AM

1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm - my address everywhere shows 50~ msc but for some reason the windows wallet shows 40~

Click settings
click reparse.

Please pm me a screen shot.

I did that but I found there is a double transaction, I'll PM you the SS now.

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: aTriz on December 15, 2013, 02:40:35 AM

1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm - my address everywhere shows 50~ msc but for some reason the windows wallet shows 40~

Click settings
click reparse.

Please pm me a screen shot.

aTriz

hero member

Activity: 1232

Merit: 683

Tontogether | Save Smart & Win Big

Quote from: Bitoy on December 15, 2013, 02:35:16 AM

Quote from: aTriz on December 15, 2013, 12:37:52 AM

Made my first TMSC Purchase from Bitoy through the windows wallet!

Confirmed on MyMastercoins:
12/15/2013 4:50:24 AM 1 1 .001 .001 .0001 1cdc9e 242 1LjT88 1BKpa1 274997 Payment Confirmed .001 0.00

Confirmed on Mastercoin explorer
http://mastercoin-explorer.com/transactions/1cdc9e996163496d2eda9015a2169804ee75b03b599bf172c514269b614f93e0

It isn't showing up on masterchest though, maybe give it some time?

Also what is kinda weird is my MSC balance is missing approx 10 coins from my balance, any ideas why that may be?

Thank you for testing the wallet. Congrats

. What address is missing 10 msc?

Edit
You can post the 1 tsmc you bought. I'll buy it back from you

1LjT88X7Zu8BdbqJw8vfRa83NJuzYL9kqm - my address everywhere shows 50~ msc but for some reason the windows wallet shows 40~

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: aTriz on December 15, 2013, 12:37:52 AM

Made my first TMSC Purchase from Bitoy through the windows wallet!

Confirmed on MyMastercoins:
12/15/2013 4:50:24 AM 1 1 .001 .001 .0001 1cdc9e 242 1LjT88 1BKpa1 274997 Payment Confirmed .001 0.00

Confirmed on Mastercoin explorer
http://mastercoin-explorer.com/transactions/1cdc9e996163496d2eda9015a2169804ee75b03b599bf172c514269b614f93e0

It isn't showing up on masterchest though, maybe give it some time?

Also what is kinda weird is my MSC balance is missing approx 10 coins from my balance, any ideas why that may be?

Thank you for testing the wallet. Congrats

. What address is missing 10 msc?

Edit
You can post the 1 tsmc you bought. I'll buy it back from you

aTriz

hero member

Activity: 1232

Merit: 683

Tontogether | Save Smart & Win Big

Made the first TMSC Purchase from Bitoy through the windows wallet! Glad to be a part of it!

Confirmed on MyMastercoins:
12/15/2013 4:50:24 AM 1 1 .001 .001 .0001 1cdc9e 242 1LjT88 1BKpa1 274997 Payment Confirmed .001 0.00

Confirmed on Mastercoin explorer
http://mastercoin-explorer.com/transactions/1cdc9e996163496d2eda9015a2169804ee75b03b599bf172c514269b614f93e0

It isn't showing up on masterchest though, maybe give it some time?

Also what is kinda weird is my MSC balance is missing approx 10 coins from my balance, any ideas why that may be?

Bitoy

sr. member

Activity: 449

Merit: 250

This transaction is valid in mymastercoins and master-explorer. But is not in masterchest.
725210a6bfea06e4aa9a582602d758db920eff9c720aca380d6e77c08a4108ac

Simple Send
Date:   12/2/2013 6:51:40 PM
Sender:   18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF
Amount Sent:   50.00000000 MSC
Recipient:   1NK1rJSkMeDtg5SXfXaSbD14QxAqQbqAr6

Balance of 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF is 187

Then 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF tried to send 250 msc (6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3)
It became invalid because address has only 187 msc.

Quote from: DGulari on December 14, 2013, 07:54:57 PM

Quote from: Bitoy on December 14, 2013, 06:51:42 PM

In mymastercoins Address 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 has 0 msc because .

6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3

Invalid Transaction.
Date:   12/3/2013 1:12:15 PM
Remarks:   Seller 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF doesn't have enough MSC to send.

Quote from: ?? on ??

I am not sure this is correct Bitoy. What about this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 ?

The way I see it is:
For this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 we have:
Masterchest = 237
Explorer = 0
MyMaster = No Transactions

Can you please confirm?

Yep - this is due to the fact that this transaction is valid in Masterchest - but not valid in Mastercoin Explorer
6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3

-so which is correct?

DGulari

legendary

Activity: 1386

Merit: 1000

KawBet.com - Anonymous Bitcoin Casino & Sportsbook

Quote from: Bitoy on December 14, 2013, 06:51:42 PM

In mymastercoins Address 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 has 0 msc because .

6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3

Invalid Transaction.
Date:   12/3/2013 1:12:15 PM
Remarks:   Seller 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF doesn't have enough MSC to send.

Quote from: ?? on ??

I am not sure this is correct Bitoy. What about this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 ?

The way I see it is:
For this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 we have:
Masterchest = 237
Explorer = 0
MyMaster = No Transactions

Can you please confirm?

Yep - this is due to the fact that this transaction is valid in Masterchest - but not valid in Mastercoin Explorer
6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3

-so which is correct?

Bitoy

sr. member

Activity: 449

Merit: 250

In mymastercoins Address 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 has 0 msc because .

6a808bd80ec8d582dff1ed841c62bb0b9f50a14a907404003ebf39bf75e3c9b3

Invalid Transaction.
Date:   12/3/2013 1:12:15 PM
Remarks:   Seller 18jArgoK7EPRaozSN6Eprtnjb1LMQQ3McF doesn't have enough MSC to send.

Quote from: ?? on ??

I am not sure this is correct Bitoy. What about this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 ?

The way I see it is:
For this address: 12BjxEGAGcLnpXVbJHp4L5FNKh1YNweRn7 we have:
Masterchest = 237
Explorer = 0
MyMaster = No Transactions

Can you please confirm?

aTriz

hero member

Activity: 1232

Merit: 683

Tontogether | Save Smart & Win Big

Quote from: Bitoy on December 14, 2013, 06:32:53 PM

Quote from: DGulari on December 14, 2013, 11:44:55 AM

Quote from: Bitoy on December 14, 2013, 09:27:53 AM

I've also released a windows wallet. Mymastercoins wallet v 1.01

https://github.com/Bitoy88/MyMastercoinsWalletBeta/package

Please try it.

I think your link is busted.

Sorry, correct link is

https://github.com/Bitoy88/MyMastercoinsWalletBeta

It's in the folder "package"

Beautiful Job, just now getting the wallet open and synced! Though my balance shows 10 less than I should, is that normal? I pm'ed you with the error i'm getting.

Also when trying to post a TSMC sell or buy it is saying Insufficient Funds for fee at the address.

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: DGulari on December 14, 2013, 11:44:55 AM

Quote from: Bitoy on December 14, 2013, 09:27:53 AM

I've also released a windows wallet. Mymastercoins wallet v 1.01

https://github.com/Bitoy88/MyMastercoinsWalletBeta/package

Please try it.

I think your link is busted.

Sorry, correct link is

https://github.com/Bitoy88/MyMastercoinsWalletBeta

It's in the folder "package"

zathras

sr. member

Activity: 266

Merit: 250

Hi all,

Quick note to say the masterchest.info engine will be offline for a short while this afternoon while I push out the latest update. (Site will stay up but new transactions may be delayed)

Thanks!

DGulari

legendary

Activity: 1386

Merit: 1000

KawBet.com - Anonymous Bitcoin Casino & Sportsbook

Quote from: bitcoinrocks on December 14, 2013, 12:16:57 PM

Is there any way to invest in MasterCoin like with other coins?

For sure. Buy some while the prices are still insanely low. In 18 months after this thing is running hot - you'll be rich (sell high). Go here: https://docs.google.com/spreadsheet/ccc?key=0ApGPLGUd5ZCzdHFxbnhHQjBDSDVKamY5UHlWdkNMNWc&usp=sharing#gid=0

Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 30. (Read 129207 times)