[ANN] ms-brainwallet.org - Multisignature P2SH in the browser

Sarchar

member

Activity: 88

Merit: 10

Thanks. I look forward to the feedback.

Quote from: abstream on December 09, 2014, 08:30:58 PM

Hey,

you have done something great! I will have a look at the code within the next 10-12 days and get back to you with some feedback!

cheers.

Quote from: Sarchar on September 08, 2014, 01:00:00 AM

Small update - I've added a few new features.

Allow any m-of-n (not just m-of-3) transactions
Support for partially signing transactions
Support for adding signatures to raw transactions

With the above, ms-brainwallet should work well for doing things like escrow and without to share private keys or have all the private keys in one place.

Hope people find it useful!

abstream

member

Activity: 81

Merit: 10

Hey,

you have done something great! I will have a look at the code within the next 10-12 days and get back to you with some feedback!

cheers.

Quote from: Sarchar on September 08, 2014, 01:00:00 AM

Small update - I've added a few new features.

Allow any m-of-n (not just m-of-3) transactions
Support for partially signing transactions
Support for adding signatures to raw transactions

With the above, ms-brainwallet should work well for doing things like escrow and without to share private keys or have all the private keys in one place.

Hope people find it useful!

Sarchar

member

Activity: 88

Merit: 10

Small update - I've added a few new features.

Allow any m-of-n (not just m-of-3) transactions
Support for partially signing transactions
Support for adding signatures to raw transactions

With the above, ms-brainwallet should work well for doing things like escrow and without to share private keys or have all the private keys in one place.

Hope people find it useful!

Sarchar

member

Activity: 88

Merit: 10

Quote from: chriswilmer on March 19, 2014, 01:23:44 AM

This is awesome!!

Are you still maintaining this? (i.e., should I be donating to you Wink

)

Yes, although I haven't written new code for the site in a while, I still consider myself responsible for its operation.

If you want to contribute, write some code

chriswilmer

legendary

Activity: 1008

Merit: 1000

This is awesome!!

Are you still maintaining this? (i.e., should I be donating to you Wink

)

Sarchar

member

Activity: 88

Merit: 10

I configured a domain name for this project: http://ms-brainwallet.org/

Sarchar

member

Activity: 88

Merit: 10

Quote from: CharlesSafety on December 19, 2013, 04:34:39 PM

Quote from: Sarchar on December 19, 2013, 03:38:04 AM

Quote from: CharlesSafety on December 17, 2013, 07:57:45 PM

I love your work it is brilliant. Exactly something I was looking to play with.

So this is different than the sx implementation of multi signature brain wallets, they don't seem to be compatible.

Well, thank you! I'm working on a few new improvements that I think are really cool.

Speaking of sx, do you know in which way the multisignature transactions are incompatible? I'll check it out myself later, as well.

I am a bit of a novice just tinkering, I made an sx multi Sig brainwallet 'password1' 2 and 3, and it comes up with a different address than when I put the same passphrases in your tool.

As a side note, it appears that multi Sig brain wallets are not being brute forced, as nobody has stolen the small amount I sent to that address.

Your tool is much easier to work with than the sx tool (which is why that value is still stuck in the above mentioned brainwallet)

How are you generating the public keys for those passwords? Typically I would use the standard brainwallet.org site and copy the public key into my site. sx may use a different hashing method than the default brainwallet site, too.

Also, did you check all 6 orderings?

CharlesSafety

newbie

Activity: 5

Merit: 0

Quote from: Sarchar on December 19, 2013, 03:38:04 AM

Quote from: CharlesSafety on December 17, 2013, 07:57:45 PM

I love your work it is brilliant. Exactly something I was looking to play with.

So this is different than the sx implementation of multi signature brain wallets, they don't seem to be compatible.

Well, thank you! I'm working on a few new improvements that I think are really cool.

Speaking of sx, do you know in which way the multisignature transactions are incompatible? I'll check it out myself later, as well.

I am a bit of a novice just tinkering, I made an sx multi Sig brainwallet 'password1' 2 and 3, and it comes up with a different address than when I put the same passphrases in your tool.

As a side note, it appears that multi Sig brain wallets are not being brute forced, as nobody has stolen the small amount I sent to that address.

Your tool is much easier to work with than the sx tool (which is why that value is still stuck in the above mentioned brainwallet)

Sarchar

member

Activity: 88

Merit: 10

Quote from: CharlesSafety on December 17, 2013, 07:57:45 PM

I love your work it is brilliant. Exactly something I was looking to play with.

So this is different than the sx implementation of multi signature brain wallets, they don't seem to be compatible.

Well, thank you! I'm working on a few new improvements that I think are really cool.

Speaking of sx, do you know in which way the multisignature transactions are incompatible? I'll check it out myself later, as well.

CharlesSafety

newbie

Activity: 5

Merit: 0

I love your work it is brilliant. Exactly something I was looking to play with.

So this is different than the sx implementation of multi signature brain wallets, they don't seem to be compatible.

virtualmaster

hero member

Activity: 504

Merit: 500

Good work. Thanks.

Sarchar

member

Activity: 88

Merit: 10

Quote from: xeroc on December 16, 2013, 03:23:14 AM

This is a great project ..

(also bitgo.com)

I checked out bitgo - their Bitcoin Gift protocol is actually this exact thing, indeed. They don't use BIP32, but that's fine. My BIP32 stuff is still experimental. Good on Bitgo! Nice to see more multisignature stuff around.

xeroc

sr. member

Activity: 345

Merit: 250

This is a great project ..

(also bitgo.com)

Sarchar

member

Activity: 88

Merit: 10

Code Review Bounty - 2 slots at 0.25 BTC each.

I need someone to review my bip32 code. It's in JavaScript and freely accessible.

This is the pull request I made to brainwallet that includes bip32 master key generation:

https://github.com/brainwallet/brainwallet.github.com/pull/35

It looks like the brainwallet guy is going to take his time in processing this, so in the meantime I'd really like it if someone could review the changeset and post feedback. In particular, I'm looking for people with good community standing (you're a well-known and respected programmer on the forums) and that your response is actually meaningful. I want to have some respected people here give a thumbs up or thumbs down on the security and correctness of this bip32 javascript implementation.

Any takers?

Sarchar

member

Activity: 88

Merit: 10

I have considered Shamir's secret sharing and while I think it'd be complementary to this brain wallet strategy, I think it's better implemented in a separate project. It seems like using secret sharing for your brain passphrase (key2 in the OP) could yield added security.

Natanael

newbie

Activity: 27

Merit: 0

You should add Shamir's Secure Sharing Scheme support for additional security AND loss/destruction prevention.

Sarchar

member

Activity: 88

Merit: 10

Just a quick update:

This codebase now supports BIP32 keys (3 at a time!) and also correctly sorts public keys in the redemption script before using them. You can also now enter private keys in any order and they'll be signed correctly.

If anyone ends up using this, I'd be happy to hear how it works out for your - but definitely only test with small amounts, as this is still alpha!

Sarchar

member

Activity: 88

Merit: 10

I decided that in order to get people to test the idea out it would be convenient if I just implemented it in JavaScript. So tonight, I've added the ability to generate and spend P2SH multisgs using the Brainwallet.org codebase as a starting point.

The implementation is here, but be warned: it hasn't been tested thoroughly!

I'd love to hear some feedback.

Sarchar

member

Activity: 88

Merit: 10

Quote from: mbelshe on November 07, 2013, 06:07:59 PM

Hey Sarchar -

I think you and I have been thinking the same thing :-)

I have an online version of this implemented at bitgo. https://bitgo.com. It probably doesn't offer all the combinations of key creation that you're looking for yet, but send me an email ([email protected]) and I'll send you an invite. Would love to get more feedback.

mike

Cool, I'm glad someone else has been thinking about this. I actually have developed two scripts (a create and a spend) in Python that will produce the proper transactions to accomplish this. I could publish them if anyone's interested.

What kind key combinations does your implementation allow? Does it work offline?

mbelshe

newbie

Activity: 36

Merit: 0

Hey Sarchar -

I think you and I have been thinking the same thing :-)

I have an online version of this implemented at bitgo. https://bitgo.com. It probably doesn't offer all the combinations of key creation that you're looking for yet, but send me an email ([email protected]) and I'll send you an invite. Would love to get more feedback.

mike

Topic: [ANN] ms-brainwallet.org - Multisignature P2SH in the browser (Read 4639 times)