Pages:
Author

Topic: [ANN][YAC] Coin Control for YaCoin is here! First altcoin with Coin Control! - page 2. (Read 5754 times)

newbie
Activity: 8
Merit: 0
GOOD JOB .THANKS
Donations for you!~ Grin
member
Activity: 81
Merit: 10
Well it took way too long and it's way too late in the night for me to be sitting here on my computer, but I finally got the d&^m wallet to compile and run on Windows....what a pain in the a$$.  I guess the good news is it should be less painful next time around, since you learn from your mistakes (and I learned a lot).  Roll Eyes
member
Activity: 81
Merit: 10
Quote

Hello Sairon,

I'm having some trouble compiling this for Windows (using the instructions from Nitrogentics). Could you help me out by telling me what the minor variations are?

BTW, it's not that I don't trust you.  In fact I've already downloaded your windows binary build and I'm trying it out now. I just want to figure out how and be able to compile it myself.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Now we have proper YAC icons in the Qt client. Dropbox zip updated, md5 & sha1 sums changed.
Thanks to alenevaa (be sure to send him some YACs!)
https://bitcointalksearch.org/topic/m.3000017
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Just a note: I've reset my github repo (been using it as a scratchbox while fixing the CC features), so it now has a single huge commit with all the features and fixes. Sorry for any inconveniece.
Also, openend a pull request to WindMaster's repo.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
I downloaded the wallet, but I keep getting the following error message when I try to open it.

Code:
The program can't start because mingwm10.dll is missing from your computer.  Try reinstalling the program to fix this problem.

Any ideas on how I might be able to fix this?  I'm running Windows 7 Unlimited OEM (64-bit).
I solved this by downloading mingwm10.dll and coping it into the same folder as yacoin-qt.exe, but AFIK this is just a very crude fix.

Ahh, sorry, forgot to include that one. -.-"
EDIT: it's now in the updated yacoin-cc.zip from OP.
sr. member
Activity: 280
Merit: 250
I downloaded the wallet, but I keep getting the following error message when I try to open it.

Code:
The program can't start because mingwm10.dll is missing from your computer.  Try reinstalling the program to fix this problem.

Any ideas on how I might be able to fix this?  I'm running Windows 7 Unlimited OEM (64-bit).
I solved this by downloading mingwm10.dll and coping it into the same folder as yacoin-qt.exe, but AFIK this is just a very crude fix.
legendary
Activity: 1918
Merit: 1012
★Nitrogensports.eu★
I downloaded the wallet, but I keep getting the following error message when I try to open it.

Code:
The program can't start because mingwm10.dll is missing from your computer.  Try reinstalling the program to fix this problem.

Any ideas on how I might be able to fix this?  I'm running Windows 7 Unlimited OEM (64-bit).
sr. member
Activity: 280
Merit: 250
Maybe it is a little un-intuitive, however, it is how it should be and it becomes apparent when you understand the underlying concepts (that's why this feature is for "experts only").
A little?  Roll Eyes

I really like the way you handle the transactions, but the UI is terrible. List mode is IMO useless and shows wrong adresses, tree mode is crying aloud for spamming the forum with stupid questions and the fact that you have to explain it to someone that already knows about change adresses makes it rather "Developers only" than Experts.

CC isn't rocket science and could replace the current system even for the novice. That would be a cool feature that really sets YAC apart from all other cryptos.

My ideas:
remove list mode and expand the tree mode
make it standard to use
show all adresses

I know this is more work than you thought, but I belive CC should be part of the client and not just an addon.



EDIT: My previous post was never about the way you handle transactions. It was about the way you handle the user. You expect him to know about CC in detail but he shouldn't see change adresses. Then confuse him with tree vs list and why an adress could have 2 balances.
EDIT2: If you don't want to show change adresses you could add a "no change, return to origin" option. This would also be useful for paperwallets.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Those change addresses are also hidden in vanilla yacoin-qt, so it's working as intended.
That's kinda like CC light ...

This might be acceptable (I don't like it) on vanilla, but not on "Expert" Mode. Once people see this they will check their balances on yacexplorer and freak out. This is so damm non intuitive and has to change!
I'd rather have no CC than hundred stupid threats about it.

But CC was designed to be EXACTLY like it is... Grouping addresses by taint makes perfect sense and you can still see all your change addresses by expanding the address tree in CC. This makes it apparent which change address belongs to which "main" address, so you don't accidentaly blow up your anonymity or whatever.


Here, address Temp1 owns 22 YAC and also has s change address as its child with a few cents (they both share the same taint, thus you see them as one sub-account of your wallet). If you decide to send all the balance to another address, you'll only reveal which output of the previous tx was your change, and not which other addresses you own.


And now that Temp1 is empty, you still have a tainted change associated with it.

Maybe it is a little un-intuitive, however, it is how it should be and it becomes apparent when you understand the underlying concepts (that's why this feature is for "experts only").
sr. member
Activity: 280
Merit: 250
Those change addresses are also hidden in vanilla yacoin-qt, so it's working as intended.
That's kinda like CC light ...

This might be acceptable (I don't like it) on vanilla, but not on "Expert" Mode. Once people see this they will check their balances on yacexplorer and freak out. This is so damm non intuitive and has to change!
I'd rather have no CC than hundred stupid threats about it.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
I found another issue:

I was sending some Spare change arround* and somehow the balance of an adress was bigger than on yacexplorer.tk. So I tried to send these bonuscoins to another adress and to my surprise it got accepted by the network. Just bevor I wanted to abuse this with a bigg... ehm honestly report the bug I noticed that I had the privatkeys to the donator adress although it wasn't listed.

In short:
The CC should also list hidden adresses since it uses them sometimes or better there shouldn't be any hidden adresses in the client at all.

Code:
http://yacexplorer.tk/tx/f29e758b955348cf0ef1c4524e15d8e20719cc5c2d3f744c4da9f8b3b598e10b#i0
http://yacexplorer.tk/tx/e89e336e92da2c1caca900d6d868fd498e289c64e425ef744b570fbf28878399#i0
You might be familiar with one of the adresses in the first transaction

Y9fu3iEgLsEbf8mXK6Yn4ERzc2qFny53Hm was just one of your change addresses, you can see the TX that sent those 3.99 YAC as change here: http://yacexplorer.tk/tx/1d741a0eea03a5702e55a76f298c452a2191db36865f5a58fe6e31772cc70c2a. Those change addresses are also hidden in vanilla yacoin-qt, so it's working as intended. Thanks for the 1 YAC, btw. Cheesy

If you wanna see these change addresses, just switch to the same view as Megastore used in his post: https://bitcointalksearch.org/topic/annyac-coin-control-for-yacoin-is-here-first-altcoin-with-coin-control-276948
hero member
Activity: 1426
Merit: 506
Wow, this is exactly what I wanted! I'm trying as soon as I'm home
sr. member
Activity: 280
Merit: 250
I found another issue:

I was sending some Spare change arround* and somehow the balance of an adress was bigger than on yacexplorer.tk. So I tried to send these bonuscoins to another adress and to my surprise it got accepted by the network. Just bevor I wanted to abuse this with a bigg... ehm honestly report the bug I noticed that I had the privatkeys to the donator adress although it wasn't listed.

In short:
The CC should also list hidden adresses since it uses them sometimes or better there shouldn't be any hidden adresses in the client at all.

Code:
http://yacexplorer.tk/tx/f29e758b955348cf0ef1c4524e15d8e20719cc5c2d3f744c4da9f8b3b598e10b#i0
http://yacexplorer.tk/tx/e89e336e92da2c1caca900d6d868fd498e289c64e425ef744b570fbf28878399#i0
You might be familiar with one of the adresses in the first transaction

EDIT: I knew about change adresses but thought I had used a different adress to fund it.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
What's the thought behind making it a child of another address?  I'm not trying to max my experience like Mr. Store, but if it's not obvious that that's how it is supposed to work, there will be questions.

For my purposes, so far it's working just fine.  I make sure I only spend new coins and when a change address goes over 10 coins, I make a new one and don't spend those coins...

Well, the original thought was that the change returns to the address the payment came from. However, this raised some anonymity concerns ('cause everyone knew exactly which output went out of your wallet and which one was change returned to you). So this was implemented like this: the outputs are in random order and a new change address is created each time your inputs are bigger than amount paid + fees. This maximizes anonymity (no one knows for sure which output was a payment for some shady goods or whatever, so no one can guess what you paid for). So instead of returning to the sending address, you create a change address as a child of sending address and they're effectively tied together as far as the blockchain goes (this is called taint). So after this transaction, 3 addresses are tainted - two of which are yours. Also, the original client won't show you change addresses (AFAIK) and adds change address balances to the sending address' balance.
hero member
Activity: 693
Merit: 500
What's the thought behind making it a child of another address?  I'm not trying to max my experience like Mr. Store, but if it's not obvious that that's how it is supposed to work, there will be questions.

For my purposes, so far it's working just fine.  I make sure I only spend new coins and when a change address goes over 10 coins, I make a new one and don't spend those coins...
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Fixed windows binary up, link in the OP.

1. Wallet frozen after first attempt to send without specifying change address, on WinXP SP3 32 bit. No crash-specific info in debug.log file.

2. After wallet restart and subsequent send, coins were sent but something went wrong with display. In tree view, newly created change
address is shown as child of coins originating address:



http://yacexplorer.tk/tx/a0fdd1fba2b4f7283971c0794853a178b9c870d2435a158257c6192c2b64ea01

Wallet restart did not fix the issue. Sending some coins from change address elsewhere did not fix the issue neither. Sending all coins from
change address elsewhere removed change address from CC list and afterwards all worked fine, e.g. sending some coins back to change
address does not puts it under "Temp 1" anymore. Not sure if 1. and 2. are related since I can't reproduce wallet freezing but case 2. is
reproducable, e.g. it happens on every new change address creation.

3. With all coins on "Temp 1", sending some coins to "Temp 2" and not specifying change address creates new change address but puts it
as child of "Temp 1" again:



Both "Temp 1" and "Temp 2" are addresses I created much earlier and already used.

1. Good it's non-reproducible. Smiley
2. That's working as intended.
3. Also working as intended.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Fixed windows binary up, link in the OP.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
Because of 520 confirmations required to start spending PoS coins and CC ability to pick any input, YACoin CC runs into weird situation if user
attempts to spend those coins earlier. Here is what happens:

1. PoS block is generated.
2. Just few confirmations later user attempts to spend PoS coins by selecting them with CC.
3. Upon sending, YACoin will complain about attempting to send already used coins (message should add unconfirmed PoS as possible cause).
4. Transaction will be rejected but still shown on Transactions tab, with 0 confirmations.
5. Once PoS block is confirmed, transaction will be broadcasted to network. This step might require wallet restart, not sure about it since I had
to close my wallet before 520 confirmations and ran it much later, when PoS block was confirmed like 700+ times.

Fixed this by graying-out (checkbox can't be ticked) and setting a red background of immature PoS coins in the Coin Control view.
sr. member
Activity: 406
Merit: 250
One does not simply mine Bitcoins
IMPORTANT!
Stop using the published versions of Yacoin with Coin Control - there's a critical bug when NOT selecting a custom change address (the new change address is not reserved from keypool and thus your coins disappear forever). Fixed in recent git commit, updated binaries coming soon.

If I just don't send anything, or set the change address though, I'll be fine until the binaries are updated, correct? 

That's right.
Pages:
Jump to: