Dumb github question, but is there as easy way to apply a pull request to a local clone of the git repo? I can't even figure out how to download a pull request as a unified diff, let alone how to pull it properly with git.
The github help tells me to browse to the pull request and click "command line" but I don't see such a link.
EDIT: And many thanks to bitsolutions for doing (and sharing) the necessary work - and of course to Alan and goatpig and all at ATI for their continuing work on Armory!
EDIT^2: I'm also being dumb as there's no way (I think) to download the actual pull request that goatpig reviewed, since pull requests are mutable (for obvious reasons). The change is small enough it's easy enough to review, though, so if you posted a diff that would be just as good. I'm still curious as to the answer to my question, though.
EDIT^3: nm, I found a (good enough) answer that at least allows me to download the diff: browse to the pull request and then edit the URL to add ".patch" or ".diff" to the end of the URL Ugh! Did I tell you I hate github? EDIT^4: But .patch and .diff give different results though (I don't think they're substantively different but am failing to see why both exist). BTW, did I tell you I hate github?
Topic: Armory 0.93.3 with BIP62 compliance - page 4. (Read 8910 times)
I've reviewed the code. Looks kosher (I'm no OSX specialist). I'll drop a word to etotheipi. I won't merge it in myself, because chain of command.
With respect for chain of command, it's been quite a few days now.... Mac users everywhere would be very much appreciated if there was at least one last officially compiled binary update to take care of the high/low-S patch
...Please consider elevating the priority of this request...
Since this seems to be taking a while I'm going to post my OSX build here before someone tries to release something with a backdoor.
Download armory_0.93.3_osx.tar.gz
MD5: a086fb85547eecc0369d9d2f2fd67b6c
SHA1: ef3f6692b8eaa2132d678592de729850a7e39c4d
SHA256: f227d7d54971ba2747dce4a0722774d48f905c7eba74c74bc7a3bff5726b09e7
Download armory_0.93.3_osx.tar.gz
MD5: a086fb85547eecc0369d9d2f2fd67b6c
SHA1: ef3f6692b8eaa2132d678592de729850a7e39c4d
SHA256: f227d7d54971ba2747dce4a0722774d48f905c7eba74c74bc7a3bff5726b09e7
No offence if you're a dev, but how can we be sure you didn't just post a malcious file?
Can someone run something?
If it's clean, which it probably is, thank you.
Since this seems to be taking a while I'm going to post my OSX build here before someone tries to release something with a backdoor.
Edit: Download removed since there is an official release.
Edit: Download removed since there is an official release.
It would be nice to see this version appear on the Armory home page, since it is a very important compatibility fix.
I've reviewed the code. Looks kosher (I'm no OSX specialist). I'll drop a word to etotheipi. I won't merge it in myself, because chain of command.
A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.
As I mentioned earlier in this thread I've already done that, it is #315.My apologies, I do that sort of thing sometimes. I'll try to keep the noise down
A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.
As I mentioned earlier in this thread I've already done that, it is #315. First off, thanks for all your work, past and hopefully future, on this wonderful project.
Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
Yeah, I think they should try and do that soon before someone else releases a potentially backdoored binary. If you happen to trust me I can PM you the one I built but it's bad practice to trust binary files from random people on the internet.Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
A pull request with the changes needed to get the build working could be submitted to the Armory github. It can only be rejected, so not much to lose in trying.
First off, thanks for all your work, past and hopefully future, on this wonderful project.
Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
Yeah, I think they should try and do that soon before someone else releases a potentially backdoored binary. If you happen to trust me I can PM you the one I built but it's bad practice to trust binary files from random people on the internet. Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
First off, thanks for all your work, past and hopefully future, on this wonderful project.
Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
Humbly, may I request on behalf of mac users everywhere: If the steps are relatively simple to build the binaries as the other posters have mentioned, and correctly include the low/high-S patches, can we get one of the armory devs to please sign a pre-built app & place it in the secure uploader so cold storage will still be accessible to a mac online armory version?
...otherwise it requires lot of jumping through VM hoops.
Thanks!
Thanks, I'll try. A few questions:
Not sure why they didn't just do it, best guess is they were too busy or didn't have a mac available, it took me a few hours to get working but most of that was just getting familiar with the build system, the changes they made didn't really touch the build system as far as I could tell but they hadn't updated Qt in a while so some links/paths were broken.- If it's so easy to make the OS X build, why didn't they just do it?
- Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
- Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?
Seems to work fine with Bitcoin Core 0.11.1.
Armory 0.93.2 fails to broadcast transactions with Bitcoin Core 0.11.1.
As always, thanks for the updated version!
As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.
Thank you for the clarification.
As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
- If it's so easy to make the OS X build, why didn't they just do it?
- Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
- Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?
From the OP, I can just guess that they cannot provide Armory on OSX with the same quality standards that they provide on Windows and Linux.
As for 0.93.2 + Core 0.11.1, I don't see why would there be any issue.
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
- If it's so easy to make the OS X build, why didn't they just do it?
- Have you tested your OS X compiled Armory 0.93.3 with Bitcoin Core 0.11.1? Is everything working? Are transactions getting broadcast, and so on?
- Let's say I upgrade to Bitcoin Core 0.11.1 and run it, and then run the older Armory 0.93.2. Will anything break? Or will Armory tell me something is wrong right away? Or will Armory just fail to broadcast transactions? What exactly could go wrong?
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
No more support for Mac/OSX:
Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Are there any changes that would prevent me from compiling it myself for Mac/OSX?Due to the high resource consumption of maintaining the Mac builds and lack of continued support from the Qt team for Qt4/PyQt4, we have no choice but to pull OSX support until we can upgrade Armory to Python3 and Qt5.
Edit: Got it working and pull requested fixes for Qt. PM me if you want the binary I compiled.
Jump to: