Im a little late, but my understanding is that if we request too many coins from the budget,
the budget will only pay out the proposals with the most yes votes (pays out in descending order of yes votes),
is that correct?
the budget will only pay out the proposals with the most yes votes (pays out in descending order of yes votes),
is that correct?
If we request too many, the budget will not be converted and approved as a superblock (the chain will fail with Superblock amount too big). We need to be careful to not insert too many proposals into the next budget next time.
We basically voted in an invalid budget.
bin/watchman.py
Line 94: proposals = Proposal.approved_and_ranked(...)
Line 98: sb = dashlib.create_superblock(proposals, event_block_height, budget_max, sb_epoch_time)
https://github.com/biblepay/watchman/blob/c6f4cdc831b45019b1f7b3b6ce99100b5fa7086f/bin/watchman.py#L94
lib/models.py
approved_and_ranked() "return all approved proposals, in order of descending vote count"
https://github.com/biblepay/watchman/blob/e944d85fe5edc89d0ad4459c2428127cbc3b4d16/lib/models.py#L338
lib/biblepaylib.py
create_superblock()
Line 105: if (budget_allocated + proposal.payment_amount) > budget_max: "# skip proposals that are too expensive..."
https://github.com/biblepay/watchman/blob/c6f4cdc831b45019b1f7b3b6ce99100b5fa7086f/lib/biblepaylib.py#L89
So to me it looks like watchman, sorts the proposals before sending them to create in the superblock
and in the superblock creation the proposals get added up 1 by 1 unless they go over the budget limit at which point they get skipped
What was the error that you saw exactly Rob? Im interested to dig into this
If the above is correct, then it should have theoretically skipped the passing proposals that went over budget with the least amount of votes,
specifically the PR Communications Marketing proposal I think, I believe it had the least amount of votes
