Topic: Bitcoin OMG! including Watch-Only - page 3. (Read 23559 times)

As a LTC dev shouldn't you have to create this for LTC first?

Yep, the binaries are all right.
I've also done OMG2: https://github.com/piotrnar/gitian.sigs.omg/tree/master/

Sorry again for messing up.

https://github.com/bitcoin/bitcoin/blob/master/src/qt/macdockiconhandler.mm

This is the code that needs to be merged into your client, this would allow for a menu when right clicking on the dock icon and choose to hide/show the gui window and has worked really well. Sorry I can't be more help then just pointing out this.

Now I see what I did wrong.
I did not set the VERSION var properly (0.8.5 instead of 0.8.5-OMG1) and fetched wrong sources.

Shouldn't be doing it so late and announcing such a message just before going to sleep - my apologies.

I'm redoing it right now.

Watch Only introduced some kind of coin selection issue.  It was removed for now until I can figure it out.  The remaining patches are very close to what has been shipping in Litecoin since mid-September.

Do you know if BItcoin master currently has this issue for Mac?  I am unable to test Mac.

If we reintroduced this problem by pulling a 0.9 patch, it's possible master has this issue now, or they subsequently fixed it with another patch.

I make no guarantees about anything.  Identical build results from Gitian suggests that I didn't add anything secretly to this build.  It could also mean it is possible that all builds are equally compromised.  If that's true, then the standard Bitcoin gitian builds are also compromised.

If you get different results than these builds then there is something different about your build environment.  Are you using Gitian kvm or lxc?

It's fine that you are using gitian, but did you check the link I pasted (most likely the part two of that) ? Tor uses gitian too, but that link points out that gitian does not actually guarantee deterministic builds, and two people getting the same binary is not a counter-argument for that. It might be that this package is not affected by the issues pointed there, no matter the platform, but I don't know that.

One of the issues pointed in that link: On Windows builds, something mysterious causes 3 bytes to randomly vary in the binary.

Can you guarantee that this is not the case for this package ?

https://github.com/litecoin-project/gitian.sigs.omg
Two people independently built identical binaries.  It is deterministic.

I wouldn't say the build environment is acting wrongly, isn't this just due to the builds not being deterministic ?

If anyone is wondering what I'm talking about, please check https://blog.torproject.org/blog/deterministic-builds-part-one-cyberwar-and-global-compromise or others related.

I can verify that it does as have the same issue.

I rebuilt all deps from scratch and the resulting .exe's came out identical to my previous gitian sigs.  I'm asking others to join gitian build tests to figure out what is going on here.

Update: pooler's gitian sigs were identical to me.  There might be something wrong with your build environment.  Do you get equal sigs for standard Bitcoin giitan sigs?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

0a95da7567d8a9dabeadffe5b74e4813072e4a2c6fc02c130bb383e949c78d22  bitcoin-0.8.5-win32-setup.exe
7b06dc9534b1e12849780be0481c629a8cc9d925ca8849dadc4d593a5d9e4f6f  bitcoin-qt.exe
dfeac5941ea70141d447c1d79c84d8c74c84126c6df49f2b08c6bff34c07a7b6  daemon/bitcoind.exe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQQcBAEBCAAGBQJScDKYAAoJELEXnrc0fcENPF0gAJjvM3LZHSRGKu8iMwKiDYzo
m1/YjN7jtSIwyjhw+ChFAEji07OELTd+zlvVfLTbsm1hHz5e5uu78FyWVTg2AD+7
Xe9pk0viwier3bwI1NM4283MQNZKNjetmR3GPS0BSBYJ1B3A5o2tlbvG7R4vHYXB
IzAlVRsi28AkKTS509lK7G/rnakvptQBbOiGme+jBF0otw+cV48AGzVXEPithe57
HclneNoL6smKyP89GPxTnJZpQ/Yb1YFSIwYoOArZ81TAp8UwFu8BJUQTubqYN2G1
//N6usByKqCgkz9UDSkqlg0KlxF+tvESOmT2jz6Ysgg+Ig/gllN1/zesMdQP5XfW
+fueRwkBHNvsN8ayFj77QTgyVseTDZmGhdlFCykNDV7ChHe7IUJKFEQHLHOAg+aI
4Wuy9K9TA4CNtW3Q8eQaEnKCzKB8GIxamwsIw0ZeLDpTs11YShknj8oO1CqulhgS
9W+Eb+vJeGDpMsB5tk/pwQrDmg54/ivSKCRcOS2Da+E50gWvHWIDqHEcEk7UeWlg
WuPRL/Q/oQ0qHusqzV8Iw6BckobYUlglcz3pYdYIWxri36fG6DwXgYhbmZdgxpRY
HzcAttr99VVGRjq4yRRWDW7L4vnCarP5Zw8CpmPl3TzQbqYznCtDshm5ElNE4i8N
kYKiNKJzd+gw2nnaGdj/mhD9DvjHEJ+vYXTyAkNG2/X35AnQhB4T390WEg/eBJRD
qYjs/GAoxS+7cC4DxZlCJfy4IB1sZsbsowHclrURe+yNOx8ep+w73cp2HdY1U74e
qDNJ255BGG01liznSg58rMYrf7IhwioYMQ9eC5V7NxTld637mSwymmFdTp02Zq6k
8KqiPDW+RRMUNitjtB/VwdvKXzHe7isfyzGVSZrmUHgZeZw0/NLcObddJKWVwnaI
U2jgMWuzL1VTQLUKjc+B6NZjkFHhOgxXgOT8gu1EcMq/RdLV3e+pr7rJBzNYWU6t
Dc9DAksvkiizPzMeZF6nQvdw7TILffYWEtSRHx5m+5uYFgVfTs7Ssdvtm9AZH/ae
N3T0TdRrDevK5Ciqp+P/G+iW1pw7l38QLqiq2aWDywmpUOIq3BJFvepSfoaQR05x
hbofdUGRM9mhDc3O9O6tZGoJPzSqVq93I4dX/dZWR+P6/yR3V+kkgCX+slEJCNGq
I4KtZTJ7QFVWQM33Ox3zBJ5pwghBPkCoZmiT3cxuspKi5DSktyR8ojob3ULcva3p
QrcjFZCebmREjxZRVyyi9IF3qoBvDlfFhJ9kLC2kTkiS8oVlNCutF7M6oWfvx1US
0m7YqfUecJpEu5lGKblQ6XAIdiIjFWon+TBn/K4gzvDHks5Li5wv8qV4t/jMMEU=
=HmNj
-----END PGP SIGNATURE-----

Thanks.  We'll look into fixing this in the next build.  If you can find a patch to fix this it would help us out.  I personally don't have a Mac, and our Mac developer is very busy right now.

Can you point me to a mac OSX dmg of the litecoin-qt of that version and I can then verify.

http://download1.rpmfusion.org/~warren/litecoin-0.8.5.2-rc2/
It was linked from that previous URL.  Please use GPG to verify the download.

http://blog.litecoin.org/2013/10/litecoin-v0852-rc2-release-notes.html
Could you please verify if that bug exists in Litecoin v0.8.5.2-rc2 too?  We copied nearly all the patches from our Litecoin branch, so I'm curious if it needs to be fixed there too.

Their is an issue on the current 0.8.5 mac version, there was like a menu that would pop up when you right clicked on the dock icon, this was so when it was hidden it would come back.
https://github.com/bitcoin/bitcoin/issues/1522

Now that bug has been reintroduced on this build. Love this build thou! Already used coin control!

I'll redo my dep sha256sums when I return from an appointment today.  We need to get this right.

all I can tell you ATM, before going to bed, is that my win32 sigs are different
https://github.com/piotrnar/gitian.sigs.omg/tree/master/0.8.5-OMG1-win32/piotrnar

though I took the HEAD - might that be the problem?
I would not think so, since its the same commit id as the tag: 5b474dacd8ae0d32f8c76dead7b7e9905d868ec3

EDIT:
Please see this post: https://bitcointalksearch.org/topic/m.3441007

thx warren, good work. that was alot of work i guess   !

cant wait to see that for Litecoin.