Is there any chance that a hacker gets to see all of your private keys? or he would need to have a RAT installed on your computer and enter the "dumpprivkey" command on every address WHILE your Core client is opened and unlocked?
In all honesty, it really isn't that hard for a hacker to copy your wallet.dat remotely and enter the password he captured. You wouldn't even know it.
If your computer has a RAT or any malware in particular, everything about you is compromised. They can get it from memory but they would only get the encrypted keys till you unlock it.
And the HD wallet.dat from Core does have a seed that could be hacked? (with all of your funds on it). Im still using the good ol wallet.dat (it shows HD is not enabled) and I was wondering about that..
If you have a HD wallet, it would have the same seed till you change/set/remove the password. If any attacker gets any of your backups unencrypted/encrypted with weak password, then you're doomed.
However, without HD wallet, they can only, at most get 1000 addresses. Lets say you use it frequently and you had a backup 2 years ago that was compromised. As long as you have had 1000 transactions, your current Bitcoins remain safe, provided that you have no coins on older addresses.