This is a patch for double deposit bug. Johny said his script is bugs free. No it is not.
/var/www/content/cron/check_deposits.php
/var/www/content/cron/check_deposits.php
Code:
if ($delExed==true) {
+ if (mysql_query("SELECT COUNT(*) FROM transactions WHERE txid = '$dp[txid]'") >= 1) {
+ echo "TXID already exists!";
+ }
+ else {
mysql_query("UPDATE `players` SET `balance`=TRUNCATE(ROUND((`balance`+$received),9),8) WHERE `id`=$dp[player_id] LIMIT 1");
mysql_query("INSERT INTO `transactions` (`player_id`,`amount`,`txid`) VALUES ($dp[player_id],$dp[amount],'$dp[txid]')");
+ }
+ if (mysql_query("SELECT COUNT(*) FROM transactions WHERE txid = '$dp[txid]'") >= 1) {
+ echo "TXID already exists!";
+ }
+ else {
mysql_query("UPDATE `players` SET `balance`=TRUNCATE(ROUND((`balance`+$received),9),8) WHERE `id`=$dp[player_id] LIMIT 1");
mysql_query("INSERT INTO `transactions` (`player_id`,`amount`,`txid`) VALUES ($dp[player_id],$dp[amount],'$dp[txid]')");
+ }
The fact that we have not used your fix does not mean that we haven't solved it other way.
The script is secure even without this edit.
This thread is unactualized, please use thread for version 3.
The problem happens when the cron is re-executing the currently unfinished running cron because of large database. You should listen to your users once in a while because the bug is really happening.
