Please check
https://github.com/unicoinex/walletinfoWhat works:
Everything except balance (just need to put regex for each explorer. Mostly trivial work left) Balances also added.
Only included top 10 coins for this initial release. New coins will be added gradually.
So essentially the app is complete and just needs the remaining coins addition
Please note that since its in python, for the sake of completeness, I have kept the coin details within the file.
Thanks cointra! I'll be able to check it out in detail in this weekend and will post any feedback here.
Hi coiner8, did you get the chance to check it out?
Hi cointra,
I can't test it easily or fully because it uses pywallet's strange and broken --datadir. The script needs to be able to work by providing just the path to a wallet file, no --datadir option. Also pywallet's implementation only opens files named "wallet.dat", even if you specify a different file. The script should be able to handle a wallet with any filename. If it requires a working directory it should handle that internally.
- --list-keys: The format of the public and private keys should be the "usual" format. For the public key, that is the format shown in the client and block explorers (i.e. 1GoK6fv4tZKXFiWL9NuHiwcwsi8JAFiwGK). For the private key, it should be the format used by the client's "dumpprivkey" and "importprivkey" commands. For long term planning perhaps adding a --format option where the default is the "usual" format would be a good way to go.
- --list-keys: When I do --list-keys (or pretty much any other command) the script needs to output the warning/notice about the encryption status as the first line of stdout. See the OP for details.
- --is-encrypted: This is outputting "Encrypted" even for wallets I'm sure are unencrypted. I haven't been able to get it to say "Unencrypted" yet.
- --is-encrypted: When I ran this on a newly created encrypted Blackcoin wallet I got this error:
Traceback (most recent call last):
File "wi.py", line 1685, in parse_wallet
item_callback(type, d)
File "wi.py", line 1323, in item_callback
if passphrase:
NameError: global name 'passphrase' is not defined
ERROR parsing wallet.dat, type mkey
key data: mkey
key data in hex: 046d6b657901000000
value data in hex: 3086c443a92ac09f438ff7d70d9caea2d35bf0de063cf8b8e948540c95e3196f39a5a02201eb0db22e03d20f93977f00f108ac026eb2a53908a200000000a861000000
[/li]
[li]--test-passphrase: Same error as above.[/li]
- --list-contacts: The labels should be in double quotes. If there is no label for an address, output "".
- --balances: I tested with a Zetacoin wallet and it gave an error for each address: "Error reading balance for address". The URL in the script returns a 404 when I visit it in my browser.
- --explore-url: Should be named --explorer-url. Also it output "None" as the last line. Not sure why that was, but each line should either be a URL or an error message.
This list of issues doesn't represent a full thorough test. The inconvenience of the --datadir/wallet.dat filename issue was enough that I only tried a few different wallet files. Once that issue is fixed I'll do a more complete test of all features with more wallets.
And despite the list of issues, I do think the tool is coming along well. It seems like it has the core routines it needs, it just needs to be polished for user friendliness.
Resolved most of your reported issues:
- is-encrypted now works
- datadir is removed (use --wallet and pass wallet path, works with any name)
- Zetacoin is an issue with zetachain.cc but I don't blame them they clearly mention that they're in beta. Will see if I can find any other zetacoin explorer
- list-contacts now show labels in double quotes
Some things still left, I will commit the whole later today once they are all done.