Is it a good idea to still have most of my crypto on cold storage in a few months when the market is pumping and I am wanting to sell or is it best to start moving everything to exchanges which will then make it easier to sell?
I don't think this is a very good idea. You can sell crypto not only through centralized exchanges, like binance, but for example, bisq or an aggregator of exchangers - bestchange, and then the unsafe moment of storing crypto on the exchange disappears. In these cases, time is lost only on confirming transactions, but the price is temporarily frozen until the end of the deal, that is, in fact, it is as if you are selling crypto instantly (at current price).
I am just thinking it will be a long process having everything on my cold storage and then seeing the market pumping then having to send everything back over to exchange I may miss the best prices to sell as it will take some time to send everything from cold wallet to exchange.
If the
crypto network is not overloaded and there are no overpriced high transaction fees, then I don’t think you will miss out on the best selling price. Again, don’t try to catch this best selling price, but sell when it’s already profitable for you. Don't be greedy.
I understand it is more safe to have crypto on cold storage but is it less likely in the peak of a bull run for exchanges to fall? If so, I feel it would be better to send all of my crypto to exchange in advance to then be ready to sell everything.
So you see, you understand the risks associated with storing on an exchange, but you still want to hear that it is a safe way. Don't you think you're being too greedy? Don't forget, greed leads to poverty. Crypto will already allow you to make a good profit. Be grateful for at least this.