Pages:
Author

Topic: Identifying the linked-to post in a topic (SMF patch) (Read 916 times)

legendary
Activity: 2464
Merit: 3878
Hire Bitcointalk Camp. Manager @ r7promotions.com
Basically, the idea is to make it easier to identify the target post after clicking an ordinary post link
Nice work and good to see the quick implementation. It took me a few minutes to understand the idea and how it's changing :-D

About the deleted posts do you think anything can be done like clicking on the deleted post will give a notification that it was deleted instead of taking us to the same page of the topic where it was posted? It will help the users not to look for the linked-to posts when there are no posts at all.
hero member
Activity: 510
Merit: 4005
Added, thanks!


(A bit over-the-top for such a dinky little patch, but, I can hear Ace Ventura in my head, saying: "Yes. Yes. Oh, yeah. Can ya feel that, buddy? Huh? Huh? Huh?") Grin

What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.
So, style B + (unrevised) style C. Nice!

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.
I wonder if some users would appreciate the factoids (especially the older ones) being preserved/accessible for nostalgia's sake? Maybe a new endpoint (like /factoid.php or /index.php?action=factoid) that displays a random one each time? (I mean, I count 30 Wayback Machine snapshots of /adrotate.php?adinfo from 2013 to 2023, so it's not strictly necessary, I suppose, but, yeah, something first-party might be nice...)



Something's wrong Sad
Yep, I noticed that, too. It's a long-standing SMF issue/quirk/design-decision, and wasn't caused by this patch (it's just easier to notice now).

It's quite complicated to explain, and most people would find the details boring AF, so, suffice it to say: it's okay if the message ID doesn't actually belong to the topic, as long as that message ID can be used to calculate the correct offset into that topic (that is, as long as it lands you on the right topic-page, the #new fragment takes care of putting you on the right message). A different way to think about it, is to consider what happens when you have a link to a deleted post: the message ID in the link is no longer part of that topic, but navigating to it will still land you in roughly the right place (topic-page-wise).

In the context of this particular patch, it might have worked out nicer if SMF was more precise about message IDs in a few places, but it actually works out pretty neatly as-is, I think (that is, links with a #new fragment don't really correspond to one message, they correspond to potentially multiple new messages since the last one you read, so there's an argument to be made that it actually makes sense not to graphically single-out the first one).
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
There is nothing wrong
Compare the msgID in both URLs from my code-tags. Then open both URLs. I don't get where the "new" msgID comes from.

According to the PowerGlove code, it is a php tag, which creates this change.

Check the OP in style B: https://bitcointalksearch.org/topic/m.63898641
legendary
Activity: 1789
Merit: 2535
Goonies never say die.
~
What about community-updated factoid? I think that they were nice. It might surprise you but I love the idea of ads on this forum, it gives you a little break between original post and replies and also it's nice when you see something new displayed.
I've been happy about less banner ads, but I'm not sure it was necessary to remove every factoid just because some were outdated. *shrug*


Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.
+1

~while maybe the factoids were providing some value, many of them were outdated.
-2

 Grin


Good job again PowerGlove! Wink
legendary
Activity: 3290
Merit: 16489
Thick-Skinned Gang Leader and Golden Feather 2021
There is nothing wrong
Compare the msgID in both URLs from my code-tags. Then open both URLs. I don't get where the "new" msgID comes from.
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
Let's test again:
"new":
Code:
https://bitcointalk.org/index.php?topic=5496329.msg64078469;topicseen#new
Post #64078469 is in a different topic:
Code:
https://bitcointalk.org/index.php?topic=5495745.msg64078469#msg64078469

Something's wrong Sad

There is nothing wrong, it is working as intended.
The new graphics only appear when the link has #idpost, in other cases it remains normal.

This is because what gives the order to the browser to apply another graphic is the address ending with #idpost.
Because ;topicseen#new varies from post to post. In other words, it always points to the last post, regardless of the author of the post.

It's true that this could be adjusted, but I don't think it's that relevant.
legendary
Activity: 3290
Merit: 16489
Thick-Skinned Gang Leader and Golden Feather 2021
Added, thanks!
I got to your post by clicking:
Code:
https://bitcointalk.org/index.php?topic=5491546.msg64025684;topicseen#new
Shouldn't the post be black with this link too?

If I click the title of the post, I get:
Code:
https://bitcointalk.org/index.php?topic=5491546.msg64075749#msg64075749
This works as expected



On closer look, why does the "new" link have post #64025684 in the URL?



Let's test again:
"new":
Code:
https://bitcointalk.org/index.php?topic=5496329.msg64078469;topicseen#new
Post #64078469 is in a different topic:
Code:
https://bitcointalk.org/index.php?topic=5495745.msg64078469#msg64078469

Something's wrong Sad
hero member
Activity: 882
Merit: 792
Watch Bitcoin Documentary - https://t.ly/v0Nim
Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.
I noticed this today when I checked reply on my post via Ninja's bot and I was like, am I tripping? Is this the first time I noticed this difference between quoted and other posts? But as it looks, this feature was implemented today. Nice, by the way it would be good if you convert tables into flexbox or grid because that would make this forum responsive. Just like I did here: https://bitcointalksearch.org/topic/m.61056851

What about community-updated factoid? I think that they were nice. It might surprise you but I love the idea of ads on this forum, it gives you a little break between original post and replies and also it's nice when you see something new displayed.

legendary
Activity: 3822
Merit: 2703
Evil beware: We have waffles!
Dang that was quickly done! Grin
I like the new change.
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.

The difference is confirmed! Thank you for accepting this change.

Old:

New:

Now, we just have to get used to this new thing.  Cheesy
administrator
Activity: 5222
Merit: 13032
Added, thanks! What looked best IMO was to do the arrow and black color, but without the text-decoration:none or cursor: default.

Also, while I was messing around with the topic HTML anyway, I decided to just completely remove the ad area. I don't foresee selling ads again anytime soon, and while maybe the factoids were providing some value, many of them were outdated.
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
What does the link-tree have to do with the title of the post?
The title of the post could have the same style.

OK. Also put the title of the post in black.
It would be a described change that could help with this identification, but perhaps many would not notice the difference.

Now, if it's the solution that involves fewer code changes, it seems like a good solution to me.
legendary
Activity: 3290
Merit: 16489
Thick-Skinned Gang Leader and Golden Feather 2021
Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:
You and me both, I didn't know it until you wrote it I read it here.

What does the link-tree have to do with the title of the post?
The title of the post could have the same style.
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:



It has its text-decoration set to none and its cursor set to default, so it's easy to miss, I guess, but it kind of makes sense in a weird way; it's like it's saying: "this is where you are, yo." Cheesy

Anyway, if that's an idea that's worth repeating, then the second diff for style C should be like this:

I'm sorry, but I didn't notice your adjustment to the proposal.  Undecided

What does the link-tree have to do with the title of the post?
hero member
Activity: 510
Merit: 4005
Hmm... I never noticed that the last (bold-faced) item in the link-tree is an actual link:



It has its text-decoration set to none and its cursor set to default, so it's easy to miss, I guess, but it kind of makes sense in a weird way; it's like it's saying: "this is where you are, yo." Cheesy

Anyway, if that's an idea that's worth repeating, then the second diff for style C should be like this:

Code:
--- baseline/Themes/default/Display.template.php 2010-10-22 01:38:35.000000000 +0000
+++ modified/Themes/default/Display.template.php 2024-04-11 01:21:29.000000000 +0000
@@ -359,33 +359,34 @@
  echo '
  ', $settings['use_image_buttons'] ? '' . $message['member']['online']['label'] . '' : $message['member']['online']['label'], '';
  }
  }
  // Otherwise, show the guest's email.
  elseif (empty($message['member']['hide_email']))
  echo '
 

 

  ', ($settings['use_image_buttons'] ? '' . $txt[69] . '' : $txt[69]), '';
 
  // Done with the information about the poster... on to the post itself.
+ $is_requested_message = isset($context['requested_msg']) && $context['requested_msg'] == $message['id'];
  echo '
 

 
 
 
 
 
  , using a different color than the usual alternating blue and grey (but not too different).

Maybe a minor issue, but this could effect any styling/colors on a post that a user created to go with the current grey/blue. Also, this could lead to a way for a user to create text using whatever color is chosen, which would look normal on the thread, but a linked version to the post could then visually hide that text.


~Would doing so break anyone's parsers?

Looks good here. We're mainly using pages where these hidden posts don't exist anyway so it shouldn't effect BPIP's parsers.

--
I'm liking the thicker side borders myself, but I'm biased. Grin
legendary
Activity: 3290
Merit: 16489
Thick-Skinned Gang Leader and Golden Feather 2021
Those are decoy posts meant to confuse adblockers. This is also why a lot of the CSS classes randomize on each pageload. Now that there are no ads, I could remove both of these things. Would doing so break anyone's parsers?
I don't expect to have any problems with this.
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**

  ';
 
  // If this is the first post, (#0) just say when it was posted - otherwise give the reply #.
  echo '
 
« ', !empty($message['counter']) ? $txt[146] . ' #' . $message['counter'] : '', ' ', $txt[30], ': ', $message['time'], ' »
';
 
  // Can they reply? Have they turned on quick reply?
  if ($context['can_reply'] && !empty($options['display_quick_reply']))
  echo '
  ', $reply_button, '';

(I see references in SMF to a "nav" class for the link-tree, and a reference to a "navPages" class for the page-list; makes me think that the idiomatic way to repeat this idea would be to add a "navMessage" class instead of doing this with an inline style.)

@theymos: I know this is off-topic, but, seeing as though you're watching the thread, and while I've got links on my mind: if/when you find some time, maybe you could quickly tackle this one? (I think that suggestion makes a lot of sense; when LoyceV first mentioned it, I remember thinking: "Ooh, that's a nice little improvement.")

P.S. I blew all of my theymos-sMerit on your April Fools gag, so I won't be able to merit your posts for a bit. Wink
legendary
Activity: 1722
Merit: 4711
**In BTC since 2013**
I tried a border on the top/bottom as well but it felt too loud, with all of the other horizontal lines going on with quotes, posts, banner/sigs, etc. I don't mind the bgcolor on the title though, sort of what I was trying to do here. The yellow isn't too bad on a mobile device, but on a desktop the long yellow strip feels too much, for me at least. Smiley

This option can also be interesting, but without the border. And in terms of color, you can use the same tone of blue that is used in the posts, with two shades interspersed. Placing the respective post, with the header having a different tone from the rest of the post.

I don't know if I made myself understood, but I'm a little lazy to take some images. Maybe later.  Tongue
legendary
Activity: 1789
Merit: 2535
Goonies never say die.
with the entire post, maybe a simple border on the left/right:
Code:
border-left: 2px solid #537798;
border-right: 2px solid #537798;
It's also a good idea. But I didn't limit the highlights to the left and right border. It would include the top and bottom.

I tried a border on the top/bottom as well but it felt too loud, with all of the other horizontal lines going on with quotes, posts, banner/sigs, etc. I don't mind the bgcolor on the title though, sort of what I was trying to do here. The yellow isn't too bad on a mobile device, but on a desktop the long yellow strip feels too much, for me at least. Smiley


- Change the color of the entire post
with the entire post, maybe a simple border on the left/right:
Code:
border-left: 2px solid #537798;
border-right: 2px solid #537798;

It's also a good idea. But I didn't limit the highlights to the left and right border. It would include the top and bottom.
legendary
Activity: 1789
Merit: 2535
Goonies never say die.
If you can do something on the
with the entire post, maybe a simple border on the left/right:
Code:
border-left: 2px solid #537798;
border-right: 2px solid #537798;



edit:

maybe a little thicker: Grin


Pages:
Jump to:
© 2020, Bitcointalksearch.org