Ok, here's what's going on. It does save an empty signature but doesn't update the profile page so it still shows the signature after I hit Save. The signature goes away if I refresh the page. Still a bug IMO. If I change a signature to a non-empty one it shows up immediately.
Seems adding a signature is initialized and displays info without refresh. Deleting does not. Will have a look into this
No e-mail notifications for PMs.
True... added on the to do list
How do I run unit tests? I made some code changes, need to verify it doesn't break anything.
My best advice is to run circleci in your repo where you forked epochtalk
A few things I've noticed:
-Image drag/drop is glitchy with multiple images. When dragging/dropping 2 (or more) images (back-to-back), the [img] tags get created, but in preview it usually doesn't show the 2nd image at all, if you post it, it clears out the 2nd [img] tag. I've found I had to hit 'enter' at least once or twice between each drag/drop to get it to post correctly.
Could not really replicate this.
https://coinbistro.com/threads/0ikKhHejRWmWWV3R8l6EgA/posts?start=55#Nly-V65FSZmJsrtdDG8eZg worked with images in a row and on separate rows
-Also related, drag/drop of one or many images with no text doesn't allow 'send reply' to be hit.
-No drafts capability for new messages.
I know this was an issue but thought it was fixed. We have version e5bf006c on Coinbistro
https://github.com/epochtalk/epochtalk/commits/e5bf006c It would display it in the Admin panel top left as "Running version:....."
Yeah, drafts... Noticed that but the guys did not get to it yet
-Also with new messages, when moving to 'preview', the window gets the focus (hitting the delete key will close the window, wiping the message). Same thing happens when switching back to 'compose', the window itself stays with the 'focus', not the text box, and hitting the delete key (thinking you're deleting text) will close the message window entirely, wiping the message, due to the aforementioned lack of draft capability.
I found that out after writing a pretty big post... Was pretty pissed.
I assume it was an added feature with a small bug. For example you can change between pages in a thread and the text box will not close. Only if you leave the thread then you lost the post.
More PM weirdness:
- I can't send a PM to myself. I should be able to.
Never tried to PM myself, but makes sence- I can send a PM to DefaultTrustList. I don't think I should be able to.
Would hate to see that inbox. ) Will add some restrictions- There is no visual difference between sent and received, read and unread messages. All messages in the list look exactly the same.
That should be solved by the notifications in the header, tho I agree some slight differentiation should be made- If I type in a non-existent username (or my own) and try to send a PM to it I get a non-descriptive error message "Failed to create conversation". It should tell me that the user doesn't exist.
Will see about these custom errors. The input box is bolded red for what it's worth - When it fails "to create conversation" my message disappears. So if I type a lot of text and then misspell recipient's username - all my work is gone.
same as for posts. Once draft module will be in place should fix that and some restrictions like "start new conversation"/"reply" not active if username not correct- If I try to send a message to multiple recipients and some are non-existent - there is no error message.
- Paging with back/forward buttons is not scalable. I have 150+ pages of messages on Bitcointalk. It would take me 150+ clicks to get to my oldest messages on Epochtalk. Probably 200+ clicks, since the page size is set to 15 with no way to change it.
the format is changed. did you PM with 3000+ different users ? might be possible I guess. Will talk to the guys about pagination. Fair enough... Do not have that many PMs in order to start using labels. I guess did not think about them- No option select and delete multiple messages at once.
- No option to quote a message in a reply (the need is somewhat minimized by the threaded layout but it is still needed).
Fair enough... [/list]
What's so special about 3+ hyphens that I can't post them but I can post one or two?
There is some weird voodoo with those hyphens.
If you write only 3hyphens it shows a HR in preview (but cannot post). Because "- - -" actually is HR and somehow is confused by the spaces.
BBCode is a separate discussion on it's own.
I'll try to give them examples of what is wrong and will see later. Will definitely have a few more iterations .
Thanks for all the feedback !