Increasing the number of keys in key pool - page 2.

Stephen Gornick

legendary

Activity: 2506

Merit: 1010

Quote from: jl2012 on September 30, 2012, 03:03:27 AM

it is very easy to increase the key pool from 100 keys to 10000 keys. Adding 2 or 0 zeros in the source code will solve 99% of the problem

As has been described, a larger key pool wouldn't have solved the problem described where enabling wallet key encryption flushes the entire pool, but if you want to the key pool can size be controlled with a config setting:

-keypool= Set key pool size to (default: 100)

- http://en.bitcoin.it/wiki/Running_Bitcoin

CIYAM

legendary

Activity: 1890

Merit: 1086

Ian Knowles - CIYAM Lead Developer

Good stuff!

I think that should get the message across (red text is probably not necessary).

runeks

legendary

Activity: 980

Merit: 1008

I just hacked together a quick patch in this pull request: https://github.com/bitcoin/bitcoin/pull/1890
Here's what the dialog looks like now:

If the devs wish they can make the text red.

CIYAM

legendary

Activity: 1890

Merit: 1086

Ian Knowles - CIYAM Lead Developer

Quote from: runeks on September 30, 2012, 03:35:36 AM

I don't think it does. At least there's an open issue regarding this on the bug tracker: https://github.com/bitcoin/bitcoin/issues/1884

Ouch - if that is true then certainly it needs to be changed (and the notice should probably be presented to the end user in a bold font with a bright color).

YOU NEED TO BACKUP YOUR ENCRYPTED WALLET BEFORE MAKING ANY TRANSACTION OR YOU COULD LOSE ALL YOUR BITCOINS!

runeks

legendary

Activity: 980

Merit: 1008

Quote from: CIYAM on September 30, 2012, 03:23:27 AM

The lesson is to immediately backup after encrypting (and I believe the software does warn you that you need to).

I don't think it does. At least there's an open issue regarding this on the bug tracker: https://github.com/bitcoin/bitcoin/issues/1884

CIYAM

legendary

Activity: 1890

Merit: 1086

Ian Knowles - CIYAM Lead Developer

Actually it wouldn't matter how many keys were in the key pool in the case you have linked to as his backup was unencrypted then he encrypted his wallet and then sent BTC.

He lost the BTC because it was sent to a "change" address and that address (for security reasons) is not taken from the unencrypted pool but instead from a new pool that is created when you encrypt the wallet.

The lesson is to immediately backup after encrypting (and I believe the software does warn you that you need to).

jl2012

legendary

Activity: 1792

Merit: 1111

Again, someone lost >1300BTC due to misconception about wallet backup: https://bitcointalksearch.org/topic/can-the-encrypted-wallet-be-recovered-using-the-unencrypted-110781

It might be difficult to implement deterministic wallet in the next release. However, it is very easy to increase the key pool from 100 keys to 10000 keys. Adding 2 or 0 zeros in the source code will solve 99% of the problem

Topic: Increasing the number of keys in key pool - page 2. (Read 3813 times)