Merit option for poster | Bitcointalksearch.org

Ojima-ojo

hero member

Activity: 910

Merit: 507

Quote from: promise444c5 on June 03, 2024, 07:21:56 AM

It's just like a camouflage.... why not just hide it for self posts???

May be in the next forum upgrade that feature may be removed, but for now, since one can not send merits to they own posts even though the boton is available it doesn't make any different, and just as others have said, having such features does not effect anything but still it boring having such features which we all agree that it useless and at the same time harmless.

So it won't be a priority for admin and maybe in the near future that boton can be converted into a new forum future which at least not leave that space vacant since it already in the forum codes already.

acroman08

legendary

Activity: 2534

Merit: 1115

Quote from: promise444c5 on June 03, 2024, 07:21:56 AM

It's just like a camouflage.... why not just hide it for self posts???

probably because it is an unnecessary hassle so it is not worth "fixing". also, from my point of view, it doesn't really affect anyone or anything vital in the forum so I don't really see the point of giving much attention to it.

Quote from: Beparanf on June 03, 2024, 07:49:22 AM

Unless you send a merit on your own then this feature should be hide.

yeah, if people can send merit to their own post through the merit button then it should be hidden/removed.

Despairo

hero member

Activity: 1064

Merit: 843

Read Why seeing merit button on my post when I can not merit my own post

Bitcointalk's hacker already noticed this discussion, so we might see there could be a new improvement.

Quote from: PowerGlove on June 02, 2024, 10:34:01 PM

This one's a bit tricky... I don't have access to theymos' code, so all I can really do is guess at what the code might look like, and then patch the reconstruction.

My guess would be that the code in question is somewhere between one half and two thirds of the way into a function called template_main() inside a file named Display.template.php, and that it looks something like this:

Code:

if(!$context['user']['is_guest'] && !$message['member']['is_guest'])
echo '
+Merit';

Using that guess as a baseline, the patch would consist of extending that if-condition with && $message['member']['id'] != $context['user']['id'], like so:

Code:

if(!$context['user']['is_guest'] && !$message['member']['is_guest'] && $message['member']['id'] != $context['user']['id'])
echo '
+Merit';

(For everyone's info: I don't receive notifications when I'm mentioned. I'm working on adding a simple mention system to SMF, but, until then, there's no guarantee that I'll bump into every @PowerGlove. If you suspect I've slept on some important forum-improvement topic, feel free to shoot me a PM.) Wink

I only checked this afterwards, so I'll leave my original guesswork as-is, but, I see that the "+Merit" link does appear on guest posts, so whatever the actual if-condition is, it's missing the && !$message['member']['is_guest'] that I included in the guessed-at code. (I would add it, though: guest-meriting is similar to self-meriting; may as well just not emit links that can only error-out if you visit them.)

Beparanf

hero member

Activity: 2954

Merit: 796

I think due to SMF limitations or its an additional work to hide to own post while it doesn’t give bad effect by having a useless merit button on your own thread.

It’s like our appendix. It’s attached to us without any purpose yet it doesn’t give negative/positive effect so we are ok if we don’t remove it.

Unless you send a merit on your own then this feature should be hide.

Fiatless

hero member

Activity: 574

Merit: 554

Leading Crypto Sports Betting & Casino Platform

Quote from: Hazink on June 03, 2024, 07:28:02 AM

It has always been there; if you try sending it, it won’t go through, just as it displayed on that screenshot you shared. I also saw two similar threads where the user was confused about whether she could merit herself or not.

I have not tried this option, but since I have never seen anybody meriting his post, I believe that it cannot be done. Removing the option from post is a good option but since it cannot be done, it's not a big deal.

Hazink

full member

Activity: 189

Merit: 120

It has always been there; if you try sending it, it won’t go through, just as it displayed on that screenshot you shared. I also saw about two similar threads where the user was confused about whether she could merit herself or not.

promise444c5

sr. member

Activity: 476

Merit: 299

Learning never stops!

We are all used to seeing the merit button on every post, even on self posts...
Recently I wonder why there's a merit button on my post so I tried to give it a try using one of my post Cheesy

Here was my result:

It's just like a camouflage.... why not just hide it for self posts???

Topic: Merit option for poster (Read 152 times)