Pages:
Author

Topic: Why seeing merit button on my post when I can not merit my own post (Read 463 times)

legendary
Activity: 2408
Merit: 2226
Signature space for rent
This isn't a serious issue that needs to be fixed. Eventually, you can't merit yourself. So nothing is wrong. If you can merit yourself, then it would be a matter of concern.

It just need to write couple of line on the code but waste of time actually.

This isn't a hassle for you also since you know it doesn't work meriting yourself.
full member
Activity: 350
Merit: 128
When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

You got me thinking and so as much you've made a very good point there. Apparently if we can't merit ourselves then the feature where we can observe the sMerits on our own posts seems not useful but let's just take it likely to say that the +Merit is a just a function by which we can access our sMerits status. That's to say we can always find that feature in self and others posts.
legendary
Activity: 4326
Merit: 8950
'The right to privacy matters'
A lot has to do with ease of coding. Back in 1979-1980 while in the US Navy we had a ton of software go bad.  Why it used the 7 from the decade to count time so when we went to the 8 as in 1980 the software erred out. I suspect many fear this was going to be big in 1999-2000 because they had seen 1979-1980 errors and 1989-1990 errors.
hero member
Activity: 1008
Merit: 629
 I also wondered the need for this merit button that can be seen but can't be used on one's self but then I realized that some of these things where probably left there by Theymos when this forum was being created to add some sort of uniqueness or something, or it was a feature that was added on later , I dunno but like the others have said it's not something to break one's head over, i feel it's best to ignore.
 There are some features in this forum that are just there for formality purpose and do not carry much weight or affect anything like this :"we reserve the right to decay unused smerits" because up till date I've not really seen any merits get decayed.
hero member
Activity: 510
Merit: 4005
This one's a bit tricky... I don't have access to theymos' code, so all I can really do is guess at what the code might look like, and then patch the reconstruction.

My guess would be that the code in question is somewhere between one half and two thirds of the way into a function called template_main() inside a file named Display.template.php, and that it looks something like this:

Code:
if(!$context['user']['is_guest'] && !$message['member']['is_guest'])
echo '
+Merit';

Using that guess as a baseline, the patch would consist of extending that if-condition with && $message['member']['id'] != $context['user']['id'], like so:

Code:
if(!$context['user']['is_guest'] && !$message['member']['is_guest'] && $message['member']['id'] != $context['user']['id'])
echo '
+Merit';

(For everyone's info: I don't receive notifications when I'm mentioned. I'm working on adding a simple mention system to SMF, but, until then, there's no guarantee that I'll bump into every @PowerGlove. If you suspect I've slept on some important forum-improvement topic, feel free to shoot me a PM.) Wink

I only checked this afterwards, so I'll leave my original guesswork as-is, but, I see that the "+Merit" link does appear on guest posts, so whatever the actual if-condition is, it's missing the && !$message['member']['is_guest'] that I included in the guessed-at code. (I would add it, though: guest-meriting is similar to self-meriting; may as well just not emit links that can only error-out if you visit them.)
legendary
Activity: 2716
Merit: 1225
Once a man, twice a child!
OP, your observation is merit worthy. Sad I don't have any to splash on it. I believe that button was an oversight when merit was coded into this forum, and could be too much work to edit out after it was discovered later on. Perhaps, @PowerGlove could come to the rescue now that such is under review.
legendary
Activity: 2534
Merit: 1115
I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.
as long as it doesn't allow us to merit ourselves, I don't see any issue with it, besides, its not like it is distracting or disrupt your day to day forum experience. also, I barely even notice it when I am online and as LoyceV mentioned, it's not worth the effort to remove it.
donator
Activity: 4760
Merit: 4323
Leading Crypto Sports Betting & Casino Platform
When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

It is corrected by the following step a click to merit yourself

That's funny.  I've never tried to merit myself before.  Seeing this, I went a step further and tried to leave myself a feedback rating.  I was also denied.  Damn.  I thought this was my chance to be a true self-scratcher.  It is a bit funny to think there are people out there who probably tried to leave themselves merit or trust ratings only to be denied.  I guess this is why some people spend so much time farming alts and forming trust/merit circles.  Personally, I think it would be funny if people could leave themselves merit, only instead of giving them merit it just destroys it.
hero member
Activity: 896
Merit: 654
Leading Crypto Sports Betting & Casino Platform
You mean you like to be meriting your own posts...lol Well, I've always seen that merit button on my posts but I believe it's not a big deal, especially if the system can tell you upon trying it that it is not possible to merit your post as the creator.

And if you had practically tried that before, then I must say you are one of the bravest hearts on this forum and curiosity must have pushed you towards that experiment. Smiley I've always been tempted to try it, even yesterday before you posted this topic, but I've tried my best to avoid it because if it mistakingly pushed through, I know I will have enough people to explain to on the forum that it was a mistake. Roll Eyes

You know how our people behave.
legendary
Activity: 4326
Merit: 8950
'The right to privacy matters'
When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

It is corrected by the following step a click to merit yourself




do a wrong amount 0 and see what happens




it tells you invalid amount even though you sent it to yourself

do a correct amount say 1


it says "fuck you asshole" you can't merit yourself.  I added that  just to wake us up this morning Grin


I can assure you that if you fix the merit yourself issue the way you do you will likely interfere with the code that says you sent a wrong / invalid amount.

To ask for what you want costs time.

Why not ask power glove  if he could fix it how long and how much code it will take then offer to pay him 100 usd an hour to fix it.


BTW when I see that other things are wrapped into it such as you sent an invalid amount 0 for instance. I know that "you can not send over 50 merits a month to the same person"  is linked into that same line of code.
legendary
Activity: 3290
Merit: 16489
Thick-Skinned Gang Leader and Golden Feather 2021
It's probably for the same reason you still see a Merit button when you've reached your maximum for that user, or when you're out of sMerit: it's not worth the effort to remove all exceptions.
legendary
Activity: 2184
Merit: 1302
Playbet.io - Crypto Casino and Sportsbook
You are correct that it shouldn't be there, but the admin is very reluctant to make changes (even when it is necessary), meaning they would never spend time implementing something that isn't actually a problem.

If a suggestion does not solve a particular problem, i don't think the admin would even think about implementing it, the merit button beside your own posts is not a problem, as long as you can't merit yourself and you get an error when you try it.
legendary
Activity: 2702
Merit: 4002
Without using userscripts, sending merits requires a lot of time and effort, so I agree with you that we need modifications, but they must all be in one update.

The most important thing is that if theymos is busy, why not ask for a developer, even part-time, there are a lot of modifications required, most of which have not been implemented.
legendary
Activity: 2072
Merit: 4265
✿♥‿♥✿
Is this a big problem? Let the merit button be a reminder for people who accumulate merit to be more attentive to other people's posts and not to be greedy in giving away their own.
Thinking about whether merit can be given to oneself seems like patting oneself on the head, since it is difficult to receive it from others. Such a thought has never occurred to me, and it’s funny when people think about it.
Perfectionism is certainly good, but it’s not the problem.
sr. member
Activity: 1260
Merit: 315
www.Artemis.co
Could this also be likened to a question as "why allow me see and click a locked thread if I cannot post in it?". I think we should just disregard things that do not seriously pose a problem to anyone in the forum. Let's keep going hoping that someday a new forum software might emerge.
I do not understand your question. But if it is about the topic that moderators locked, that the topic poster should not see unlock topic because it is the moderators that lock it and the topic starter can not unlock it. That is also a good suggestion. I posted this to bring it to PowerGlove notice if there is anything that can be done. Do not say an upgrade is not necessary. Even if we do not have new forum software as of now, there can be changes in this present software. Before 2FA was implemented on this forum, this is also how some people said something like you but now we have 2FA login.
I think what he meant by that is, since there's nothing can be done just like in locked threads, it's better to disregard it. But unlike in locked threads, there are a few reasons why it is locked but stays as it is, which is to be read and give information to other users. Especially, if it is a reminder or a rule that should be the first thing to be seen by all.

Meaning, it shouldn't be compared to what you have suggested. Having a merit button is not the same as locked thread.

Removing this merit button to your own post should be removed, only if it is possible. Though, it won't cause anything if the admin will not be going to remove it. We can just disregard it.
hero member
Activity: 700
Merit: 577
Could this also be likened to a question as "why allow me see and click a locked thread if I cannot post in it?". I think we should just disregard things that do not seriously pose a problem to anyone in the forum. Let's keep going hoping that someday a new forum software might emerge.

I think what the Op asked.or suggest is a good one because many we tempted to click that link but they were afraid and with this thread, my confidence was also build that if I merit myself I will not be penalized and I just tested the button and it shows that I cannot merit myself. It not this, I was always wanted to ask this question for long time but wasn't able to do so. I even thanks the Op for bringing this to the forum to reduce tension. I think a newbie created a similar thread I'm another form and he was rebuked.

There are something we over looked thinking that they are nothing and no mean harm but indepth looking they are dangerous. And now that Op has bring this to the public then we all now know that it has no harm.
legendary
Activity: 1064
Merit: 1298
Lightning network is good with small amount of BTC
Could this also be likened to a question as "why allow me see and click a locked thread if I cannot post in it?". I think we should just disregard things that do not seriously pose a problem to anyone in the forum. Let's keep going hoping that someday a new forum software might emerge.
I do not understand your question. But if it is about the topic that moderators locked, that the topic poster should not see unlock topic because it is the moderators that lock it and the topic starter can not unlock it. That is also a good suggestion. I posted this to bring it to PowerGlove notice if there is anything that can be done. Do not say an upgrade is not necessary. Even if we do not have new forum software as of now, there can be changes in this present software. Before 2FA was implemented on this forum, this is also how some people said something like you but now we have 2FA login.
hero member
Activity: 700
Merit: 577
This is the long waited question in the forum since the outset of my being here here. And if it is written " you can't merit yourself" then it is fine but if the opposite is found then disasters will occur but it's like that button is not working if not people would have merited themselves to see if the button is working in addition many people are afraid to click that button for the fear of penalty. That button was really tempting.

And since the button is not working then there is no need to keep that button or hyperlink there. It is better to remove it from the poster. I will test the button to know how it is after this post. I have tested it and this is the pop up message I got.
sr. member
Activity: 812
Merit: 436
When I go through a post of other members, I will see the link to a merit page which can be used to merit the particular post that you have just read. If it is my own post, I can not merit it. Then why should merit link to give merit to a post be seen on my own post when I can not merit myself. I think something should be done for us not to see the merit link on our own posts. Only other people's posts should the merit link be seen.

Nice observation, though i never thought about it for any reason, i don't even think I've once noticed for such, though since the merit pattern does not allow for one to merit self and if the button exist there, it only makes you rather remember that you can choose to merit any other post made after your own, but on the attempt to self merit yourself, you may discover that such is not allowed, but still yet, something can be done as OP have suggested that the feature does not applies to the original poster to see the merit icon on the post he made, while other post could remain as before having this feature.
hero member
Activity: 784
Merit: 672
Top Crypto Casino
I think there is no harm in seeing that merit button on our own post. We all know that we can't merit our own posts and that's why seeing that merit button isn't an issue and we can always avoid it without thinking too much about it.

I believe creating a code to disable that merit button on someone's own post can also create bugs, or other issues for the forum, and that's why I believe the button may stay there and members should continue avoiding that like they have been doing always.
Pages:
Jump to: