OFFICIAL CGMINER mining software thread for linux/win/osx/mips/arm/r-pi 4.11.0 - page 418.

Luke-Jr

legendary

Activity: 2576

Merit: 1186

Quote from: kano on December 19, 2012, 08:44:03 PM

Quote from: Luke-Jr on December 19, 2012, 07:02:26 PM

Quote from: Askit2 on December 19, 2012, 05:38:34 PM

It fixes the shares looking high because the (I am guessing backup Bitcoin) target is far higher. I would rather see what the highest achieved was not the highest accepted was. Cool

Seems like a solution in search of a problem.

Both before and after intend to show the highest achieved. But the cgminer code calculated the hash twice, in two different ways, and the hash-to-difficulty code assumed it was one of those ways. When the share doesn't meet the pool target, the hash-to-difficulty code was run on it with its hash calculated the opposite way, and as a result gave the wrong result. My rewrite cleans up the code so it's actually readable, and makes the share->hash value always consistent with SHA256 and the share_diff function expectations.

I also wrote a much-less-changed fix for BFGMiner 2.8.x and 2.9.x: https://github.com/luke-jr/bfgminer/commit/006faac
This one doesn't clean up the code to make it more readable, though. But as a diff, it is easier to see what the problem was.

The function you replaced works fine and does exactly what I wrote it to do 15 months ago.

Trolling and lies ignored... the function you wrote (regeneratehash) indeed does work just fine. The problem is in fulltest, as is clear from the much-less-changed patch.

kano

legendary

Activity: 4634

Merit: 1851

Linux since 1997 RedHat 4

Quote from: Luke-Jr on December 19, 2012, 07:02:26 PM

Quote from: Askit2 on December 19, 2012, 05:38:34 PM

It fixes the shares looking high because the (I am guessing backup Bitcoin) target is far higher. I would rather see what the highest achieved was not the highest accepted was. Cool

Seems like a solution in search of a problem.

Both before and after intend to show the highest achieved. But the cgminer code calculated the hash twice, in two different ways, and the hash-to-difficulty code assumed it was one of those ways. When the share doesn't meet the pool target, the hash-to-difficulty code was run on it with its hash calculated the opposite way, and as a result gave the wrong result. My rewrite cleans up the code so it's actually readable, and makes the share->hash value always consistent with SHA256 and the share_diff function expectations.

I also wrote a much-less-changed fix for BFGMiner 2.8.x and 2.9.x: https://github.com/luke-jr/bfgminer/commit/006faac
This one doesn't clean up the code to make it more readable, though. But as a diff, it is easier to see what the problem was.

The function you replaced works fine and does exactly what I wrote it to do 15 months ago.
Check and see if it was a block based on the block header difficulty.
... though as I said, it's way faster that your replacement - which most likely is code you just copied out of elsewhere (and now say it's yours)

Oddly enough that's still required in cgminer - I guess the clone doesn't need that any more Tongue

There is nothing to clean up except your retarded brain not being able to understand the simple original code I wrote.

Luke-Jr

legendary

Activity: 2576

Merit: 1186

Quote from: Askit2 on December 19, 2012, 05:38:34 PM

It fixes the shares looking high because the (I am guessing backup Bitcoin) target is far higher. I would rather see what the highest achieved was not the highest accepted was. Cool

Seems like a solution in search of a problem.

Both before and after intend to show the highest achieved. But the cgminer code calculated the hash twice, in two different ways, and the hash-to-difficulty code assumed it was one of those ways. When the share doesn't meet the pool target, the hash-to-difficulty code was run on it with its hash calculated the opposite way, and as a result gave the wrong result. My rewrite cleans up the code so it's actually readable, and makes the share->hash value always consistent with SHA256 and the share_diff function expectations.

I also wrote a much-less-changed fix for BFGMiner 2.8.x and 2.9.x: https://github.com/luke-jr/bfgminer/commit/006faac
This one doesn't clean up the code to make it more readable, though. But as a diff, it is easier to see what the problem was.

kano

legendary

Activity: 4634

Merit: 1851

Linux since 1997 RedHat 4

Quote from: -ck on December 19, 2012, 05:27:56 PM

Quote from: kano on December 19, 2012, 04:05:55 PM

Quote from: Luke-Jr on December 19, 2012, 02:15:54 PM

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Fix for this is https://github.com/luke-jr/bfgminer/commit/bfab076d

Lulz - replacing my one function I wrote 15 months ago with 5 - and slower Tongue

Does it actually fix anything?

No Idea.
There's nothing wrong with the function he replaced.
If I had to guess without looking at the code I'd guess there is a static variable somewhere (or similar).
Working on the BFL->USB today, I'll have a look at this, after the code changes I'm doing are working

That change is: Showing 4 changed files with 72 additions and 83 deletions.
No doubt the fix will be something quite simple, not an attempted rewrite of anything Luke-Jr doesn't understand.

Askit2

hero member

Activity: 981

Merit: 500

DIV - Your "Virtual Life" Secured and Decentralize

It fixes the shares looking high because the (I am guessing backup Bitcoin) target is far higher. I would rather see what the highest achieved was not the highest accepted was. Cool

Seems like a solution in search of a problem.

-ck

legendary

Activity: 4088

Merit: 1631

Ruu \o/

Quote from: kano on December 19, 2012, 04:05:55 PM

Quote from: Luke-Jr on December 19, 2012, 02:15:54 PM

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Fix for this is https://github.com/luke-jr/bfgminer/commit/bfab076d

Lulz - replacing my one function I wrote 15 months ago with 5 - and slower Tongue

Does it actually fix anything?

kano

legendary

Activity: 4634

Merit: 1851

Linux since 1997 RedHat 4

Quote from: Luke-Jr on December 19, 2012, 02:15:54 PM

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Fix for this is https://github.com/luke-jr/bfgminer/commit/bfab076d

Lulz - replacing my one function I wrote 15 months ago with 5 - and slower Tongue

kano

legendary

Activity: 4634

Merit: 1851

Linux since 1997 RedHat 4

Quote from: rav3n_pl on December 19, 2012, 02:09:44 PM

Quote from: sharky112065 on December 19, 2012, 01:05:58 PM

Quote from: rav3n_pl on December 19, 2012, 09:54:11 AM

Quote from: kano on December 19, 2012, 07:56:58 AM

rav3n_pl ... FYI ... you only need 3 lines to build cgminer... and it's the same on mingw - you can specify everything before make on the single autogen line on mingw and linux, so your first 4 lines become a single command.

It was posted many times, that if I use git version I should always use ./autogen.sh b4 I do anything else.
And I found today that not running "make clean" can generate errors

I believe what he was saying is that if you use autogen.sh you do not need to run configure. You can put all the options after autogen.sh.

Code:

CFLAGS="-O2 -msse2" ./autogen.sh --enable-scrypt --without-libudev 
make clean 
make

Thx

lots faster, no double-configure

i.e. every time I post the linux link for 11.04 that's what I post at the end ... yeah the usual ... people don't read Tongue

-ck

legendary

Activity: 4088

Merit: 1631

Ruu \o/

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Hmm ok. As an aside, best share does show rejected shares or even shares not submitted if they're below the target. The reason for this is that there is no way of knowing what your best share is when you're solo mining.

The00Dustin

hero member

Activity: 807

Merit: 500

Quote from: Luke-Jr on December 19, 2012, 02:15:54 PM

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Fix for this is https://github.com/luke-jr/bfgminer/commit/bfab076d

Quoting for con, just in case.

Luke-Jr

legendary

Activity: 2576

Merit: 1186

Quote from: juhakall on December 19, 2012, 10:43:47 AM

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

Fix for this is https://github.com/luke-jr/bfgminer/commit/bfab076d

rav3n_pl

legendary

Activity: 1361

Merit: 1003

Don`t panic! Organize!

Quote from: sharky112065 on December 19, 2012, 01:05:58 PM

Quote from: rav3n_pl on December 19, 2012, 09:54:11 AM

Quote from: kano on December 19, 2012, 07:56:58 AM

rav3n_pl ... FYI ... you only need 3 lines to build cgminer... and it's the same on mingw - you can specify everything before make on the single autogen line on mingw and linux, so your first 4 lines become a single command.

It was posted many times, that if I use git version I should always use ./autogen.sh b4 I do anything else.
And I found today that not running "make clean" can generate errors

I believe what he was saying is that if you use autogen.sh you do not need to run configure. You can put all the options after autogen.sh.

Code:

CFLAGS="-O2 -msse2" ./autogen.sh --enable-scrypt --without-libudev 
make clean 
make

Thx

lots faster, no double-configure

sharky112065

sr. member

Activity: 383

Merit: 250

Quote from: rav3n_pl on December 19, 2012, 09:54:11 AM

Quote from: kano on December 19, 2012, 07:56:58 AM

rav3n_pl ... FYI ... you only need 3 lines to build cgminer... and it's the same on mingw - you can specify everything before make on the single autogen line on mingw and linux, so your first 4 lines become a single command.

It was posted many times, that if I use git version I should always use ./autogen.sh b4 I do anything else.
And I found today that not running "make clean" can generate errors

I believe what he was saying is that if you use autogen.sh you do not need to run configure. You can put all the options after autogen.sh.

PatMan

hero member

Activity: 924

Merit: 1000

Watch out for the "Neg-Rep-Dogie-Police".....

Quote from: rav3n_pl on December 19, 2012, 07:28:10 AM

I was time, when 64KB total ram+rom+video was enough to do great things. Now this is forgotten.
If I can make something smaller and still working - why not? Accesing to HDD is 1000x slower than ram, sometimes 1MB more space on pen or CD/DVD is need.
I made this bins for myself - I not need USB and/or FPGA and other stuff, just GPU.
There are alot of ppl that only mine and have no clue about compiling or setting up git or mingw on windows.
It is only up to them to use or not use my binaries. I`m putting then to skydrive to have them accesible from my other machine where I not have mingw.

That would be me, I'm one of those people....lol

juhakall

sr. member

Activity: 658

Merit: 250

After starting up 2.10.2 for the first time, I almost immediately got "Best share: 25", but no accepted shares for a while. Then I finally got an accepted share 4/4. Looks like the Best share display still isn't fixed, unless for some reason my target was above 25 (never been above 8 for me at BitMinter). Also, now Best share is at 207, even though all the accepted shares for this run are still on screen, and the highest is 55/4.

os2sam

legendary

Activity: 3586

Merit: 1098

Think for yourself

Quote from: rav3n_pl on December 19, 2012, 09:44:47 AM

Quote from: sharky112065 on December 19, 2012, 09:18:43 AM

Quote from: rav3n_pl on December 19, 2012, 07:28:10 AM

There are alot of ppl that only mine and have no clue about compiling or setting up git or mingw on windows.

I wrote windows-build.txt so anyone could compile a cgminer binary for Windows. It only takes 30 minutes or less to set up a build environment following the instructions provided. So I read that as "There are a lot lazy people that only mine and have not bothered to read the included documentation".

I`m sure they are Tongue

Murphy`s law about documentation: "NO ONE READS IT" Cheesy

"NO ONE READS IT", first.

rav3n_pl

legendary

Activity: 1361

Merit: 1003

Don`t panic! Organize!

Quote from: kano on December 19, 2012, 07:56:58 AM

rav3n_pl ... FYI ... you only need 3 lines to build cgminer... and it's the same on mingw - you can specify everything before make on the single autogen line on mingw and linux, so your first 4 lines become a single command.

It was posted many times, that if I use git version I should always use ./autogen.sh b4 I do anything else.
And I found today that not running "make clean" can generate errors

rav3n_pl

legendary

Activity: 1361

Merit: 1003

Don`t panic! Organize!

Quote from: sharky112065 on December 19, 2012, 09:18:43 AM

Quote from: rav3n_pl on December 19, 2012, 07:28:10 AM

There are alot of ppl that only mine and have no clue about compiling or setting up git or mingw on windows.

I wrote windows-build.txt so anyone could compile a cgminer binary for Windows. It only takes 30 minutes or less to set up a build environment following the instructions provided. So I read that as "There are a lot lazy people that only mine and have not bothered to read the included documentation".

I`m sure they are Tongue

Murphy`s law about documentation: "NO ONE READS IT" Cheesy

sharky112065

sr. member

Activity: 383

Merit: 250

Quote from: rav3n_pl on December 19, 2012, 07:28:10 AM

There are alot of ppl that only mine and have no clue about compiling or setting up git or mingw on windows.

I wrote windows-build.txt so anyone could compile a cgminer binary for Windows. It only takes 30 minutes or less to set up a build environment following the instructions provided. So I read that as "There are a lot lazy people that only mine and have not bothered to read the included documentation".

kano

legendary

Activity: 4634

Merit: 1851

Linux since 1997 RedHat 4

rav3n_pl ... FYI ... you only need 3 lines to build cgminer... and it's the same on mingw - you can specify everything before make on the single autogen line on mingw and linux, so your first 4 lines become a single command.

Topic: OFFICIAL CGMINER mining software thread for linux/win/osx/mips/arm/r-pi 4.11.0 - page 418. (Read 5806004 times)