Registering Electrum as default URI handler?

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Quote from: japerry on March 23, 2016, 03:12:43 AM

Quote from: Mitchell on March 23, 2016, 03:08:33 AM

Hmmmm, strange. It should work for Chrome as well. I'll look into it.

EDIT: It seems to be a Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=560809 I'll see if I can work around it or not. Sorry for the inconvenience caused.

Oh please don't apologize at all! The fact that the issue is being addressed is fantastic! I'd be more than happy to test any changes for you. Please let me know if I can be of assistance. BTW running Windoze 7 here.

If I have any changes to test, I'll let you know! I run W10 so that and W7 should cover everything. Tongue

japerry

sr. member

Activity: 306

Merit: 250

Quote from: Mitchell on March 23, 2016, 03:08:33 AM

Hmmmm, strange. It should work for Chrome as well. I'll look into it.

EDIT: It seems to be a Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=560809 I'll see if I can work around it or not. Sorry for the inconvenience caused.

Oh please don't apologize at all! The fact that the issue is being addressed is fantastic! I'd be more than happy to test any changes for you. Please let me know if I can be of assistance. BTW running Windoze 7 here.

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Hmmmm, strange. It should work for Chrome as well. I'll look into it.

EDIT: It seems to be a Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=560809 I'll see if I can work around it or not. Sorry for the inconvenience caused.

japerry

sr. member

Activity: 306

Merit: 250

Quote from: japerry on March 22, 2016, 05:53:39 AM

Quote from: Mitchell on March 22, 2016, 05:12:26 AM

Alright, my pull request has been accepted. If you download the latest Windows Installer (must be the Installer, it can't be the Standalone or Portable version) it will set the URI handler for "bitcoin:" to Electrum (and override the previous URI handler if it exists). Cheesy

If you use Google Chrome and just installed Electrum you might need to restart the browser/your computer.

Nice! Thanks!!

The good news is that it works great with Firefox! Yay! The bad news is that it doesn't work with Chrome. I've tried restarting Chrome and clicking on Shorena's test link and it does nothing.

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

No problem and enjoy!

japerry

sr. member

Activity: 306

Merit: 250

Quote from: Mitchell on March 22, 2016, 05:12:26 AM

Alright, my pull request has been accepted. If you download the latest Windows Installer (must be the Installer, it can't be the Standalone or Portable version) it will set the URI handler for "bitcoin:" to Electrum (and override the previous URI handler if it exists). Cheesy

If you use Google Chrome and just installed Electrum you might need to restart the browser/your computer.

Nice! Thanks!!

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Alright, my pull request has been accepted. If you download the latest Windows Installer (must be the Installer, it can't be the Standalone or Portable version) it will set the URI handler for "bitcoin:" to Electrum (and override the previous URI handler if it exists). Cheesy

If you use Google Chrome and just installed Electrum you might need to restart the browser/your computer.

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Pull request created.

shorena

copper member

Activity: 1498

Merit: 1499

No I dont escrow anymore.

Quote from: Mitchell on March 08, 2016, 09:10:16 AM

Guess I'll become an Electrum contributor! Will add the necassary changes to the file once I'm home. Tongue

Let me know if you need someone to test the installer.

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Guess I'll become an Electrum contributor! Will add the necassary changes to the file once I'm home. Tongue

shorena

copper member

Activity: 1498

Merit: 1499

No I dont escrow anymore.

Quote from: Mitchell on March 08, 2016, 08:01:44 AM

It's possible to create a Windows installer that does the Regedit stuff automatically using something like NSIS. I could write one that wraps around a portable Electrum version, but that isn't something you would want (a third party person making an installer for a portable program).

If I were you, I would ask the Electrum developers to create a specific installer for Windows that handles the Registry stuff.

Well, it looks like we have one here and interested. Electrum is using NSIS[1]. Do I see a new Electrum contributor on the horizon?

[1] https://github.com/spesmilo/electrum/blob/c86ef5e8b0dcebf1940a68e8857165e6e4768920/contrib/build-wine/electrum.nsi

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

It's possible to create a Windows installer that does the Regedit stuff automatically using something like NSIS. I could write one that wraps around a portable Electrum version, but that isn't something you would want (a third party person making an installer for a portable program).

If I were you, I would ask the Electrum developers to create a specific installer for Windows that handles the Registry stuff.

shorena

copper member

Activity: 1498

Merit: 1499

No I dont escrow anymore.

Quote from: ThomasV on March 08, 2016, 06:50:14 AM

Quote from: shorena on March 07, 2016, 05:46:28 AM

Its OS specific.

#1 hit win+r to open "run", enter regedit and confirm with ok.
#2 go to HKEY_CLASSES_ROOT\bitcoin\shell\open\command
#3 edit the (Standard) from whatever it is now to "C:\Program Files (x86)\Electrum\electrum.exe" "%1" (modify path if needed)

Edit: tested here -> http://213.165.91.169/

only works if electrum is alreay open

any idea how we could automate this with the installer?

Sadly not, but Multibit HD does it with the installer (I had to change it from Multibit HD to Electrum). I was not able to find the actual installer with the source though. This[1] sounds like its not published with the rest of the source.

[1] https://github.com/bitcoin-solutions/multibit-hd/blob/189ba7970d36226da75f55c850432e49c6529f3c/.gitignore#L26

ThomasV

legendary

Activity: 1896

Merit: 1353

Quote from: shorena on March 07, 2016, 05:46:28 AM

Its OS specific.

#1 hit win+r to open "run", enter regedit and confirm with ok.
#2 go to HKEY_CLASSES_ROOT\bitcoin\shell\open\command
#3 edit the (Standard) from whatever it is now to "C:\Program Files (x86)\Electrum\electrum.exe" "%1" (modify path if needed)

Edit: tested here -> http://213.165.91.169/

only works if electrum is alreay open

any idea how we could automate this with the installer?

japerry

sr. member

Activity: 306

Merit: 250

Quote from: shorena on March 07, 2016, 07:43:48 AM

Quote from: Mitchell on March 07, 2016, 06:12:39 AM

Shouldn't it be "T:\Electrum-BTC\electrum.exe %1"? I can't test this right now as I'm on a Mac. Grin

No its "path" "%1" for me and it works.

Didnt require a reboot. Maybe it works if you escape the " as here[1].

[1] https://bitcointalksearch.org/topic/m.880750

Hmm... Still no joy.. Oh well. I'll play with it some more.

shorena

copper member

Activity: 1498

Merit: 1499

No I dont escrow anymore.

Quote from: Mitchell on March 07, 2016, 06:12:39 AM

Shouldn't it be "T:\Electrum-BTC\electrum.exe %1"? I can't test this right now as I'm on a Mac. Grin

No its "path" "%1" for me and it works.

Didnt require a reboot. Maybe it works if you escape the " as here[1].

[1] https://bitcointalksearch.org/topic/m.880750

japerry

sr. member

Activity: 306

Merit: 250

Quote from: Mitchell on March 07, 2016, 06:12:39 AM

Shouldn't it be "T:\Electrum-BTC\electrum.exe %1"? I can't test this right now as I'm on a Mac. Grin

Not Sure. I found it in the registry and just modified the pointer to the executable.

Mitchell

copper member

Activity: 3948

Merit: 2201

Verified awesomeness ✔

Shouldn't it be "T:\Electrum-BTC\electrum.exe %1"? I can't test this right now as I'm on a Mac. Grin

japerry

sr. member

Activity: 306

Merit: 250

Quote from: shorena on March 07, 2016, 05:46:28 AM

Its OS specific.

#1 hit win+r to open "run", enter regedit and confirm with ok.
#2 go to HKEY_CLASSES_ROOT\bitcoin\shell\open\command
#3 edit the (Standard) from whatever it is now to "C:\Program Files (x86)\Electrum\electrum.exe" "%1" (modify path if needed)

Edit: tested here -> http://213.165.91.169/

only works if electrum is alreay open

Hmm.. Did what you said. Electrum is open. Nothing happened. Here's what I have in the registry entry:

"T:\Electrum-BTC\electrum.exe" "%1"

Do I need to reboot or something for it to take effect?

I'm using the portable version of Electrum on a encrypted drive.

shorena

copper member

Activity: 1498

Merit: 1499

No I dont escrow anymore.

Its OS specific.

#1 hit win+r to open "run", enter regedit and confirm with ok.
#2 go to HKEY_CLASSES_ROOT\bitcoin\shell\open\command
#3 edit the (Standard) from whatever it is now to "C:\Program Files (x86)\Electrum\electrum.exe" "%1" (modify path if needed)

Edit: tested here -> http://213.165.91.169/

only works if electrum is alreay open

Topic: Registering Electrum as default URI handler? (Read 1907 times)