Sighash | Bitcointalksearch.org

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: o_e_l_e_o on January 13, 2024, 09:54:50 AM

Been patched in the most recent version of Electrum

Yes, thanks. This fix appeared in the beta version a few weeks ago.

I'm glad this update was released before the Tails developers finally decide to put a new version of Electrum in their distributive, as a lot of people use it for cold storage, so flaws like this are very undesirable.

o_e_l_e_o

legendary

Activity: 2268

Merit: 18509

Quote from: igor72 on November 14, 2023, 08:51:09 AM

I reported.

Been patched in the most recent version of Electrum:

Quote from: https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

- add warnings and prompt users when signing txs with non-default sighashes (#8687)

satscraper

hero member

Activity: 714

Merit: 1298

Cashback 15%

Quote from: igor72 on November 14, 2023, 12:45:45 PM

Quote from: satscraper on November 14, 2023, 12:23:47 PM

Nice catch!

To check the response of Passport 2 I have created (with Sparrow) the testnet transaction, setting Sighash flag to None and tried to sign it via QR. Passport has read QR but refused to sign transaction flagged as SIGHASH_NONE

That's fine, but there should be an option somewhere in settings to enable signing of such transactions. Thanks!

It seems I have perused all available menu's opts , but didn't find the relevant one. I doubt whether I would ever need to sign transaction with SIGHASH flags other than SIGHASH_ALL. However, out of curiosity (both mine and yours) I've put the pertaining question in the official foundationdevices thread.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: satscraper on November 14, 2023, 12:23:47 PM

Nice catch!

To check the response of Passport 2 I have created (with Sparrow) the testnet transaction, setting Sighash flag to None and tried to sign it via QR. Passport has read QR but refused to sign transaction flagged as SIGHASH_NONE

That's fine, but there should be an option somewhere in settings to enable signing of such transactions. Thanks!

satscraper

hero member

Activity: 714

Merit: 1298

Cashback 15%

Quote from: igor72 on November 12, 2023, 08:46:39 AM

~

Nice catch!

To check the response of Passport 2 I have created (with Sparrow) the testnet transaction, setting Sighash flag to None and tried to sign it via QR. Passport has read QR but refused to sign transaction flagged as SIGHASH_NONE :

Quote from: satscraper

I should say, Passport 2 , done wisely.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: BlackHatCoiner on November 14, 2023, 08:02:43 AM

Has anyone reported this on either Electrum's or Sparrow's repo?

I reported.

BlackHatCoiner

legendary

Activity: 1512

Merit: 7340

Farewell, Leo

Quote from: o_e_l_e_o on November 14, 2023, 07:05:55 AM

Since the airgapped wallet does not know anything about which inputs to be used, then you will also need to copy across individual inputs and then manually craft your transaction since I don't know of any airgapped wallet which allows you to import individual inputs.

Indeed. You cannot import inputs in known wallet software via airgapped means (i.e., QR code). You can only sign unsigned transactions.

Quote from: o_e_l_e_o on November 14, 2023, 07:05:55 AM

As I said above, although Sparrow lets you chose a different SIGHASH to use, it doesn't actually show you which SIGHASHes were used once the transaction has been created.

Sparrow doesn't show you which SIGHASHes are used in a signed transaction, but it does show that information if you import an unsigned transaction. So, a solution would be to install Sparrow on your airgapped device, and before you sign a transaction, you can open it up with Sparrow to check.

Although, I do agree that simply displaying the SIGHASH in the preview is fairly simple and informative.

Edit: Sparrow does not show that sort of information for unsigned tx either. It is still better than Electrum to spot the 01 byte, which is the last byte of your input witness data.

Has anyone reported this on either Electrum's or Sparrow's repo?

o_e_l_e_o

legendary

Activity: 2268

Merit: 18509

Quote from: BlackHatCoiner on November 14, 2023, 04:02:31 AM

What if instead of creating the transaction there, you just copied the destinations and the payout amounts, and created the transaction in your airgapped device?

That becomes far more clunky and time consuming, as well as error prone. Since the airgapped wallet does not know anything about which inputs to be used, then you will also need to copy across individual inputs and then manually craft your transaction since I don't know of any airgapped wallet which allows you to import individual inputs.

Quote from: BlackHatCoiner on November 14, 2023, 04:02:31 AM

You can also just install a software that checks for your transaction's SIGHASH like Sparrow.

As I said above, although Sparrow lets you chose a different SIGHASH to use, it doesn't actually show you which SIGHASHes were used once the transaction has been created. So importing a signed transaction to Sparrow instead of Electrum does not solve this issue. The only way to know for sure at the moment is to manually examine the transaction data and check it uses 0x01 for SIGHASH_ALL on each input.

It would be a fairly simple change for the preview transaction screen on either wallet to display the SIGHASH type for each input next to that input.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: BlackHatCoiner on November 14, 2023, 04:02:31 AM

I see what you mean. So your problem is to verify of whether the "hot Electrum" is modified to insert SIGHASH_NONE. What if instead of creating the transaction there, you just copied the destinations and the payout amounts, and created the transaction in your airgapped device? That way, a malware can't have compromised your transaction anyhow unnoticed.

You can also just install a software that checks for your transaction's SIGHASH like Sparrow.

Yes.You can also just find the sighash byte in the raw transaction after the signature, it should be 01, not 02 or some other. But it is better that Electrum does it, not the user.

BlackHatCoiner

legendary

Activity: 1512

Merit: 7340

Farewell, Leo

Quote from: igor72 on November 14, 2023, 03:52:14 AM

This is all useless if the transaction is verified and signed on cold Electrum.

I see what you mean. So your problem is to verify of whether the "hot Electrum" is modified to insert SIGHASH_NONE. What if instead of creating the transaction there, you just copied the destinations and the payout amounts, and created the transaction in your airgapped device? That way, a malware can't have compromised your transaction anyhow unnoticed.

You can also just install a software that checks for your transaction's SIGHASH like Sparrow.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: BlackHatCoiner on November 14, 2023, 03:39:55 AM

A malware can do a host variety of things on a hot computer, from installing keyloggers and replacing your destinations with theirs, to seeming like signing your own transaction but when choosing to broadcast, signing and broadcasting theirs. They can even alter the cryptographic libraries so that it seems you are signing and broadcasting your own, and indeed it is true from a blockchain perspective, but they will know how to work out your private key afterwards.

This is all useless if the transaction is verified and signed on cold Electrum.

Quote

The last thing a malware will do is choose to give the coins to a miner by using SIGHASH_NONE.

Yes, but first the attacker will try to modify the transaction in the hope that the miner won't notice the sighash_none.

BlackHatCoiner

legendary

Activity: 1512

Merit: 7340

Farewell, Leo

Quote from: igor72 on November 14, 2023, 03:30:45 AM

You're right, but that's not the point. A malware can change this flag on a hot computer and the user will not notice it when signing the transaction, that's the danger.

A malware can do a host variety of things on a hot computer, from installing keyloggers and replacing your destinations with theirs, to seeming like signing your own transaction but when choosing to broadcast, signing and broadcasting theirs. They can even alter the cryptographic libraries so that it seems you are signing and broadcasting your own, and indeed it is true from a blockchain perspective, but they will know how to work out your private key afterwards.

The last thing a malware will do is choose to give the coins to a miner by using SIGHASH_NONE.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: pooya87 on November 14, 2023, 01:15:02 AM

You're right, but that's not the point. A malware can change this flag on a hot computer and the user will not notice it when signing the transaction, that's the danger.

pooya87

legendary

Activity: 3444

Merit: 10537

Quote from: igor72 on November 12, 2023, 10:09:26 AM

I created the transaction in Sparrow and signed in Electrum.

The import transaction feature is mainly there to be used with another Electrum instance (hot/cold wallet duo) which won't use other sighash types by default, you'll have to use an advanced feature through the console which means you already know what you're doing and there is no need for additional warning.

If you are using another tool to create and/or sign a transaction then it should also be assumed that you already know what you are doing and most importantly that you know what the risks of using that tool are. For example that other tool could be sending your coins to someone else's address or be setting the fee too high, etc.

In any case I'm for showing a notification when an uncommon sighash type is used regardless of whether it is risky or not. That way the warning/notification is simpler to implement.

seek3r

legendary

Activity: 1260

Merit: 1954

Quote from: igor72 on November 12, 2023, 12:49:01 PM

Thanks. I hope someone from the Electrum developers will notice this thread.

You might wanna create a new issue on their official Github about this "bug". Thats where you will probably get the most attention from the developers.
Make sure that you go into quite a lot of detail on the subject otherwise they tend to be overlooked. Wink

I would otherwise also like to report this but I don't want to decorate myself with the feathers of others and after all - you noticed that bug.
If you don't have the time or the courage, thats another matter ofc.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: o_e_l_e_o on November 12, 2023, 10:29:46 AM

I've just been testing this locally on testnet, and igor72 is absolutely right.

Thanks. I hope someone from the Electrum developers will notice this thread.

BTW multisig wallets can be vulnerable as well.

o_e_l_e_o

legendary

Activity: 2268

Merit: 18509

I've just been testing this locally on testnet, and igor72 is absolutely right.

Although an unsigned raw transaction does not contain any information about the SIGHASH, if you export the transaction from Sparrow as a .psbt and then import it to Electrum, then whatever SIGHASH you have selected in Sparrow will be preserved and Electrum will sign the transaction with no warning or notification otherwise.

And indeed, once you import that signed transaction back in to Sparrow, Sparrow also does not give any indication of which SIGHASH type(s) was used. The only way to know for sure in this scenario is to examine the transaction data yourself and to know what you are looking for. This does seem like a potential attack method to me.

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: BitMaxz on November 12, 2023, 09:47:10 AM

What do you mean by "without any notification" you mean Electrum does not give you a notification about your transaction if it was sent or got confirmed?

There is no notification that sighash is not the default SIGHASH_ALL.

Quote

How did you change the hashtype of the transaction on Electrum? I can't seem to find where you change the hashtype in Electrum.

I created the transaction in Sparrow and signed in Electrum.

BitMaxz

legendary

Activity: 3234

Merit: 2943

Block halving is coming.

Quote from: igor72 on November 12, 2023, 09:20:57 AM

I'm sorry, I misspoke. I meant to say that Electrum is capable of signing a transaction with SIGHASH_NONE without any notification.

What do you mean by "without any notification" you mean Electrum does not give you a notification about your transaction if it was sent or got confirmed?
How did you change the hashtype of the transaction on Electrum? I can't seem to find where you change the hashtype in Electrum. By default it uses SIGHASH_ALL read the wiki below for an explanation.

- https://en.bitcoin.it/wiki/OP_CHECKSIG#Hashtype_SIGHASH_NONE

More explanation here https://bitcoin.stackexchange.com/questions/4213/what-is-the-point-of-sighash-none

igor72

legendary

Activity: 1820

Merit: 1972

Crypto Swap Exchange

Quote from: BlackHatCoiner on November 12, 2023, 09:02:58 AM

Which version did you use? I just created a transaction in 4.3.2 and by default it has SIGHASH_ALL.

I'm sorry, I misspoke. I meant to say that Electrum is capable of signing a transaction with SIGHASH_NONE without any notification.

Topic: Sighash (Read 233 times)