I've been enjoying the ColdCard, and I wouldn't hesitate to recommend one. The price being roughly twice that of a Trezor One requires an assessment of the ColdCards additional features, and determining if they're worth the value. That's really a personal decision. As for an air-gapped hardware wallet, it's been working great for me and I've gotten some use out of the additional seed and private key features. It's really quite a sophisticated device, despite having some real world flaws.
And you should take the debate about the licensing with a grain of salt as well. The source code is transparent and available for review, but the licensing prohibits others from profiting from it or using it in a competing device, hence "not open-source."
I've used a few brands of hardware wallets, including both models offered by Trezor, and so far I have to say the ColdCard is my favorite. I did receive a Foundation Passport a few days ago, but I haven't fired it up yet. I wouldn't be surprised if the Passport becomes my new favorite, but again one needs to evaluate the value of any wallet he chooses. My problem is that I have the "collecting" bug, so the more the merrier.
Thanks a bunch