Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 11. (Read 129207 times)

Ok thanks.

The last sell offer is
1b8572009435e554a68fc640f43efa50c9117f6881813ae56eab5b10f9b3fd53
For  0.01 tmsc

Your reserve is 0.029 tmsc
https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6¤cy=TMSC

It should be 0.01 since we can only have 1 seller offer.

My work in February:

All my work on the distributed exchange spec, code, and design:

* Implemented new full HTML5 wallet in demo.masterchain.info: https://demo.masterchain.info/wallet.html (users add addresses to wallet from address pages.) Currently supports >20 usability and security features and functions that facilitate DEx trading. Find detailed list in the next section.

* Created quick user guide for the wallet available at: https://demo.masterchain.info/Masterchain_wallet_01.pdf Please read the user guide (it is just page) as it includes the full description of my main body of work.

* Implemented HTML5 transactions form fully integrated with the wallet (import addresses and private keys from wallet) required for DEx testing.


All my work on dEX testing:

* I tested several standard DEx transaction dev.masterchain.info from the point of view of the wallet user: Initiated transactions from the wallet, verified that the transactions appear in the transaction history list of the wallet and reflected in the balance shown in the wallet.

* I continuously test the wallet of https://demo.masterchain.info/ on an array of >30 combinations of devices, screen sizes, resolutions and web browsers including 2 smart phones (iOS and Android) and 3 tablets. As also the developer of the wallet I never move forward with design and implementation directions that cannot be scaled to all screen sizes and be usable with both touch screens and mouse modes.

Other work I would like considered for the "General Innovation" bounty:

Started to investigate (working on a usable prototype) an adaptation of the HTML5 web wallet into a standalone Android application (following a direct request from management) that can be executed directly without browser. I am using control and it is going well (Started on the 28th of February.)

Bitoy,

You can visit the transaction page on:
https://masterchain.info/selloffer.html?tx=8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741¤cy=TMSC
and see that "Depracated Sell Offer" means that it was replaced by an updated sell offer. Just follow the link of "Updated by sell offer" recursively.
Accepts which were done before the update are valid and can be paid (and it looks that the two were paid).

Grazcoin,

For 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb

Our difference is this tx
20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e

https://masterchain.info/simplesend.html?tx=20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e¤cy=MSC

In your site is says invalid because balance is too low.

Here is the sequence

2/19/2014 5:45:20 PM sell offer 44.80423511    0.01792169   44.78631342   1   20   .0002.  fdebcf
I posted a sell 1000 tmsc.  Since I only have 44.80423511 tmsc the system marked this as my reserves.

2/22/2014 4:54:47 PM. purchased 3.12345678 from 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV
Tx 0deafadbaebc770b9467305bfef36b2df11d4b60070f31b3a731c5d348c6381f
 this is a purchase and not included in the reserve

2/25/2014 5:22:56 PM  simple send 2 tmsc. 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV    tx 20f6bc
I then sent 2 tmsc which is valid bec. it is not covered by sell offer.

Zathras,

For 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6

This tx has btc desired = 0 which is invalid.
786bc231878df369c6c5f14fe795d5b7623148357d77558578c5a3b28b35584a

It therefore makes this sell offer still open .
1b8572009435e554a68fc640f43efa50c9117f6881813ae56eab5b10f9b3fd53

Mymastercoins.com updated and reparsed. Differences


 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6   MCHAIN=0.053          MCHEST=0.082             MM=0.072
 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV   MCHAIN=45.498         MCHEST=47.38688888  MM=38.88135379
 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=3.00124938 MCHEST=1.11111112    MM=2.2345679
 1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S MCHAIN=0.01            MCHEST=0.01               MM=0.009

Zathras,

Please check
https://masterchest.info/lookupadd.aspx?address=1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S
Current Final Balance .01

This transaction is invalid because "BTC Desired" is 0
d063437a4735b3fdb1f6d44af745257b193ce1acffe32b80457d502c5bc65635

The Tx belos is therefore still  valid
a116be62025ad134f6e071605a577d3e5fb2c8d8e7a86068a520383b1c00b3e3
Sell offer is 0.001

Final Balance is 0.009  (0.01 - .001 )

Grazcoin,

In Tx
8b2deeb03c2590bbc6698ab3d663eb920e8bb7e89437a7984a54b8d0154d6741
It says "Depracated Sell Offer"   What does this mean?

https://masterchain.info/Address.html?addr=1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6¤cy=TMSC


This is tx difference in address 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6.   

Only 3 Addresses left for consensus =)   (Mymastercoins wil be updated today, again reparsing everything.)

MM=0.082 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHAIN=0.053
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHAIN=45.498
MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=3.00124938

MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=1.11111112
MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=47.38688888

1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV


8708d411b92bb5741c2219452931a849c2e312906ec51f18e8499dcf9e1377eb
Valid sell offer for 3 tmsc

ecfd97ed2b4dce3fc3a3e47b65fa3cd4cbf8f8d0d4e15a7966c38058576a5707
Payment for 3 tmsc from 1BK


The new sell offer below is valid in mymastercoins but invalid in masterchain. I think it should be valid since the previous sell offer was filled.

7be299b8e934268aefadb904bf5e7e64a0f5795009447118de3e0040eee00454
Version 1 new sell offer

If the tx above is valid, the tx below should be valid also because it now has a prior sell offer.

464317c3156108e33d3cb08b455fbc126055c5efb4bc23c91a1237f64816274c
Masterchain no prior offer. 


Masterchest invalidates simple send from 1Bk to 1EQ
20f6bc00fe792a063021f24b7194ceab9c23afa457a126ab2164edf63f39083e

Ok will invalidate sell offers with bitcoin desired = 0

you are right.
I will update that.

Zathras,

I am checking the parsing of the address 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV
It seems that for the following sell offer:
https://masterchest.info/lookuptx.aspx?txid=ab68bf2b0cd7fcd1f5acf03b286d565016335448c68737ba39600968b998cd9e
masterchest misses the accept.
This accept exists on masterchain and mymastercoins:
https://masterchain.info/sellaccept.html?tx=68f8f0d91f7a10289e8cf5efb98a95d3d1850f1f1df7307c188858bd59e7b4b5¤cy=TMSC
http://mymastercoins.com/Default.aspx?txid=68f8f0d91f7a10289e8cf5efb98a95d3d1850f1f1df7307c188858bd59e7b4b5

any reason?

I have submitted my work summary, but I got no feedback/indication that it really arrived to its destination.
Has it?

Grazcoin

Hey Guys,

I think you still need to invalidate the sell offers from 1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon - the bitcoins desired field is zero and the spec says it must be at minimum 1.

Thanks
Zathras

May have taken 5-10 minutes to update - seems good now   Thanks!

Bitoy,
When will the fix get to the main server?
Can you give the address of the test server?

I want to see what differences between us are left after that fix:
https://masterchain.info/general/TMSC-difference.txt

I've update jaddress.aspx but the consensus still sees 3E-08.

After removing the overpayment option (in the Test server):

Only 3 Differences with MasterChain

MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHAIN=45.498
MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=3.00124938
MM=536.90527669 13NRX88EZbS5q81x6XFrTECzrciPREo821 MCHAIN=526.90527669


Only 6 Differences with MasterChest
Note 3 are almost the same only .00000001 difference

MM=38.88135379 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=49.12022221
MM=2.2345679 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=30.91534621
MM=0.700111 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX MCHEST=0.70458333
MM=4.01088888 1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq MCHEST=4.0108889
MM=0.09886999 1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon MCHEST=0.09887
MM=0.082 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHEST=0.08199999

Zathras your the sell offer below in masterchest is invalid.

03597f0bc804ecc355b2c4344cd1526c51209f9e3efa6d62192ec4dd923755e6

I think it is valid because if a seller sells more than his number of coins it is assumed he is selling all of it.


Ps.  Will fix the consensus E number notations.