Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 12. (Read 129207 times)

Bitoy,

This one's bugging me in the real MSC consensus check, your data is correct but any chance you can avoid using E numbers/notation? It makes my consensus system think there is a mismatch.


Thanks

Thanks guys

On the overpayments - seems we're both correct - yet another reason to avoid overpayments (technically that same bitcoin payment could be for an MSC value of 0.01088888 to 0.01088892 - all round to requiring a bitcoin payment of 0.00217778).  I've replied on the dev list but TL:DR I've added my support for removing overpayment support entirely.

The reason for invalidation is on the masterchain.info link you supplied, and it says:
new zero sell offer (was 50.0).

It means that at the time of the sell offer creation, there was a zero balance which means causes a zero sell offer.
Zero amount sell offers are invalid.

Zathras,

It seems J.R. agreed with me that we should disable this feature of over payment.

Repeating J.R. on the mailing list:

The over-payment logic has been there from the beginning (it's not new),
and is another annoyance which only affects BTC/MSC exchange (can't overpay
when buying GoldCoin with MSC, for instance). I figured if the buyer
overpaid and there were still coins for sale, why not give them to the
buyer? But, now I see why not.

Grazcoin, you make a very convincing set of arguments that we should not
count overpayments, especially in regards to complexity, which we all hate.
Bitoy and Zathras, can you guys confirm that "All implementations currently
work with the assumption that over payment is simply a buyer's mistake and
gives him no benefits."?

Assuming that is true, I'll just go update the spec to disable
over-payments entirely. It's obviously not core to what we are doing, and
we might as well make things simpler.

Simplicity is our biggest advantage over our alt-chain competitors, and
this is a small opportunity to increase our lead in that area.

If you guys ARE handling over-payments currently, I hope it is not too
difficult to simply disable that code?

Thanks!

-J.R.



On Fri, Feb 28, 2014 at 11:57 PM, <
[email protected]> wrote:

> I suggest to change the spec that over payments do not increase the amount
> purchased for the following reasons:
>
> If a user sees that the updated (more expensive) offer got already
> accepted, he could snap the offer by overpaying.
>
> The reserved amount kept on the address after an update must include then
> the whole previous sell offer at least until all accepts to original offer
> expire.
>
> The complexity is one magnitude higher, and the gain is some doubted
> feature/behaviour that users would not expect, and suspect that it is a
> bug, as it exists no where in the finance world.
>
> The sell offer update with 2 versions feature introduced enough complexity
> which still prevents us from consensus, so please do not add any more. We
> may have to postpone the 15.3.
>
> All implementations currently work with the assumption that over payment
> is simply a buyer's mistake and gives him no benefits.
>
> Grazcoin



But:
For the tx you mention, I don't think it got over paid.

The accept:
https://masterchain.info/sellaccept.html?tx=36f191348998adb993a4d2e4041a0aeb2cc108521d1a48a04c484baa9a1d3216¤cy=TMSC
The sell offer:
https://masterchain.info/selloffer.html?tx=effcb1a90f15b39ef2295d8b1d5b3fa5c4a156936b5cfcb770ca68ac1e7ace0e¤cy=TMSC
The payment:
https://masterchain.info/btcpayment.html?tx=0b77033abe7d9c2c06120d5fbd3708bba4a8da39989c9431704c9fd95412d97a¤cy=TMSC
or on blockchain:
https://blockchain.info/tx/0b77033abe7d9c2c06120d5fbd3708bba4a8da39989c9431704c9fd95412d97a

Amount accepted 0.01088888
Price per coin    0.2 ฿/TMSC
payment expected = 0.01088888*0.2=0.002177776 rounding to 8 decimal digits 0.00217778
actual payment is exactly 0.00217778 to 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb

Looks like a valid sell offer
6784b73048de3ab36c08ee06897be92ccb20f9b288345f96b0681cbc5b014ad4

Invalid in Masterchest
Invalid Masterchain
https://masterchain.info/selloffer.html?tx=6784b73048de3ab36c08ee06897be92ccb20f9b288345f96b0681cbc5b014ad4¤cy=MSC

After adding the overpayment fix, reparsing my test server.   I got the following differences

Getting shorter =)

MM=4.11111112 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHAIN=6.12345
MM=37.00681057 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHAIN=35.37455
MM=1 1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ MCHAIN=0
MM=4.0108889 1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq MCHAIN=4.01088888
MM=0.70458333 17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX MCHAIN=0.700111

Comparison Completed
MM=4.11111112 1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb MCHEST=30.91534621
MM=37.00681057 1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV MCHEST=49.12022221
MM=0.082 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 MCHEST=0.08199999
MM=0.09886999 1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon MCHEST=0.09887


Will try to check each one tomorrow.

https://blockchain.info/tx/0b77033abe7d9c2c06120d5fbd3708bba4a8da39989c9431704c9fd95412d97a

The amount sent is 0.00217778.   You missed the last digit.

Edit

I should have paid  0.0002177776. But since max is 8 digit. It (my wallet) rounded off to 0.000217778.

If Someone overpaid.   Should we

credit the overpayment
cancel over payment

For me I'm leaning towards canceling since I really wanted to buy only 0.0188888.  It's just that I can't pay the exact amount because of the rounding limit

But the spec says

You must send the appropriate amount of bitcoins before the time limit expires to complete the purchase. Note that you must send the bitcoins from the same address which initiated the purchase. If you send less than the correct amount of bitcoins, your purchase will be adjusted downwards. The remaining coins will be added back to those available in the Sell Offer if it’s still active. If you send more than the correct amount of bitcoins and the Sell Offer has more coins still available your order will be adjusted upwards.

So I'll follow the specs.   Adjusted upwards because the seller has more coins to sell.

0.01088890

For address 1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq, in transaction 36f191348998adb993a4d2e4041a0aeb2cc108521d1a48a04c484baa9a1d3216 this is not a rounding error - from my understanding the coins bought value is 0.01088890 rather than the 0.01088888 you guys have.

Coins bought is based on bitcoin payment even if over the originally accepted amount, as long as those extra coins are available (and they were in this case).  This bitcoin payment was for 0.0021777 BTC, multiplied by the unit price of 0.2 gives us 0.01088890.

Hope that makes sense

Perfect - thanks for addressing so quickly.  I'll modify the state engines for DEx to allow zero fees.


As Dexx mentioned, append ¤cy=TMSC (case sensitive from what I've found).  Couldn't find a way to work it through the UI.

Thanks
Zathras

https://masterchain.info/Address.html?addr=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV¤cy=TMSC

I sent the transactions for these 2 addresses and below is the trail of how I got the balance

http://mymastercoins.com/viewaddresstrans.aspx?address=1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb
http://mymastercoins.com/viewaddresstrans.aspx?address=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV


Some strange trans sent is a 1000 tmsc sell offer although address has only a few tmsc.  According to specs it is valid and assumed that the seller is selling all of it.

I'm currently checking zathras trans.

Graz,
How can I see the test msc transactions?  I tried
https://masterchain.info/Address.html?addr=1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV

But only msc is listed

Yeah, 0 required fee is fine. It's up to the seller. The only need for the fee is when somebody is trying to attack the system with spam to gum up the works, so at times when things are flowing smoothly the minimum fee might not even be needed.

Hey Graz,

Quick note on one of these - I sent an email around:
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.09886999; mymastercoins 0.09886999; masterchest 0.09887;
Sent 5 sell offers, all of them invalid because there is no amount of bitcoins desired on any of them (ie they're all selling 0.00000001 TMSC for zero).  
Spec says this value has a minimum value of 1.  Thus all those sells are invalid.

Some others will be affected by the decision on minfee (as I currently invalidate a zero value).  Graz & Bitoy I believe are for allowing zero values for minfee, Marv suggested dust but as Graz pointed out cross purposes there.  I believe the bitcoin devs are going to be lowering default fees to so we need to factor that in.

J.R. could you make a quick call on this so we can move on?  Simple question, can minimum fee in sell offers be zero valued?

Thanks guys
Zathras

We have consensus on MSC, but with TMSC there are still some differences.
I mark with color the one which is different from the others.
There are 2 addresses where the values are totally different.
Except for this:
masterchain - 1 miss
mymastercoins - 3 misses
masterchest - 5 misses

TMSC consensus check at 28 Feb 2014 22:40:22 GMT
14Q2NNiF5YzDZCjo7vrBuHdbZcmHRJyW3j: masterchain 0.315; mymastercoins 0.308; masterchest 0.315;
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6: masterchain 0.082; mymastercoins 0.089; masterchest 0.08199999; (+ rounding problem?)
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb: masterchain 6.12345; mymastercoins 2.2345679;  masterchest 16.91534621; (all different)
15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd: masterchain 70.0; mymastercoins 70.0; masterchest 220.0;
1QFWodNASZv8KRHnhypKaMys5CGRg7GrFQ: masterchain 0.0; mymastercoins 1.0; masterchest 1.0;
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.09886999; mymastercoins 0.09886999; masterchest 0.09887;
1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq: masterchain 4.01088888; mymastercoins 4.01088888; masterchest 4.0108889; (rounding problem?)
1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV: masterchain 35.37455; mymastercoins 38.88135379; masterchest 49.12022221; (all different)
17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX: masterchain 0.700111; mymastercoins 0.700111; masterchest 0.70458333;
1gYs2kC58J7aRBRJ7CYqysBpYoT7b5i8H: masterchain 50.0; mymastercoins 0.0; masterchest 50.0;
13NRX88EZbS5q81x6XFrTECzrciPREo821: masterchain 536.90527669; mymastercoins 536.90527669; masterchest 555.90527669;

The end of February is here. If you have worked on any element of our distributed exchange, engaged in testing, worked on the spec, laid the groundwork for smart property, or did something nifty for the project you'd like to be considered for the general innovations bounty, please fill out this form:

https://docs.google.com/forms/d/12RJqahjVjwRi2xXHKbhJurb4d7uWK21ZxD7EZIlMzuI/viewform

YOUR WORK SUMMARIES ARE DUE WITHIN 5 DAYS (3/6/2013 0:00:00 GMT) to qualify for bounty payout. Please do this early, and do it well, to ensure your maximum possible payout.

Thanks!

FYI

BITCOIN TRANSACTION MALLEABILITY AND MASTERCOIN by Peter Todd

http://blog.mastercoin.org/2014/02/27/transaction-malleability-and-mastercoin/

Consensus update:

MSC consensus exists between masterchain and masterchest:
https://masterchain.info/general/MSC-difference.txt

MSC consensus check at 27 Feb 2014 13:33:12 GMT
1DYb5Njvcgovt9gUMdMgYkpaQjAEdUooon: masterchain 0.0; mymastercoins 0.00014118; masterchest 0.0;
1PVWtK1ATnvbRaRceLRH5xj8XV1LxUBu7n: masterchain 0.00011111; mymastercoins 0.00022222; masterchest 0.00011111;
1MaStErt4XsYHPwfrN9TpgdURLhHTdMenH: masterchain 18421.886487; mymastercoins 18421.8862347; masterchest 18421.886487;
1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P: masterchain 11214.1127123; mymastercoins 11214.594834; masterchest 11214.1127123;

TMSC consensus got *much* closer (taking out mymastercoins, as the last fix is not yet deployed):

TMSC consensus check at 27 Feb 2014 13:17:04 GMT
1CKPYQPiVKMBEHqWco9sNNLNeTCjGSxfrn: masterchain 2.0; masterchest 0.0;
1B4dzdSTt8p1qfMba4MTPUvABDXDYTHT2S: masterchain 0.01; masterchest 0.0;
17RVTF3vJzsuaGh7a94DFkg4msJ7FcBYgX: masterchain 0.500611; masterchest 0.700111;
15QBPtyFR76ak2NvdfKbgYNp7HtB3tbtRd: masterchain 210.0; masterchest 70.0;
1EqTta1Rt8ixAA32DuC29oukbsSWU62qAV: masterchain 41.47875062; masterchest 48.98688888;
16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN: masterchain 2.6663; masterchest 2.9643;
18xEZx3po1iJWP5H2aM3Do11dCGQyaebnT: masterchain 0.2; masterchest 0.0;
1BKpa19m5Xy9SvSzC5djPWtCfbuynSDwmb: masterchain 0.01924938; masterchest 43.91422223;
13NRX88EZbS5q81x6XFrTECzrciPREo821: masterchain 555.90527669; masterchest 516.90527669;
13Km3M4qXJ1sx7nXzMfh7nqvowhzhJfxHY: masterchain 1.0; masterchest 0.0;

Part of the rules are:


It seems that the 300 BTC bounty now splits over more subjects (e.g. web wallets, graphical design, RBBs(?)), leaving for the DEx a smaller bounty.
A more fair approach would be a separate bounty for new subjects, while keeping the original DEx bounty as is.
In any case, it should be clear what is covered under the new rules and which percentage gets any subject (as obviously the focus of the contest has changed).

From the dev mailing list:


The rules of the contest have not changed, and you should review them (OP of this thread) before using the forms.

This could be caused by registration through VPN (Anti Spam filter), you are accepted now.