300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 35.

grazcoin

sr. member

Activity: 284

Merit: 250

Quote from: Tachikoma on November 27, 2013, 02:59:55 PM

Quote from: dacoinminster on November 27, 2013, 02:56:46 PM

Guys - this is yet another example of a spec-interpretation issue with more than one right answer. I originally did not intend MSC messages to count as BTC payments for purchases, but if that makes things simpler, then I'm ok with that. However, keep in mind also that we want to keep the user interface simple, and these mini-purchases might confuse people.

As you know, we're working out the details of hiring some of you full-time. Depending on how that works out, one of you will probably be in charge of coordinating these discussions and making decisions when it's not too controversial. I'll get involved on the controversial ones

I'm guessing that's our final vote. Grazcoin I'm going to assume you have no problems with discarding these payments so we can move on!

discard. move on.
if a tx has some type (simple send, sell, accept), it is not a payment.

Tachikoma

hero member

Activity: 938

Merit: 1000

Quote from: dacoinminster on November 27, 2013, 02:56:46 PM

Guys - this is yet another example of a spec-interpretation issue with more than one right answer. I originally did not intend MSC messages to count as BTC payments for purchases, but if that makes things simpler, then I'm ok with that. However, keep in mind also that we want to keep the user interface simple, and these mini-purchases might confuse people.

As you know, we're working out the details of hiring some of you full-time. Depending on how that works out, one of you will probably be in charge of coordinating these discussions and making decisions when it's not too controversial. I'll get involved on the controversial ones

I'm guessing that's our final vote. Grazcoin I'm going to assume you have no problems with discarding these payments so we can move on!

dacoinminster

legendary

Activity: 1260

Merit: 1031

Rational Exuberance

Guys - this is yet another example of a spec-interpretation issue with more than one right answer. I originally did not intend MSC messages to count as BTC payments for purchases, but if that makes things simpler, then I'm ok with that. However, keep in mind also that we want to keep the user interface simple, and these mini-purchases might confuse people.

As you know, we're working out the details of hiring some of you full-time. Depending on how that works out, one of you will probably be in charge of coordinating these discussions and making decisions when it's not too controversial. I'll get involved on the controversial ones

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: Tachikoma on November 27, 2013, 04:58:00 AM

I would say yes. It's basically free MSC for User B. Why not give it.

It's a side effect (given that its a good one for the buyer).

But As Zathras pointed out it will create unintented micro transaction bloat.

Tachikoma

hero member

Activity: 938

Merit: 1000

Quote from: zathras on November 27, 2013, 05:07:01 AM

Quote from: Tachikoma on November 27, 2013, 04:04:37 AM

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

Hehe that gave me a chuckle

every time I see you post to 'BitBoy' I keep wondering if I should point that out Tongue

I wish you did, now I feel like an ass :p

Quote from: zathras on November 27, 2013, 05:11:13 AM

Quote from: Bitoy on November 27, 2013, 04:57:00 AM

Quote from: Tachikoma on November 27, 2013, 04:04:37 AM

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

It's Bitoy. (Bitboy sounds good also

Here is my 2 cents
To keep it simple transactions should not be treated as payment.

consider this example.

1. User A sends a sell offer
2. user B sends a purchase offer to User A
3. User B changes his mind and sends another purchase offer to User A

Will transaction 3 be considered a payment for transaction 2?

Quote from: Tachikoma on November 27, 2013, 04:58:00 AM

I would say yes. It's basically free MSC for User B. Why not give it.

Would this not result in a bunch of unintended 'micro' transactions of 0.00000### MSC?

Yes, it already did in my implementation. My implementation of sorting through the money is pretty dumb. That part of the code knows nothing about Mastercoin data or what it looks like. So I can't right now check if it's a possible Mastercoin transaction.

I agree that it's probably cleaner to reject these 'micro transactions' though. Unless somebody can think of a reason to do not do it let's say we don't allow these payments. Grazcoin, if you could chime in that would be great.

zathras

sr. member

Activity: 266

Merit: 250

Quote from: Bitoy on November 27, 2013, 04:57:00 AM

Quote from: Tachikoma on November 27, 2013, 04:04:37 AM

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

It's Bitoy. (Bitboy sounds good also

Here is my 2 cents
To keep it simple transactions should not be treated as payment.

consider this example.

1. User A sends a sell offer
2. user B sends a purchase offer to User A
3. User B changes his mind and sends another purchase offer to User A

Will transaction 3 be considered a payment for transaction 2?

Quote from: Tachikoma on November 27, 2013, 04:58:00 AM

I would say yes. It's basically free MSC for User B. Why not give it.

Would this not result in a bunch of unintended 'micro' transactions of 0.00000### MSC?

zathras

sr. member

Activity: 266

Merit: 250

Quote from: Tachikoma on November 27, 2013, 04:04:37 AM

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

Hehe that gave me a chuckle

every time I see you post to 'BitBoy' I keep wondering if I should point that out Tongue

Actually at the current time I do the same as Bitoy; Bitcoin transactions with an output to Exodus but no Mastercoin data go into an 'unknown' table which I subsequently search for payments. If it's ~~got Mastercoin data~~ a decodable Mastercoin transaction it's not looked at as a payment.

The spec doesn't call for payments & Mastercoin transactions in the same Bitcoin transaction, but it doesn't specifically exclude it either so I guess it's another topic we should get consensus on and lock into the spec.

I'm ambivalent on this really, it's not much work to adapt to allow it. Haven't had time to think about future implications though.

Thanks!

Tachikoma

hero member

Activity: 938

Merit: 1000

I would say yes. It's basically free MSC for User B. Why not give it.

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: Tachikoma on November 27, 2013, 04:04:37 AM

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

It's Bitoy. (Bitboy sounds good also

Here is my 2 cents
To keep it simple transactions should not be treated as payment.

consider this example.

1. User A sends a sell offer
2. user B sends a purchase offer to User A
3. User B changes his mind and sends another purchase offer to User A

Will transaction 3 be considered a payment for transaction 2?

Tachikoma

hero member

Activity: 938

Merit: 1000

Thanks for your results Bitoy (Seriously was your username always Bitoy? I always read it as BitBoy, sorry about that.) they are very helpful.

Did we establish that Mastercoin messages that were send after an Purchase Offer has been opened couldn't be used as funds for such offers?

I don't like discriminating payments based on their possible intend, you are sending somebody funds, so why shouldn't these count? What do you guys think?

Bitoy

sr. member

Activity: 449

Merit: 250

Here are the parsing results based on MyMastercoins v1.01

Valid Transactions

Code:

Hash: 339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, AmountBought: 9.39900000 MSC, PaymentTransactions: [66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745]

Hash: 4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99, AmountBought: 0.10100001 MSC, PaymentTransactions:[cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d]

Hash: baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b
Can't be accepted as payment because it is a transaction.
The transaction is invalid because
Seller 1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj has no more coins for sale. (Seller still has 10 MSC available but it is reserved for another buyer at that time)
Date: 11/17/2013 4:03:10 PM

Invalid transactions.

Code:

Hash: fffbde998c925d159c13020bb4e9c6d71cf1553e75624aeb174488102b7b0c0c, AmountBought: 0.00030000 MSC, PaymentTransactions: [7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa]

Note: 7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa is a purchase transaction not valid as payment.

Hash: 57e8880da36ca97456828900b66c4699617875c3826ce263ab9a2d7572fe0885, AmountBought: 0.00030000 MSC, PaymentTransactions: [23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4]

1EAuHj8Z6rTCHPxXfaGzzPsZevC2mg1XAj has no more coins for sale. (Seller still has .5 MSC but it is already reserved for another Buyer)

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: Tachikoma on November 26, 2013, 04:20:28 AM

Code:

339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6
invalid transaction

4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99
Invalid transaction

Why do you consider those invalid?

I found a bug in my implementation. Will investigate this again and report asap.

prophetx

legendary

Activity: 1666

Merit: 1010

he who has the gold makes the rules

Quote from: Tachikoma on November 24, 2013, 08:00:39 AM

We already have #mastercoin on freenode

ah great to hear that (should have checked lol)

Tachikoma

hero member

Activity: 938

Merit: 1000

Code:

339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6
invalid transaction

4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99
Invalid transaction

Why do you consider those invalid?

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: Tachikoma on November 25, 2013, 11:03:48 AM

Let me put it in the following format for easier comparison: Payment offers and their attached data and bitcoin payments.

Code:

Hash: fffbde998c925d159c13020bb4e9c6d71cf1553e75624aeb174488102b7b0c0c, AmountBought: 0.00030000 MSC, PaymentTransactions: [7d4d70eac81d514e30ce8762434b91cd1d1650bf492779a3992bbd6f0c2043aa]

Hash: 57e8880da36ca97456828900b66c4699617875c3826ce263ab9a2d7572fe0885, AmountBought: 0.00030000 MSC, PaymentTransactions: [23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4]

Hash: 339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, AmountBought: 9.39900000 MSC, PaymentTransactions: [66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745]

Hash: baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b, AmountBought: 0.10130000 MSC, PaymentTransactions:[339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6, cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d]

Hash: 4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99, AmountBought: 0.10130000 MSC, PaymentTransactions:[cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d, baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b]

Here is my report. If it is wrong, please advise

23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4
Invalid Transaction.
Date:   11/17/2013 9:21:12 PM
Remarks:   Seller 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 doesn't have enough MSC to send.

23f77b6caedd9d5ebbdc56f0d688bee0cf5fd41d19f2aba71f989237326da4b4
Invalid Transaction.
Date:   11/17/2013 9:21:12 PM
Remarks:   Seller 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 doesn't have enough MSC to send.


66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745
Invalid Transaction.
Date:   11/17/2013 5:44:30 PM
Remarks:   Buyer Payment: Purchase confirmation not found or payment time has expired.


cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d,
is a valid payment for
baba8972de24528bd56ec4ab3ce5fcead28eb45ac418eb87aace08d3da062a9b
This is a purchase transaction not valid as payment

339abf9b176253e60d1569120c2d6bca214edd4e6d8a69ef4fcdaf4f4a12cec6
invalid transaction

4259faeb7c9d017beed911e30adcc82a0b0e6ee95d189a5531c1194663f58e99
Invalid transaction

.

Tachikoma

hero member

Activity: 938

Merit: 1000

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: Tachikoma on November 25, 2013, 08:43:40 AM

I had a pm conversation once with somebody who was having the same issues. They were solved for him once the blockchain was synced. I would indeed wait on that

Thanks Tachikoma,

With my 500kbs dsl it will probably take weeks by that time the contest is over Cry

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: zathras on November 24, 2013, 11:55:44 PM

The following are identified as funds sent for purchases against that sell:

Code:

3cdcd1b8148a979f3930b1998b3282dfad2f623c9e85c9d924d4634621263294 1F73UPD5xBKgTSRd8q6QhuncVmDnJAHxYV 0.02
cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 0.0202
66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745 1AMfFzbrhhizKDpqebYVYFGaTwdtSt5ux2 1.8798

cf77f174b4cf4aaf8ba560070e2af97685e5f946f8cbd4eab6cb371fa50bfd0d is valid

3cdcd1b8148a979f3930b1998b3282dfad2f623c9e85c9d924d4634621263294 and
66fc6ef07a48f703387eac59c78d8f3c8c1f465d72dd6f4452ebfff24cf3f745 are invalid because
Purchase confirmation not found or payment time has expired.

Tachikoma

hero member

Activity: 938

Merit: 1000

I had a pm conversation once with somebody who was having the same issues. They were solved for him once the blockchain was synced. I would indeed wait on that

Bitoy

sr. member

Activity: 449

Merit: 250

Quote from: zathras on November 24, 2013, 11:22:05 PM

Your transaction actually looks fine from a quick glance, assuming you're trying to send from 1GtTPepFqS8MWZzFKsE62bNowY2LZos8Lq using vout 0 from 6efd44d3d185f9266701afff050dead21c5819054ca2a36eead8394e61a4e3df.

Oh, and script is empty because you haven't signed it yet Tongue

Thanks!

I can't sign it because the "complete" is False. When I tried to sign it even if complete is "false". There is still no script sig. I'll wait till the entire block chain is downloaded. Then will try to use your original program.

Thanks Zathras

Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 35. (Read 129207 times)