I really don't understand the problem.
Zathras is making an Windows based client. I'm sure it will have a nice installer with it and for him this is as easy as pressing the compile button.
My client will be very easy to use on any unix-based system, much like Grazcoin's implementation. As long as there is a wallet for any flavour I don't really see a problem.
I feel strongly about this because I have no way to accomplish a windows installer because of a decision I made months earlier. If I knew this was a requirement before hand I would have decided to build the application in Python since it's much easier to build on Windows. I am working my ass of and you are basically telling me; sorry it's useless.
Topic: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) - page 47. (Read 129207 times)
November 06, 2013, 02:08:31 PM
November 06, 2013, 02:03:02 PM
You changed the rules of the contest after the fact. Whatever the rules were or how they were interpreted this just isn't cool. The fact that I picked ruby as my language of choose now fucks me because I can't make an easy 1 click installer which is possible with compile-able languages.
OK. For now, I've removed that note from the acceptance criteria. It's clear you feel strongly about this, and it's very important to me to keep the developers as happy as I can.
I'd be interested to hear what the other devs think about this. I personally wouldn't feel that we had met our acceptance criteria without a Windows installer, but I don't want you guys to feel like I am moving the goalposts either.
November 06, 2013, 01:54:35 PM
Example scenario
Seller post 10 coins for sale
BuyerA post a purchase request for 3 coins (but has not paid)
Available is 7
BuyerB post a purchase for 10 coins but since available is only 7 he gets only 7.
BuyerB makes a payment.
Available is 0 (7 paid by buyerB and 3 still pending payment from buyerA)
After 1 day BuyerA didn't pay and time expired.
Available is 3.
Is this correct?
Seller post 10 coins for sale
BuyerA post a purchase request for 3 coins (but has not paid)
Available is 7
BuyerB post a purchase for 10 coins but since available is only 7 he gets only 7.
BuyerB makes a payment.
Available is 0 (7 paid by buyerB and 3 still pending payment from buyerA)
After 1 day BuyerA didn't pay and time expired.
Available is 3.
Is this correct?
According to my interoperation Buyer B's Purchase Offer would be invalid since he wanted 10 coins but at that moment only 7 were available.
I'm not too happy with this. Basically it might throw way all the work I've been doing on my client since there is no guarantee my wallet will ever support a windows installer. I don't feel this is acceptable to change afterwards.
Throw away work?? That's definitely not what I want. I just want the average Joe-user on Windows to be able to use MasterCoin without a lot of headaches.
I'm surprised to hear you say it might not ever have a Windows installer. How certain are you about that? Even still, it could have a Linux installer, couldn't it? That would at least cover the linux side.
I'm pretty certain. Windows requires a lot of custom stuff that I'm almost certain won't be worth it to package it. "Installer" is a weird word on Linux. I'm not even sure what that would entail. One might say that installing the application via gem install mastercoin-wallet could be considered an installer.
The acceptance criteria already specified that there needed to be a Windows client and a Linux client. All I added was a clarification that the Windows client should really have an installer. I don't really consider any client to be completely ready for the masses without a user-friendly installer. And that's the whole point of this project milestone - bringing distributed exchange to the masses.
The acceptance criteria also said that there would be a high bar for usability. Doesn't that goal seem incompatible with "Step 1: download my source code, required libraries, dev environment tools, and compile . . . "?
The acceptance criteria also said that there would be a high bar for usability. Doesn't that goal seem incompatible with "Step 1: download my source code, required libraries, dev environment tools, and compile . . . "?
You changed the rules of the contest after the fact. Whatever the rules were or how they were interpreted this just isn't cool. The fact that I picked ruby as my language of choose now fucks me because I can't make an easy 1 click installer which is possible with compile-able languages.
November 06, 2013, 01:44:55 PM
Zathras, I got a couple errors with masterchest wallet (not sure if this is being worked on right now but thought I would mention it before I forgot)
Quote
https://github.com/zathras-crypto/masterchest-wallet/issues/1
this seems to happen with the last block found
BLOCKSCAN: Found MSC transaction: ffe2e8ce6800454a0a81a7abca6efa8a78dde020ce478cda1f940f8254bb3425
DEBUG: SQL INSERT INTO transactions (TXID,FROMADD,TOADD,VALUE,TYPE,BLOCKTIME,BLOCKNUM,VALID,CURTYPE) VALUES ('ffe2e8ce6800454a0a81a7abca6efa8a78dde020ce478cda1f940f8254bb3425','1KZmDQGzGJWYmPP9X3b7TA9dY91KBXgaG4','1AJ4Tvs9CHEfoLfAC9U9twZmaBDzog1bDD',1000000000,'simple',0,999999,0,1)
BLOCKSCAN: Transaction processing starting...
ERROR: Processing transactions threw an exception of: The column name is not valid. [ Node name (if any) = ,Column name = UBALANCE ] - Exiting thread...
DEBUG: Thread exited.
this seems to happen with the last block found
BLOCKSCAN: Found MSC transaction: ffe2e8ce6800454a0a81a7abca6efa8a78dde020ce478cda1f940f8254bb3425
DEBUG: SQL INSERT INTO transactions (TXID,FROMADD,TOADD,VALUE,TYPE,BLOCKTIME,BLOCKNUM,VALID,CURTYPE) VALUES ('ffe2e8ce6800454a0a81a7abca6efa8a78dde020ce478cda1f940f8254bb3425','1KZmDQGzGJWYmPP9X3b7TA9dY91KBXgaG4','1AJ4Tvs9CHEfoLfAC9U9twZmaBDzog1bDD',1000000000,'simple',0,999999,0,1)
BLOCKSCAN: Transaction processing starting...
ERROR: Processing transactions threw an exception of: The column name is not valid. [ Node name (if any) = ,Column name = UBALANCE ] - Exiting thread...
DEBUG: Thread exited.
Quote
https://github.com/zathras-crypto/masterchest-wallet/issues/2
I should have 0.1 Test MSC at this address
12xdMh16KkH34YKbzoPZmn5Ai6i3jzfVwX
http://mastercoin-explorer.com/addresses/12xdMh16KkH34YKbzoPZmn5Ai6i3jzfVwX
I should have 0.1 Test MSC at this address
12xdMh16KkH34YKbzoPZmn5Ai6i3jzfVwX
http://mastercoin-explorer.com/addresses/12xdMh16KkH34YKbzoPZmn5Ai6i3jzfVwX
November 06, 2013, 01:37:34 PM
I'm not too happy with this. Basically it might throw way all the work I've been doing on my client since there is no guarantee my wallet will ever support a windows installer. I don't feel this is acceptable to change afterwards.
Throw away work?? That's definitely not what I want. I just want the average Joe-user on Windows to be able to use MasterCoin without a lot of headaches.
I'm surprised to hear you say it might not ever have a Windows installer. How certain are you about that? Even still, it could have a Linux installer, couldn't it? That would at least cover the linux side.
The acceptance criteria already specified that there needed to be a Windows client and a Linux client. All I added was a clarification that the Windows client should really have an installer. I don't really consider any client to be completely ready for the masses without a user-friendly installer. And that's the whole point of this project milestone - bringing distributed exchange to the masses.
The acceptance criteria also said that there would be a high bar for usability. Doesn't that goal seem incompatible with "Step 1: download my source code, required libraries, dev environment tools, and compile . . . "?
November 06, 2013, 01:12:09 PM
Example scenario
Seller post 10 coins for sale
BuyerA post a purchase request for 3 coins (but has not paid)
Available is 7
BuyerB post a purchase for 10 coins but since available is only 7 he gets only 7.
BuyerB makes a payment.
Available is 0 (7 paid by buyerB and 3 still pending payment from buyerA)
After 1 day BuyerA didn't pay and time expired.
Available is 3.
Is this correct?
Seller post 10 coins for sale
BuyerA post a purchase request for 3 coins (but has not paid)
Available is 7
BuyerB post a purchase for 10 coins but since available is only 7 he gets only 7.
BuyerB makes a payment.
Available is 0 (7 paid by buyerB and 3 still pending payment from buyerA)
After 1 day BuyerA didn't pay and time expired.
Available is 3.
Is this correct?
November 06, 2013, 12:57:57 PM
Hey guys,
Please be advised that I have added a clarifying note to our acceptance criteria. In order for the "high bar for usability" goal to be met, we really need a Windows installer on one of the clients.
That's now explicitly called out in the acceptance criteria, although I think it was already implicit in the usability goal.
Thanks!
Please be advised that I have added a clarifying note to our acceptance criteria. In order for the "high bar for usability" goal to be met, we really need a Windows installer on one of the clients.
That's now explicitly called out in the acceptance criteria, although I think it was already implicit in the usability goal.
Thanks!
I'm not too happy with this. Basically it might throw way all the work I've been doing on my client since there is no guarantee my wallet will ever support a windows installer. I don't feel this is acceptable to change afterwards.
November 06, 2013, 12:37:32 PM
Hey guys,
Please be advised that I have added a clarifying note to our acceptance criteria. In order for the "high bar for usability" goal to be met, we really need a Windows installer on one of the clients.
That's now explicitly called out in the acceptance criteria, although I think it was already implicit in the usability goal.
Thanks!
Please be advised that I have added a clarifying note to our acceptance criteria. In order for the "high bar for usability" goal to be met, we really need a Windows installer on one of the clients.
That's now explicitly called out in the acceptance criteria, although I think it was already implicit in the usability goal.
Thanks!
November 06, 2013, 10:50:28 AM
Please PM me if SOMEONE has extra Test Mastercoins they can spare...
Give me an address and I will send you some.
i've tried bitcoin-qt to finish a offer, finally failed
could you send me some for test, my address: 14niL1KeoNafvXYzcn9Win7avBkXQ7U2g2, thanks.
Should be underway.
November 06, 2013, 10:43:26 AM
Please PM me if SOMEONE has extra Test Mastercoins they can spare...
Give me an address and I will send you some.
i've tried bitcoin-qt to finish a offer, finally failed
could you send me some for test, my address: 14niL1KeoNafvXYzcn9Win7avBkXQ7U2g2, thanks.
November 06, 2013, 09:46:32 AM
I was wondering, would it be possible to build upon the same mechanism for BTC-MSC exchange and add support for LTC/other alt-chain exchanging? I don't use LTC or have any but I do know a decent segment would find it useful to be able to trade back and forth between alt currencies. It could be a good, quick, and easy proof-of-concept and validation for Mastercoin to be used to trade other cryptocurrencies around for each other if there was a way to parse/manipulate two blockchains at once.
Actually thinking about it, it probably would be trivial. If you can do it with BTC I don't see why LTC would be difficult but I'm not an expert.
I think once MSC to BTC is working then LTC and the other altcoins ought to be next.
LTC will have to wait until we've got LTC tokens stored in the bitcoin block chain. That will either be user-backed smart property, or escrow-backed tokens later. We can do BTC/MSC now because we are living in the BTC block chain.
i'm new to MSC, when i finished reading your spec i got one question,
why not issue MSC as smart property at the very beginning of genesis block rather than sending people MSC from your account.
with my understanding, it could be 2 steps.
1. issue smart property.
2. selling part of shares to raise money.
is it possible to create MSC as the first smart property in MSC protocol?
November 06, 2013, 03:42:02 AM
Please PM me if SOMEONE has extra Test Mastercoins they can spare...
Give me an address and I will send you some.
November 05, 2013, 09:12:36 PM
Please PM me if SOMEONE has extra Test Mastercoins they can spare...
November 05, 2013, 10:58:28 AM
After reparsing I only found one valid purchase
Buy .2 Test MSC for .003232 BTC
TxID: c7103de53a8ea3a20cec9a74543132f98302f75ab1868092e911dd5516f322a5
Confirm Payment TxID: 2bb54346f7d0ddfcb084451227089665bc1a7ebf8f0a9338d14d713592c268ed
Looks like this transaction also didn't pass
The payment was made after the Max Block Limit of 267486.
Transaction is also invalid.
I don't think so. The payment was one block later then the "Purchase Offer"
You are correct. Payment is before block limit of 267486. Site updated. Thanks =)
http://mymastercoins.com/Orders.aspx?CurrencyID=2
November 05, 2013, 10:46:50 AM
After reparsing I only found one valid purchase
Buy .2 Test MSC for .003232 BTC
TxID: c7103de53a8ea3a20cec9a74543132f98302f75ab1868092e911dd5516f322a5
Confirm Payment TxID: 2bb54346f7d0ddfcb084451227089665bc1a7ebf8f0a9338d14d713592c268ed
Looks like this transaction also didn't pass
The payment was made after the Max Block Limit of 267486.
Transaction is also invalid.
I don't think so. The payment was one block later then the "Purchase Offer"
November 05, 2013, 09:04:31 AM
You can only have one offer per address. Reading the paper will make this clear. You can easily have multiple addresses though, so it doesn't have to be a real problem.
November 05, 2013, 08:53:02 AM
Offer cancellation
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Make a new Selling Offer and set the amount to zero
Is that always the case?
So one could not have 2 sell offers say at different prices from the same address? Each consequetive offer replaces the prior?
For example, I have 100 msc, and put an offer to sell 50 at 1 btc each.
If I want to cancel this then I would make another offer for 0 at x btc.
But that precludes being able to have one offer of 50 msc at 1 btc each and another offer at 50 msc at 0.9 btc each. Unless I move 50 msc to another address first.
I guess I need to read the spec again.
November 05, 2013, 08:40:48 AM
Hi Tachikoma
Buyer 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk posted a
Buy
TxID: 33644e6f24b29e1ef170d78ff04eab6f7e19368908edc6d477f9902697a71d67
But there is no confirmed payment transaction.
When buyer posted a sell Transaction (.11 and .9 Test MSC) it is invalid because there was no payment yet for the first transaction.
After reparsing I only found one valid purchase
Buy .2 Test MSC for .003232 BTC
TxID: c7103de53a8ea3a20cec9a74543132f98302f75ab1868092e911dd5516f322a5
Confirm Payment TxID: 2bb54346f7d0ddfcb084451227089665bc1a7ebf8f0a9338d14d713592c268ed
Buyer 1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk posted a
Buy
TxID: 33644e6f24b29e1ef170d78ff04eab6f7e19368908edc6d477f9902697a71d67
But there is no confirmed payment transaction.
When buyer posted a sell Transaction (.11 and .9 Test MSC) it is invalid because there was no payment yet for the first transaction.
After reparsing I only found one valid purchase
Buy .2 Test MSC for .003232 BTC
TxID: c7103de53a8ea3a20cec9a74543132f98302f75ab1868092e911dd5516f322a5
Confirm Payment TxID: 2bb54346f7d0ddfcb084451227089665bc1a7ebf8f0a9338d14d713592c268ed
Thanks for checking my data. I'm not sure I understand you correctly though. Could you try explaining it with examples what went wrong?
I can't find the transaction where
1EdAjiApS5cCpHdH4RKPMab1xmMVRWjLvk sent .00002 BTC to 16rAwebBXhJAM9ALf3fLFbaHKz24r2o3UN
If there is a payment the rest of the transaction will be valid. It could be a bug in my implementation.
Here is an example
UserA places an advertisement to sell
UserB accepts UserA's offer
(Note: UserB has not paid UserA)
UserB places an advertisement to sell
UserC accepts UserB's offer
UserC pays UserB
Since UserB has not paid UserA the transaction of UserB with UserC is invalid.
Hmm, I'm afraid that perhaps my implementation actually counts the "Purchase Offer" as the actual payment. Since the amounts are so small it might have considered the output amount of the Mastercoin payment as payment since we use the reference address. Normally this shouldn't happen since the amounts will be much larger. I will check my code to see how it matches based on block number.
November 05, 2013, 08:36:56 AM
Offer cancellation
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Make a new Selling Offer and set the amount to zero
November 05, 2013, 08:06:17 AM
Offer cancellation
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Is there something for this, to pull back an offer? Maybe I missed it. Or would one need to accept ones own offer in orer to cancel it it out once the offer hits the blockchain?
Jump to: