Pages:
Author

Topic: [ANN] Armory Multi-Sig with Simulfunding [BOUNTY 0.03 per bug] - page 2. (Read 16304 times)

sr. member
Activity: 246
Merit: 250
My spoon is too big!
So... is version 0.92 bug-free or are people not testing anymore?    I'll take this as a good sign for the upcoming release!

Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley

Startup & loading on my mac (Mavericks with latest updates) is significantly improved. I can't speak to stability though because it wasn't my main machine and I don't make many transactions on that machine. I'm sort of waiting on the "final" version though before I replace what I have on my main machine.
member
Activity: 98
Merit: 10
I got curious and ran "Rescan Databases" on my testnet wallet that said that the inputs were already spent and it resolved the issue. At least if it comes up again, there is an easy way to recover.
sr. member
Activity: 255
Merit: 250
Senior Developer - Armory
Bug 1:

Replicate:
  • make a new transaction, up until the Confirm Transaction screen
  • close the confirm screen

Wallet is now completely non-responsive to all button clicks, must be force quit due to the close buttons not working.

Bug 3:

Replicate:
  • make a transaction
  • tick "use existing change address"

Text is squashed, if the window is made bigger the radio buttons don't work properly.



What's your version? I have seen bug #1 and #3 in the past, and I believe they are fixed now. I am unable to reproduce them with 0.91.99.11.


Same here. Just tested on OS X, which appears to be what the OP is using. Everything works fine.
full member
Activity: 123
Merit: 100
Bug 1:

Replicate:
  • make a new transaction, up until the Confirm Transaction screen
  • close the confirm screen

Wallet is now completely non-responsive to all button clicks, must be force quit due to the close buttons not working.

Bug 3:

Replicate:
  • make a transaction
  • tick "use existing change address"

Text is squashed, if the window is made bigger the radio buttons don't work properly.



What's your version? I have seen bug #1 and #3 in the past, and I believe they are fixed now. I am unable to reproduce them with 0.91.99.11.
legendary
Activity: 1428
Merit: 1093
Core Armory Developer
About bug 2:  this is intentional.  You can only 100% disable it using --skip-announce-check from the command-line when starting Armory.  We wanted to make it possible to fully disable it, but not too easy either.  The reasoning is that in the case of a major network event (such as a hardfork), it is critical for us to be able to communicate with users (always offline-signed, of course!), to let them know how to deal with it.   A hard-fork can leave open a period of non-consensus that a resourceful attacker could exploit to reverse a transaction. 

This is communicated to you through the settings window, further down where you select the notification levels.  Only critical security notifications will be retrieved from the server at the highest level, but you can fully disable it with the command-line option.
newbie
Activity: 4
Merit: 0
Bug 1:

Replicate:
  • make a new transaction, up until the Confirm Transaction screen
  • close the confirm screen

Wallet is now completely non-responsive to all button clicks, must be force quit due to the close buttons not working.


Bug 2:

If all internet connectivity is disabled in the settings, outgoing connections are still made regardless.

https://i.imgur.com/QYarjSV.jpg

https://i.imgur.com/dCkurUO.jpg


Bug 3:

https://i.imgur.com/tmTaMul.jpg

Replicate:
  • make a transaction
  • tick "use existing change address"

Text is squashed, if the window is made bigger the radio buttons don't work properly.

member
Activity: 102
Merit: 10
just downloading 0.92 version
 I am keen to try how multisig function works, to be used for escrow service.
When it works as described, I'd consider it as one of the best ways to do escrow.


full member
Activity: 147
Merit: 100
Do you like fire? I'm full of it.
So... is version 0.92 bug-free or are people not testing anymore?    I'll take this as a good sign for the upcoming release!

Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley
Windows 7: Armory pops up in front despite having the option to start minimized to tray checked. And it's quite very annoying. Smiley The issue persists with version 0.91.99.11.

I cannot replicate this.  I have tested in both Linux and Windows, and the option works for me.  Please try renaming your ArmorySettings.txt file (in C:\Users\\AppData\Roaming\Armory), and then start Armory again -- it will be like new, asking you to agree to the EULA, etc.  Try setting the option again in the menu and then restart.  Tell me if it works.
I moved the ENTIRE Armory directory away and let it create a fresh one as if it never ran before. It may be an issue with the Expert UI or something of my particular mix of settings. I am linking a paste of my ArmorySettings.txt, try using these and see if the issue is replicated. http://pastebin.com/Qf2Rb0ZG
legendary
Activity: 1428
Merit: 1093
Core Armory Developer
So... is version 0.92 bug-free or are people not testing anymore?    I'll take this as a good sign for the upcoming release!

Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley
Windows 7: Armory pops up in front despite having the option to start minimized to tray checked. And it's quite very annoying. Smiley The issue persists with version 0.91.99.11.

I cannot replicate this.  I have tested in both Linux and Windows, and the option works for me.  Please try renaming your ArmorySettings.txt file (in C:\Users\\AppData\Roaming\Armory), and then start Armory again -- it will be like new, asking you to agree to the EULA, etc.  Try setting the option again in the menu and then restart.  Tell me if it works.
sr. member
Activity: 255
Merit: 250
Senior Developer - Armory
Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley

I haven't heard much personally. I've seen a couple of bug reports regarding crashes. One person says they're using the "latest" Armory but hasn't confirmed which exact version they're using (i.e., I don't know if they're using a patched version). Another person was using 0.91.99.8 and said that upgrading to 0.91.99.11 fixed their particular crash issues. Again, I'm not promising anyone any magic bullets, but anecdotal evidence seems to suggest that the OS X build is reasonably stable at this point.
full member
Activity: 147
Merit: 100
Do you like fire? I'm full of it.
So... is version 0.92 bug-free or are people not testing anymore?    I'll take this as a good sign for the upcoming release!

Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley
Windows 7: Armory pops up in front despite having the option to start minimized to tray checked. And it's quite very annoying. Smiley The issue persists with version 0.91.99.11.
legendary
Activity: 1428
Merit: 1093
Core Armory Developer
So... is version 0.92 bug-free or are people not testing anymore?    I'll take this as a good sign for the upcoming release!

Also, any Mac users please chime in -- we're anxious to find out if Mac stability improved with .9 and .11.  doug_armory found some patches that supposedly improved stability noticeably, but no one has yet commented on it.  I will assume no news is good news Smiley
hero member
Activity: 560
Merit: 509
I prefer Zakir over Muhammed when mentioning me!
I watched the video. The whole process looks complicated at the moment to me.

I would expect that if I am in a group of people signing a multisign transaction, that the signature-process is happening in the tool.
At the moment it looks like that I have to send the partly-signed transaction with a file over to the next person via E-mail or another messaging system.
From a technical standpoint I undstand that the transaction needs to be signed by all required parties first, before it can be broadcasted.
On the otherhand would it be very hand if the partly signed transaction would automatically show up on the other person's wallet waiting for approval.

Like: "1 Transaction waiting for approval" type of messaging system.

I think DarkWallet will eventually have a P2P connection between parties to sign. However, many Armory users will have their keys in an offline system anyway, so they need some kind of transfer like that. Remember, Armory is targeted to the highest security aware users.

Would there be a way to actally embed transactions in the Blockchain which are not yet valid as they are only signed by one party? So for three signatures three times the miners fee would have to be payed, but who cares. would be awesome to use the already in place network for this. I guess the answer is no, but maybe someone knows for sure.

DarkWallet has a lot of features but still I don't think it has better security than Armory.

Thanks! It is good! So the miners fee is directly proportional to signatures, right? I think this is best wallet for providing escrow services. Smiley
Kindly,
      MZ
hero member
Activity: 784
Merit: 500

Final Testing Version before 0.92 (0.91.99.11-beta)
This will be the released version of 0.92 unless important/dangerous bugs are found (gotta stop polishing and just release it at some point).  Plan to rename this to 0.92 on Tues or Weds.


Installers for version 0.92 (pre-release 0.91.99.11-beta):
  Armory 0.91.99.11-beta for Windows XP, Vista, 7, 8+ 32- and 64-bit
  Armory 0.91.99.11-beta for MacOSX 10.7+ 64bit
  Armory 0.91.99.11-beta for Ubuntu 12.04+ 32bit
  Armory 0.91.99.11-beta for Ubuntu 12.04+ 64bit
  Armory 0.91.99.11-beta for RaspberryPi (armhf)


Offline Bundles:
  Armory 0.91.99.11-beta Offline Bundle for Ubuntu 12.04 32bit
  Armory 0.91.99.11-beta Offline Bundle for Ubuntu 12.04 64bit
  Armory 0.91.99.11-beta Offline Bundle for RaspbianPi (armhf)

Signed Hashes:
  Armory 0.91.99.11-beta: Signed hashes of all installers



Honestly, not a lot has changed from the .9 testing version except:

  • Proper sorting of simultaneous ledger entries now (should've done that like 2 years ago)
  • Offline message format upgrade warning when you attempt to create and unsigned transaction from the "Send Bitcoins" dialog (matching the one when you click "Offline Transactions" from the main window)
  • Strips extraneous signatures from transactions just before broadcast -- it will carry the extra sigs around with it so you can see who has signed, but the extras are removed when you hit "Broadcast".



Great, I´m testing.
member
Activity: 98
Merit: 10
Strange... if you can still replicate the error can you go back to .9 and test if it's oding the same thing?  I don't think anything changed between .9 and .11 that would've induced that kind of error.

Rolled back to .9 and still have the same (broken) behavior. I wonder why I didn't see this before...

Edit:
I can send you the wallet if you like (its testnet).
legendary
Activity: 1428
Merit: 1093
Core Armory Developer
Looks like one of my testnet wallets is producing invalid transactions with the latest version (0.91.99.11-beta). Every time I try to send bitcoind disconnects then reconnects and gives the log message "2014-07-20 00:36:46 ERROR: AcceptToMemoryPool : inputs already spent". I was doing some rapid spending/receiving before I did the upgrade, but everything was already confirmed before I shutdown armory to do the upgrade. I'm guessing that doing a "Rescan Database" will clear it up, but I'll hold off doing that in case you guys need some other log/trace data.

Strange... if you can still replicate the error can you go back to .9 and test if it's oding the same thing?  I don't think anything changed between .9 and .11 that would've induced that kind of error.
member
Activity: 98
Merit: 10
Looks like one of my testnet wallets is producing invalid transactions with the latest version (0.91.99.11-beta). Every time I try to send bitcoind disconnects then reconnects and gives the log message "2014-07-20 00:36:46 ERROR: AcceptToMemoryPool : inputs already spent". I was doing some rapid spending/receiving before I did the upgrade, but everything was already confirmed before I shutdown armory to do the upgrade. I'm guessing that doing a "Rescan Database" will clear it up, but I'll hold off doing that in case you guys need some other log/trace data.
sr. member
Activity: 255
Merit: 250
Senior Developer - Armory
Sorry for the delay, works been rather busy the past few days so I haven't been able to put in as much time as I'd like. Also, could you give me some insight on which ones I've submitted that are definitely not bugs and a few that you aren't sure of? I'm just trying to gauge what exactly you want and what I can safely not worry about finding/reporting.

Thanks for posting some more bugs to fix. I've started going through them. At least one (#2) isn't a bug because you're passing in a Base58 value, while the error message is counting the number of bytes in the decoded value. Subtle, I know, but it doesn't really count as a bug.

In the meantime, I'll see what I can get into 0.92. Gonna go pester Alan. Smiley

EDIT: Also, as I'm going through these, I'm noticing that some aren't actual bugs. For example, #3 isn't a bug. You need to supply a block hash. So, the following would be valid. (I just tested it.)

Code:
python armoryd.py --testnet getblock 00000000000072da6566808cce7e50c0b4f26fd56993a2a22d8d26e7cc23bad8

Use the following to see what the parameters should be. You can also poke around the source to see some examples.

Code:
python armoryd.py --testnet help

EDIT 2: Regarding #5, this is a bug, but not in the sense that you may think. One thing I forgot to point out in the help text is that the message needs to be passed in with quotation marks so as to avoid tripping up the command line argument detector. I've included an example of what's valid (other than the obvious nonsense).

Code:
python armoryd.py verifysignature \"-----BEGIN BITCOIN SIGNED MESSAGE-----$'\n'Comment: Hello.$'\n'-----BEGIN BITCOIN SIGNATURE-----$'\n'$'\n'junkjunkjunk$'\n'-----END BITCOIN SIGNATURE-----\"

That being said, it turns out that the unit test we wrote didn't take into account the fact that, on the command line, the spaces would cause the sig to be split into multiple pieces. I fixed that.

EDIT 3: #7 is also not a bug. The formatting isn't quite right. The following shows a format that will work. It's basically the same as the one from #5 with the exception that quotation marks aren't required (and will, in fact, mess things up, although I might slip in some code to handle that particular case.)

Code:
python armoryd.py --testnet signasciitransaction =====TXSIGCOLLECT-GynG9f37======================================$'\n'AQAAAAsRCQcAAAAAAf18AQEAAAALEQkHchUHvHxM29fPeY02InKy5ZQeYZ8vMA9G$'\n'rJVpM8tCGBEAAAAA/QEBAQAAAAEhOzQQbizqkYkkOvs8sxROO1j198R/ls8zebRC$'\n'TgGNagMAAACMSTBGAiEA5nWwoKcAU7g3dhs/5dkq6eaw+yY7T+uJiqKbnmjwkjAC$'\n'IQCARNrs4jaNx5iNFPyObj05olSK710suLl+YbfKe8ihUgFBBM3zuTqCoy/uKAh0$'\n'Kgn5LeWNYpMv/WJvqUsJYT2+/QtuG73EQhswCxN7aqyOaOF8EHN7mLUT93p9G0st$'\n'eWtEUof/////AlA/R9wVAAAAGXapFCOOhZJjttO/Z1siFJighsAM3huMiKwAypo7$'\n'AAAAABepFEsgPEt7f4VFiKFCrGqixxSWvpZVhwAAAAAAAAD/////AUEEYjJpOVJc$'\n'aXeB3CgM2Apdk/GpLtSA4wrfvuvhsbweFhs/BqIi3MpiugRcdTbTox3iVUhCpYon$'\n'BrmWu9/jvMRqjwAAAjQBAAAACxEJBxl2qRQApYwGgX3k4qNc5Y6XjJCDxNbZd4is$'\n'UF5R1hUAAAAAAAROT05FAAAANAEAAAALEQkHGXapFENn/3Vq4y59O99BpXN6HZTH$'\n'Zbh8iKwA4fUFAAAAAAAABE5PTkUAAAA=$'\n'================================================================

EDIT 4: (Final edit, I hope!) Hmmm. I'm not able to reproduce #8. Works for me. Sanity check: Are you using a testnet wallet in that particular example? If you are, PM me and we'll discuss what's going on.

With that said, everything other than #4 and #8 has been handled one way or another. I'll get the rest tomorrow.
legendary
Activity: 1428
Merit: 1093
Core Armory Developer

Final Testing Version before 0.92 (0.91.99.11-beta)
This will be the released version of 0.92 unless important/dangerous bugs are found (gotta stop polishing and just release it at some point).  Plan to rename this to 0.92 on Tues or Weds.


Installers for version 0.92 (pre-release 0.91.99.11-beta):
  Armory 0.91.99.11-beta for Windows XP, Vista, 7, 8+ 32- and 64-bit
  Armory 0.91.99.11-beta for MacOSX 10.7+ 64bit
  Armory 0.91.99.11-beta for Ubuntu 12.04+ 32bit
  Armory 0.91.99.11-beta for Ubuntu 12.04+ 64bit
  Armory 0.91.99.11-beta for RaspberryPi (armhf)


Offline Bundles:
  Armory 0.91.99.11-beta Offline Bundle for Ubuntu 12.04 32bit
  Armory 0.91.99.11-beta Offline Bundle for Ubuntu 12.04 64bit
  Armory 0.91.99.11-beta Offline Bundle for RaspbianPi (armhf)

Signed Hashes:
  Armory 0.91.99.11-beta: Signed hashes of all installers



Honestly, not a lot has changed from the .9 testing version except:

  • Proper sorting of simultaneous ledger entries now (should've done that like 2 years ago)
  • Offline message format upgrade warning when you attempt to create and unsigned transaction from the "Send Bitcoins" dialog (matching the one when you click "Offline Transactions" from the main window)
  • Strips extraneous signatures from transactions just before broadcast -- it will carry the extra sigs around with it so you can see who has signed, but the extras are removed when you hit "Broadcast".

newbie
Activity: 43
Merit: 0
Sorry for the delay, works been rather busy the past few days so I haven't been able to put in as much time as I'd like. Also, could you give me some insight on which ones I've submitted that are definitely not bugs and a few that you aren't sure of? I'm just trying to gauge what exactly you want and what I can safely not worry about finding/reporting.

1) You can't "importprivkey" as it will always error. I tried both hex and base58

http://pastie.org/pastes/9403588/text?key=1qunxbmpxlqa8arkoitgxq

2) There is some calculation error in listaddrunspent. You can see once you hit 3 characters in the string, it will still say 3 once you've put in a fourth and continue counting up from there.

http://pastie.org/pastes/9403585/text?key=roc4hfgkcsc6k9igcmmgq

3) You get different errors depending on the number of characters in "getblock". It seems dependent on if it's even or odd.

http://pastie.org/pastes/9403583/text?key=wucl7ytepivyq4uywdq5w

4) If you have a very long wallet description, the "Delete Wallet Options" window gets overly large and it won't show the whole thing. It also can't be resized down at all (This happens on Win and Linux, haven't tested OSX)

https://www.youtube.com/watch?v=xxl08nkXNPk

5) You can't "verifysignature" as it always interprets the "-----" as an argument for armoryd (and the only compatible signature types have "-----" in them).
I've tried in just the command line and in a bash script to no avail. If this is just an issue with my understanding of the command or how to properly give the command the information, please let me know.

Address: mkT61iEMnSSFgoCJkXFqbV9SiMHKnHDktN
Message: This is to test armoryd verifysignature for mkT61
Base64 Sign

http://pastie.org/pastes/9403589/text?key=dwsxu9jjzfyrgwlooqija

Same as above but Clearsign

http://pastie.org/pastes/9403590/text?key=zcw015sdcylrwu7k1hkniq

6) For a verified signature there is an extra ' in front of "The owner of the following ..."

https://i.imgur.com/zcbMDn8.png

7) You get an "Unexpected BLKSTRING" error when trying to signasciitranscaction. I tried both right in the command line and from a file output

http://pastie.org/pastes/9403594/text?key=zu0cydlii6zwkfyqozpq

8 ) This one I'm not sure of the cause. I thought it was originally because the wallet was locked but that isn't the case. One of my wallets if I try to "getledger" or "getledgersimple" I will get an "AttributeError":

http://pastie.org/pastes/9403608/text?key=qtztvorf7wni6c8tj9jtbg

I can provide you with this wallet if you'd like, just let me know.
Pages:
Jump to: