Topic: [ANN] MarginBot - A Bitfinex Margin Lending Management Bot - page 3. (Read 45937 times)

Just updated github to 1.07c.  Fixed the above update.php issue (i used decimal(18,8), which should cover even the largest of investors), and made a quick fix to balances updating after loans are canceled ( Thanks jbhuang ! ).

The only 3 files that changed from v1.07b are:
/update.php
/inc/version_info.php
/inc/ExchangeAPIs/bitfinex.php

if updating from that version, you should only need to copy over those three files.  If updating from an older version, or doing a new install, follow the standard procedures.

Aye, good catch, that should definitely be at least decimal(16,8).   I was building the updater on a relatively new install that didn't have much data in it, and 12,8 worked for me (only a few thousand $ in the test account), but it will fail for anyone with > $9,999 in their account.  I will update this in github.

For a few weeks now, my marginbot setup has not been picking up account history, nor unused funding, but the cron job runs were being added to the BFXLendBot_CronRuns table.

I spent some time on it yesterday, and didn't get any ideas as to what might be wrong. Not least because my php binary will not execute a .php file.

But the problem shows up as a lack of history on http://.../marginbot/index.php

and a lack of entries in the table BFXLendBot_Tracking. The last entry was 2017-08-19.

So I noticed this morning 1.07b was available on the master branch.

I followed the update instructions, and the following occurred:

A new table BFXLendBot_CurPairs is created, and the 4 existing tables are backed up to copies with the suffix _BACKUP_v17

But I get this error on the screen http://.../marginbot/update.php?doUpdate=2


I am using

5.7.16
MySQL Community Server (GPL)

Poking around the MySQL tables, it seems the table definitions are still the same: decimal(12,2). But I can see some ALTER TABLE statements in update.php, that switch to decimal(12,8).
When I paste the ALTER TABLE for the Tracking table into MySQLWorkbench it thinks there is a syntax error in both MODIFY COLUMN parts of the SQL statement.



I am also wondering it it makes more sense to use decimal(16,8), as that way you can still support numbers up to 999,999,999. decimal(12,8) only goes up to 9,999.

Hmm.  something is seriously not right with your server setup.  From that screenshot it looks like its dumping raw code rather than executing it, which shouldn't even be possible, unless its not actually being parsed by PHP.  have you been able to correctly run any other PHP code on the server?

Right, when I try to run from the browser the page appears messy like the previous screenshot, i am not sure if you can see that?

You have been trying to run this from a web browser, not just the terminal, right?  It is a form you'll need to put information into.  Running it from a browser, it should ignore those warnings and notices and show the page without a problem.

Tired the quickfix, here is the output


@bot:/var/www/html/MarginBot-master$ php -f install.php
error_reporting(E_ALL&~E_NOTICE);
PHP Warning:  session_start(): Cannot send session cookie - headers already sent by (output started at /var/www/html/MarginBot-master/install.php:1) in /var/www/html/MarginBot-master/inc/config.php on line 4
PHP Warning:  session_start(): Cannot send session cache limiter - headers already sent (output started at /var/www/html/MarginBot-master/install.php:1) in /var/www/html/MarginBot-master/inc/config.php on line 4
PHP Notice:  Undefined index: doInstall in /var/www/html/MarginBot-master/install.php on line 10
PHP Notice:  Undefined index: doInstall in /var/www/html/MarginBot-master/install.php on line 168

I am not sure, is there anything I can run to check that? could it be related to permission? 

I will be able to test the quick fix in 2 hours also I will create another VM on the side to document the steps of the build and post here for reference


 

Do you have error settings particularly high on your php setup?  These are all notices, and shouldn't cause the script to stop executing.  There's no actual errors in this list.

A quick fix would be to add this to the top line of install.php:

error_reporting(E_ALL & ~E_NOTICE);

Downloaded the fix but this time the installer.php prints the script and some error to the console

/var/www/html/MarginBot-master$ php -f install.php

PHP Notice:  Undefined index: doInstall in /var/www/html/MarginBot-master/install.php on line 9

PHP Notice:  Undefined index: doInstall in /var/www/html/MarginBot-master/install.php on line 167


http://www.w3.org/1999/xhtml">



PHP Notice:  Undefined variable: config in /var/www/html/MarginBot-master/inc/General.php on line 536

PHP Notice:  Undefined variable: config in /var/www/html/MarginBot-master/inc/General.php on line 536

PHP Notice:  Undefined variable: config in /var/www/html/MarginBot-master/inc/General.php on line 536

PHP Notice:  Undefined variable: config in /var/www/html/MarginBot-master/inc/General.php on line 541






PHP Notice:  Undefined index: doInstall in /var/www/html/MarginBot-master/install.php on line 334

PHP Notice:  Undefined index: installDBHost in /var/www/html/MarginBot-master/install.php on line 336

PHP Notice:  Undefined index: installDBPrefix in /var/www/html/MarginBot-master/install.php on line 337

PHP Notice:  Undefined index: installDBName in /var/www/html/MarginBot-master/install.php on line 395

PHP Notice:  Undefined index: installDBUser in /var/www/html/MarginBot-master/install.php on line 398

PHP Notice:  Undefined index: installDBPassword in /var/www/html/MarginBot-master/install.php on line 401

PHP Notice:  Undefined index: installEmail in /var/www/html/MarginBot-master/install.php on line 427

Background on my setup, it is a new VM with Ubuntu 16.04 LAMP stack

2 things:
1. I just uploaded another quick hotfix because I forgot to add something to the installer for the new version.  The hotfix isn't your issue though (but you will want to download it). 

2.  For some reason your server isn't correctly loading $_SERVER['SCRIPT_URL'] (PHP Notice:  Undefined index: SCRIPT_URL in /var/www/html/inc/General.php on line 14).
This is strange.  Never run into that issue before, but I changed it to $_SERVER['PHP_SELF'] which is a little more universal in the latest update.  If that still isn't working for you, I'll need to figure out another way to trap for what script is running.

Thanks for replying but I must be doing something wrong



from console

/var/www/html$ php -f install.php
PHP Notice:  Undefined index: doInstall in /var/www/html/install.php on line 9
PHP Notice:  Undefined index: doInstall in /var/www/html/install.php on line 151
PHP Notice:  Undefined index: SCRIPT_URL in /var/www/html/inc/General.php on line 14
PHP Notice:  Undefined index: SCRIPT_URL in /var/www/html/inc/General.php on line 14
PHP Fatal error:  Uncaught Error: Call to a member function query() on null in /var/www/html/inc/General.php:15
Stack trace:
#0 /var/www/html/install.php(246): General->__construct()
#1 {main}
  thrown in /var/www/html/inc/General.php on line 15

Oops, actually it looks like 1.07 broke the installer.  I just uploaded a quick fix that should address the issue.  Just download the newest version, 1.07a and try running it again.  It should correctly redirect you to the installer and allow you to set up the mysql database this time.  Sorry about that.  

*EDIT* If you have any more issues installing just post here and I'll be happy to help however I can.

Hi,

First time trying to set up this, is it possible to create how to for beginners?

I am stuck at "failed to connect to MYSQL"

Any help would be much appreciated.

Ok, its ready!  MarginBot v0.1.07 is now live on github!  Full Crypto Margin lending!  Currently it supports all currencies that Bitfinex supports for margin.

You can get it here:
https://github.com/HFenter/MarginBot


Full install instructions are there, but here's a quick Update instruction:


Update from an older Version

Important - Make sure to backup your existing inc/config.php file FIRST

To update, make a backup of your inc/config.php file, then download the most current version. Unzip the files and overwrite your existing install.

Then overwrite the default config.php file with your backed up version.
Visit the site, and you'll be redirected to an update system.
If you are not correctly redirected, just visit /MarginBot/update.php

If there are any issues feel free to contact me here or via the built in contact email.

(I'm wondering if I should start a new thread on this, since I can't update the original post anymore....  What do you guys think?)

Yeah, I'd noticed.  Already reported it.  Those 2 posts were not me.  At this point I'm pretty much considering that account gone.

Just checking that account, it had made 2 posts in a thread in May of this year. Doesn't seem characteristic. I'd look into that.

I am currently working on adding back in Crypto Margin Lending.  I hope to have a new build up in the next day or so with this built in.  It should allow all types of crypto bitfinx supports for margin.

Hi,

Since Bitfinex now supports Bitcoin Cash Lending

Can or will your bot support it?

Very happy to see you back HowardF! As a MarginBot user since 2015 I'm extremely excited to see what you have in store for us!

Welcome back!