Topic: [BOUNTY] Armory Bugs: 0.1 BTC each (Disabled: Coming back soon!) - page 3. (Read 7689 times)

See (5) in original post:  I said that anything to do with message signing or EC calc is already known -- they are not exactly broken, but they are buggy.  That whole thing will be revamped in the near future (when I sync my signing algorithm with Bitcoin-Qt).



Yes and no.  The option should be grayed out, but it should also say "Only available when online".  It does say that if Armory is currently scanning the blockchain, but I guess I missed the trigger when you're in offline mode.  I'll give you that one

The reason it's grayed out is because "Sweeping" requires being connected to the network in order to broadcast the sweep transaction (moving all the coins from one address to another).  This can't be done in offline offline.  OTOH, importing is simply saving the key to your wallet file, which does not require an internet connection.


I must give you this one, too.  Even though there's no real user impact, there is an error thrown under-the-hood, and it deserves being fixed. 


That's intentional.  It is essentially a "factory reset".

---

@ subSTRATA:  I do appreciate all these little bugs.  This is actually exactly what I was looking for, for 0.1 BTC each.  But please collect them internally and post them in batches of 5 or something.  I'm starting to feel spammed by the constant notifications.  Also, please PM me a receiving address so I can send you the bounties (I won't send it yet, but I need to add it to my spreadsheet).

---

This is a little fuzzier... I want to encourage people to get involved, but I also don't want to pay people for helping fix bugs that I can take care of on my own in less than 5 minutes.  If you plan to try to fix a bug and want a bounty for it, please PM or email me first.  If it looks like it will save me time, I will happily pay a bounty for it.

Do we also get rewarded if we provide fixes for those bugs?  
That might encourage me to spend some time playing around with some of them... 

You know -- never once in my entire life have I ever clicked on one of those Windows help buttons.  And now that I do, I think it's behavior is correct -- whatever you expect it to do:  it's unavailable.  I don't even know how to override that behavior if I wanted to. 


Bitcoin-Qt wallet files are not compatible with Armory.  So, I actually do not want users to be able to select Bitcoin-Qt wallet files.   When the new wallet files are complete, I'll bring back the "Bitcoin-Qt Wallet Migration" feature, and then there will be a separate dialog for that.  Until then, it would be a bug if it did let you select a .dat file

When importing my wallet, you have it to detect ".wallet" files, I think for newer users it would be more helpful for it to include ".dat" types, since the main Bitcoin client uses wallet.dat. Just a thought. Ubuntu 64 Bit

Yes, that counts!  If it's a blatant programming error, or data is missing from a dialog, etc, that definitely counts.  I only offer 0.1 BTC because I expect lots of little things like this -- which I really do want to find, but there could be lots of them, so I want to avoid going broke over them.



This is a bug I've known about for a very long time.  And I've tried, multiple times to fix it.   But nothing I do works!  (I actually have code in Armory to try to hide the icon just before it closes... not sure why that doesn't work, actually).   You still deserve 0.1 BTC for it, and I will add it to the list of bugs-I-already-know-about.

Post, PM or email me a BTC address and I'll send you 0.2 BTC in the near future.  I can send it right away, but it sounds like you'll be finding more stuff in the near future

I've posted this elsewhere, but figured this was a good place to put it, too.

If you are on OSX and want to try out the testing branch, you can use the latest update to my brew tap.

https://bitcointalksearch.org/topic/wysenynjas-homebrew-tap-for-all-your-osx-bitcoin-needs-133097

Restart the bounty!  Finally chased down the P2Pool issue (actually in 0.86.4) and it appears I fixed the problems with bitcoind/-qt 0.8+.   Not only that, but I got lucky and ran into a bug that only occurs when multiple blocks are received during blockchain scanning. 

Armory 0.86.5-testing for Win64
Armory 0.86.5-testing for Win64 and Win32

Any bug I claim to have fixed but isn't fixed, counts for the bounty.  That means that there's almost guaranteed to be a bug related to bitcoind 0.8+ that I haven't caught.  Let's find them!

Nice catch!  The hex conversion normally takes uppercase chars, but my little char-counting method doesn't.  I added 1ioQoMa7v2YLGtrqznQhrafvrJdeDBN3c for 0.1 to my list

No, I think i will let others grab some bounties as well! Actually, I don't have a working bitcoin-qt + full blockchain, so there's a lot of functionality I can't even test right now.

I wanted to import some of my private keys, I found out that you cant import keys in hex with upper case characters.
I get this error:
http://i.minus.com/iZMKGeDQwlcbo.png

When I import it in lower case it works fine
my test was under ubuntu 64bit

EDIT: I found the problem in the source code. I made a pull request here: https://github.com/etotheipi/BitcoinArmory/pull/36

Thanks flatfly.  There is a box that says "Install for Current User Only" which is checked... but perhaps my MSI creator doesn't do that correctly.  Maybe there's a way to force the correct behavior.

The "offline" thing is one of these strange situations... that message is expected to occur for users who are actually on an offline computer, and won't show up if they are on an online computer that isn't finished scanning.  If the user explicitly puts Armory into offline mode but could be online... I don't know what message to display to match their use case.  I would guess that's the correct message...?   I'll think about that.  Either way,  I added your name to my spreadsheet again

I'm glad you like the app -- I was thinking this might be good marketing for Armory, in addition to getting people to help test it.  If you keep digging through it, maybe you can vacuum up all the bounties for yourself   (and I hope you can see why I can't test this myself... there's an extraordinary number of options, actions, and states that Armory can be in for each of those). 

Another small one: if Bitcoin-Qt is not running, or not up-to-date, Armory
correctly detects that it is in "offline mode", but the Send Bitcoins
button does show the normal Send dialog.

Isn't it supposed to show the below message instead, as it does when started
through the "Armory (Offline)" shortcut?

Armory is currently running in offline mode, and has no ability to determine balances or create transactions.   In order to send coins from this wallet you must use a full copy of this wallet from an online computer, or initiate an "offline transaction" using a watching-only wallet on an online computer.

Thanks!

Yes, I do try to install it to a non-admin directory. The attached screenshot, while not very detailed, might provide some clues as to what exactly is causing the installation to abort. Notice how it refers to "all users"...



EDIT: After further analysis, I am 99% confident this happens because the installer tries to create the desktop and start menu shortcuts for ALL existing profiles, not just the current one.

I've played around with the GUI for the first time, and I must say I'm quite impressed by the overall quality and level of attention to detail. Great job!

I assume you tried to install it in a non-admin-required directory?  Even the "bitcoin:" URL-registration should happen at the user-level, so I'm not sure what would require admin privileges.  I just tried installing it in a non-admin directory and I got a UAC dialog asking if I want to allow this program from the internet to make changes to my hard drive.  Is that an Admin-required dialog?  I even have unchecked the box in my .msi builder that says "Must be admin to install"... hmmm.  I wonder if it's something to do with code-signing?

Admittedly, I'd prefer users to install it via admin, so it's slightly harder for someone to manipulate the installed files -- but maybe that's pointless with all the root exploits in Windows.  Users should have the option to install it as non-admins...

I'll add you to the list of 0.1 BTC recipients

Nice initiative!

Not sure if this can be called a bug, but the Armory installer refuses to proceed on a non-admin user account (on Windows.)  Could this possibly be changed, or are there good reasons for that? The Bitcoin-Qt installer happily proceeds on a standard account, by the way.

There is a bounty of 0.1 BTC per new bug found in Armory 0.86.3-beta, up to a maximum of 3 BTC.  This test drive ends on Jan 1, 2013.  (at my discretion, I may pay more than 0.1 BTC, depending on the scope/impact/subtleness of the bug)

Armory doesn't have enough testers.  And the current testers are mostly Armory veterans that have been using it for a while and not doing new-user operations like creating new wallets, printing their one-time backups, etc.  So I'm hoping that this post will get some fresh eyes on the app, and also give current testers some incentive to really try to break things.

So, I'm going to test bug bounties for a short period of time, to see what kind of response I get.  I may extend it in the future, if it turns out to be an efficient way to get testers and find bugs without too much dispute.  And I do expect some dispute, but I'm going to try to be lenient about it.  That's also why I've set an upper limit of 3 BTC, to limit the impact of this going terribly wrong...

What qualifies as a "bug" is anything that impacts usability: I don't really want to give out bounties for grammatical improvements or missing punctuation in dialogs.  Though maybe some would argue that I should.    What I'm really looking for is things like checkboxes that should be disabled but aren't when using a watching-only wallet, selection dialogs with zero things to choose from, buttons that do nothing when clicked, etc.  And obviously crashes, too.  

Here's a list of well-known bugs that don't count, because I already know about them and there's nothing I can do at the moment:

• (1) Armory uses a lot of RAM
• (2) Loading Armory before Bitcoin-Qt is sync'd causes rapid connect-disconnect flickering
• (3) Lack of unicode support (coming soon, actually, just not in 0.86.3).
• (4) Windows systems always detect memory pool corruption and delete it.
• (5) Anything to do with the message-signing dialog -- it's queued to be revamped soon to be more useful (and match Bitcoin-Qt)
• (6) *.deb package is of "bad quality" according to newer versions of Ubuntu
• (7) Armory sometimes crashes after 0.5-6 days (it's not a memory leak, for sure)
• (8 ) Paper backup printing doesn't work in OSX.  Please copy the data by hand or copy to another program where printing does work.
• (9) System tray icon does not disappear when Armory is closed (Windows only).
• (10) Unclickable link in version-check window

Here's what you need to do to collect the bounty:

• (1) Be the first to post about a particular bug for the current testing version
• (2) If you don't include a payment address in your post, I will assume that I should send the 0.1 BTC to donation address in your signature
• (3) Either post relevant portions of the log file, or send me the log via email or PM (File-->Export Log File)
• (4) Have some patience -- I need to figure out the best way to run this operation.  Also, I will send out payments in batches.  If 4 people find 3 bugs each, I'll be sending out one tx paying 0.3 BTC to all four people at the end of the day or the next morning (you can request sooner if you're super anxious for some reason).

If you're interested please download the absolute latest: Armory 0.86.3-beta.  It's not a testing version, but there won't be another testing version for a while, and I'm sure there's still plenty of bugs to be found here.

UPDATE:  Also, I've decided that anything in the testing branch is fair game.  That is probably more bug-dense, but this little bounty drive will encourage me to do more internal testing before merging anything into that branch   (for 0.86.5-testing, I compiled and posted Windows-testing versions above).

---

Bugs reported (and thus, don't expect a bounty if you just found it):
(1) UAC/admin needed even for local installation of Armory on Windows.  
(2) Wallets with P2Pool payouts crash Armory!  (reported here).
(3) Missing string replacement on dashboard when user is missing blk*.dat files.