Topic: Electrum - Bitcoin client for the common users (friendly and instant) - page 32. (Read 110104 times)

My plan was to test multi-select spends more. Then try to merge the current master to my fork so I'm current. I could then merge each of my feature branches in and resolve any conflicts due to other changes. Then for each feature send a pull request that should be right up to date. I treat my merged-2 branch as a local work copy for me as I use it to create a python build and install for real into my system.

I'm not much of an IRC user. Every time I go on there I stumble around trying to figure out what to type and whether I'm treading on people's toes. I'm tied up for the next couple hours but I'll try it out after and see if I can get some better communication going.

I also think I need a better IRC client as I'm using Empathy and it doesn't seem very good overall. If I had something with IRC and OTR messaging that I could use I might actually be tempted to leave it running as I no longer trust Skype.

@bkk: also, you're welcome to come and discuss on IRC. it is much more efficient

Bkk, would it be possible for you to create pull requests for specific functionality. So we can asses on a per feature basis if and how to merge it back into master?

At the moment it's quite hard to assess this because you have been so active ^^

I've now got a fix for exchanges using proxy when selected. The new code is in my fork bkkcoins/electrum branch exchanges-proxy but it also depends on branch multi-exchange so that would need to be pulled in first.

I agree that fixing just a proxy sounds easier for now. Although using stratum servers for price quotes makes more sense, currently it has quite low priority.

I know that intersango quote was quick hack done by genjix, but I'd appreciate if future features will be implemented correctly (over the Stratum servers) than adding more and more separate channels into the client.

Sounds sensible.

I tend to agree that security wise the best option is a single connection to the server. But it also lacks flexibility. I already did a re-org of the exchange code in my fork, creating "lib/exchanges" subdir, that allowed a choice of exchange using a module for each exchange site. I created a MtGox exchange  module in addition to the Intersango one already there by default. The nice thing is foreign users who want some particular exchange rate (eg. Yen, Ruble etc) could select the exchanger in the Settings dialog.

Having only support thru the Electrum server would limit what was available for users to whatever the server decided to offer for quotes. But I could easily create a module that directed quote requests to thru current Electrum server so that users have the option of using Electrum quotes or any other exchanger module available. Right now the server doesn't have an exchange quote api but that could be created.

So at this time it seems the best option is to wrap exchanger modules for proxy use, if one is selected, so that at least leakage won't occur. Then later we could add an exchange api to the server and a Electrum exchanger module for clients. At that point users would have ultimate flexibility in this area. They could choose native Electrum quotes or optional external quotes.

Feedback?

Definitely the second, it should go through proxy by default if one is set.

Hehe that's exactly the reason why only Stratum connection should be used for communication with the rest of the world. Electrum server should expose RPC call providing current exchange rate and client should just call it instead of using separate http connection.

Any chance to do this instead of hacking httplib to go thru proxy?

I was thinking of adding an option to force currency exchange price requests thru the proxy if one is set. This is so that you don't get local data leakage when using Electrum thru a proxy / Tor.

I'm wondering if it needs to be an option or if it should just always use the proxy if one chosen?

Any input on this?

SO sorry went to sleep,
Ah 30 mb ram? thats great! thanks so much flatfly!

Actually the command line already supports this (try "electrum -o history" or "electrum -o balance")  since, as bkkcoins said, the wallet file already contains all the required info. So I imagine it shouldn't be too hard to adapt the gui_qt code accordingly.

Yeah.

Do you mean ...even if offline...?

I think the client ought to be able to do this now but for some reason doesn't. It has a transaction history list stored in the wallet for all addresses accurate as far as the last time it connected. I haven't explored the code to see why it doesn't show this info when it cannot connect. There may be a reason or may be it just wasn't thought of as useful. I can see it being useful but it should perhaps have a "last sync'd at