Okay great.
Preparing for a landing for a new release at last. Just ironing out the windows build problems that inevitably show up at the last minute.
Topic: OFFICIAL CGMINER mining software thread for linux/win/osx/mips/arm/r-pi 4.11.0 - page 725. (Read 5805728 times)
December 27, 2011, 01:41:55 AM
December 26, 2011, 11:51:12 PM
If someone wants to pull the master tree and check the formatting now please? My main rig just blew a mobo so I can't even check the GPU output 
Code:
cgminer version 2.0.9 - Started: [2011-12-27 04:50:37]
--------------------------------------------------------------------------------
(5s):644.4 (avg):708.8 Mh/s | Q:10 A:1 R:0 HW:0 E:10% U:11.87/m
TQ: 4 ST: 4 SS: 0 DW: 0 NB: 1 LW: 0 GF: 0 RF: 0
Connected to http://goat1.zapto.org:8337 with LP as user redemerald
Block: 00000b3c547d8b81053607186b8dd5cf... Started: [04:50:12]
--------------------------------------------------------------------------------
[P]ool management [G]PU management [S]ettings [D]isplay options [Q]uit
GPU 0: 61.0C 4316RPM | 378.3/468.1Mh/s | A:0 R:0 HW:0 U:0.00/m I:8
GPU 1: 57.5C | 380.1/380.1Mh/s | A:1 R:0 HW:0 U:11.87/m I:7
GPU 2: 47.0C 3369RPM | 348.5/305.4Mh/s | A:1 R:0 HW:0 U:11.87/m I:8
--------------------------------------------------------------------------------
Looks good
December 26, 2011, 11:00:19 PM
If someone wants to pull the master tree and check the formatting now please? My main rig just blew a mobo so I can't even check the GPU output
December 26, 2011, 10:57:27 PM
Sigh. I fucking hate formatting shit...
Heh. Yep, I thought I sensed developer resistance. I recognize it from the many initial reactions I've experienced when dealing with users. The pattern is: no way! ... hmm, I guess you could have a point ... well, maybe ... sigh; OK.
Wouldn't there be a volunteer or two to do this for you (for us)? If not I might step up, but I'm a *nix/git newbie so there'd be some learning overhead/delay.
December 26, 2011, 10:46:48 PM
I'll see what I can do 
December 26, 2011, 10:41:25 PM
Sigh. I fucking hate formatting shit...
Trademark of a true kernel dev!(that's a compliment)
December 26, 2011, 10:38:22 PM
Sigh. I fucking hate formatting shit...
Trademark of a true kernel dev!(that's a compliment)
December 26, 2011, 10:32:50 PM
Don't forget some GPUs don't report fan speed in RPM and then it will show %. And when there's less chars it will show zeroes unless the outputting code gets much funkier.
Code:
GPU 0: 073.0C 3858RPM | 026.7/026.1Mh/s | A:683 R:6 HW:0 U:4.83/m I:9
GPU 1: 077.0C 0099% | 328.8/327.4Mh/s | A:631 R:4 HW:0 U:4.46/m I:9
December 26, 2011, 10:30:15 PM
How about if I don't like the extra spaces?
Is that a rhetorical question? As a user what possible reason would make you prefer:
Code:
GPU 0: 73.0C 3858RPM | 26.7/26.1Mh/s | A:683 R:6 HW:0 U:4.83/m I:9
GPU 1: 77.0C | 328.8/327.4Mh/s | A:631 R:4 HW:0 U:4.46/m I:9
GPU 2: 102.5C 3140RPM | 337.0/327.9Mh/s | A:626 R:5 HW:0 U:4.43/m I:9
GPU 3: 68.5C | 338.3/324.8Mh/s | A:586 R:1 HW:0 U:4.14/m I:9
GPU 4: 73.0C 2780RPM | 319.6/327.3Mh/s | A:656 R:4 HW:0 U:4.64/m I:9
GPU 5: 333.3/327.3Mh/s | A:642 R:4 HW:0 U:4.54/m I:9
over
Code:
GPU 0: 73.0C 3858RPM | 26.7/ 26.1Mh/s | A:683 R:6 HW:0 U:4.83/m I:9
GPU 1: 77.0C | 328.8/327.4Mh/s | A:631 R:4 HW:0 U:4.46/m I:9
GPU 2: 102.5C 3140RPM | 337.0/327.9Mh/s | A:626 R:5 HW:0 U:4.43/m I:9
GPU 3: 68.5C | 338.3/324.8Mh/s | A:586 R:1 HW:0 U:4.14/m I:9
GPU 4: 73.0C 2780RPM | 319.6/327.3Mh/s | A:656 R:4 HW:0 U:4.64/m I:9
GPU 5: | 333.3/327.3Mh/s | A:642 R:4 HW:0 U:4.54/m I:9
December 26, 2011, 10:27:40 PM
How about if I don't like the extra spaces?
Are you asking as developer or user?
Sigh. I fucking hate formatting shit...
December 26, 2011, 10:23:53 PM
How about if I don't like the extra spaces?
Are you asking as developer or user?
December 26, 2011, 10:16:56 PM
How about if I don't like the extra spaces?
Are you asking as developer or user?
December 26, 2011, 10:13:09 PM
How about if I don't like the extra spaces?
December 26, 2011, 09:54:22 PM
Here's a small patch you can try for adding a few spaces when the gpu doesn't return fan info.
Save in file "mypatch".
Note this was made on my local modified code but I think it will work on 2.0.8 vanilla.
Step by step...
copy main.c main.bak.c
patch < mypatch
It just adds one line. I didn't test this other than it compiles fine because I don't have a dual gpu card at all. But it's a simple thing to try and it may make you happier. You can play with the number of spaces...
Save in file "mypatch".
Code:
--- main.bak.c 2011-12-27 09:26:58.000000000 +0700
+++ main.c 2011-12-27 09:25:10.000000000 +0700
@@ -2074,6 +2074,7 @@
wprintw(statuswin, "%4dRPM ", gf);
else if (gp != -1)
wprintw(statuswin, "%2d%% ", gp);
+ else wprintw(statuswin, " ");
if (gt > -1 || gf > -1 || gp > -1)
wprintw(statuswin, "| ");
}
Note this was made on my local modified code but I think it will work on 2.0.8 vanilla.
Step by step...
copy main.c main.bak.c
patch < mypatch
It just adds one line. I didn't test this other than it compiles fine because I don't have a dual gpu card at all. But it's a simple thing to try and it may make you happier. You can play with the number of spaces...
The same should be done with the temperature. And then the output of the "| " could be unconditional.
December 26, 2011, 09:43:42 PM
The code already uses wprintw with fixed widths in most cases - it just needed to handle when no value was returned by the gpu. See patch above, adds the one line needed here.
December 26, 2011, 09:40:22 PM
Spacing of even values that do exist is not exactly fixed width... Imposing a fixed width one way or another will just lead to other formatting issues :\
The output I happen to be looking at is in a fixed-width font. This is likely user-selectable in most if not all cases. If the output were designed for a monospace font and a one-line note to that effect placed in the user doc, what other formatting issues would ensue?
I don't think any GPU is capable of more than 500.0 MH but even still:
psuedo code:
# of spaces = maxlength - len(value)
output string = (# of spaces) + value
max length
rpm: 4 (up to 9999 rpm)
temp: 5 (up to 999.9 C)
mhash: 5 (up to 999.9 MH/S)
Accept & Reject are less of an issue because it an edge case where one GPU will have two or more magnitudes higher value than another one. At most they will differ for a short period of time by 1 digit.
December 26, 2011, 09:39:10 PM
RPM goes from 1 to 4 maybe 5 characters. Temp goes from 4 to 5, Mhash goes from 3 to (7?), accepted/rejects goes from 1 char to 5, 6, 7 or...
Yes, fixed-width output requires making an estimate of the maximum width required for each field. Then columns will misalign only if the maximum is exceeded on one or more fields and the overage is not uniform among lines. (I haven't looked at the code, but I noticed that there are a lot of files with .c extensions, so I assume something like (s)printf or similar is being used.)
December 26, 2011, 09:33:38 PM
Here's a small patch you can try for adding a few spaces when the gpu doesn't return fan info.
Save in file "mypatch".
Note this was made on my local modified code but I think it will work on 2.0.8 vanilla.
Step by step...
copy main.c main.bak.c
patch < mypatch
It just adds one line. I didn't test this other than it compiles fine because I don't have a dual gpu card at all. But it's a simple thing to try and it may make you happier. You can play with the number of spaces...
Save in file "mypatch".
Code:
--- main.bak.c 2011-12-27 09:26:58.000000000 +0700
+++ main.c 2011-12-27 09:25:10.000000000 +0700
@@ -2074,6 +2074,7 @@
wprintw(statuswin, "%4dRPM ", gf);
else if (gp != -1)
wprintw(statuswin, "%2d%% ", gp);
+ else wprintw(statuswin, " ");
if (gt > -1 || gf > -1 || gp > -1)
wprintw(statuswin, "| ");
}
Note this was made on my local modified code but I think it will work on 2.0.8 vanilla.
Step by step...
copy main.c main.bak.c
patch < mypatch
It just adds one line. I didn't test this other than it compiles fine because I don't have a dual gpu card at all. But it's a simple thing to try and it may make you happier. You can play with the number of spaces...
December 26, 2011, 09:30:07 PM
Spacing of even values that do exist is not exactly fixed width... Imposing a fixed width one way or another will just lead to other formatting issues :\
The output I happen to be looking at is in a fixed-width font. This is likely user-selectable in most if not all cases. If the output were designed for a monospace font and a one-line note to that effect placed in the user doc, what other formatting issues would ensue?
It's a never ending battle to try and find some compromise.
December 26, 2011, 09:11:23 PM
Spacing of even values that do exist is not exactly fixed width... Imposing a fixed width one way or another will just lead to other formatting issues :\
The output I happen to be looking at is in a fixed-width font. This is likely user-selectable in most if not all cases. If the output were designed for a monospace font and a one-line note to that effect placed in the user doc, what other formatting issues would ensue?
Jump to: