Pages:
Author

Topic: Why the hell this shit was not tested on testnet? - page 2. (Read 3335 times)

legendary
Activity: 1246
Merit: 1077
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7

Indeed, the testing should have been conducted in the three years since Bitcoin was released. It's appalling how the edge conditions were never tested.

Not sure backward compatibility is an edge case.... generally its a big deal you plan a transition for.  What happened here was a rushed satoshi dice bailout with much discussion on filtering out their transactions while a real solution could be worked on.... which now leaves everyone feeling the pain instead of a single entertainment site.

The edge condition is referring to the blocks that were rejected even before 0.8 was released. A perfectly valid block could be rejected by every Bitcoin node. Isn't this something that should never happen?

A block rejected by all nodes is by definition invalid. Someone wil produce a new valid one, and the building will continue as normal.


Is there any evidence that all nodes would reject it? It looks like, according to Pieter's preliminary statement, that certain configurations will (correctly) accept the blocks.

Quote
Immediate solution is upgrading to 0.8, or manually setting the number of
lock objects higher in your database. I'll follow up with more concrete
instructions.
legendary
Activity: 1078
Merit: 1006
100 satoshis -> ISO code
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7

Indeed, the testing should have been conducted in the three years since Bitcoin was released. It's appalling how the edge conditions were never tested.

Not sure backward compatibility is an edge case.... generally its a big deal you plan a transition for.  What happened here was a rushed satoshi dice bailout with much discussion on filtering out their transactions while a real solution could be worked on.... which now leaves everyone feeling the pain instead of a single entertainment site.

The edge condition is referring to the blocks that were rejected even before 0.8 was released. A perfectly valid block could be rejected by every Bitcoin node. Isn't this something that should never happen?

A block rejected by all nodes is by definition invalid. Someone will produce a new valid one, and the building will continue as normal.
legendary
Activity: 1246
Merit: 1077
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7

Indeed, the testing should have been conducted in the three years since Bitcoin was released. It's appalling how the edge conditions were never tested.

Not sure backward compatibility is an edge case.... generally its a big deal you plan a transition for.  What happened here was a rushed satoshi dice bailout with much discussion on filtering out their transactions while a real solution could be worked on.... which now leaves everyone feeling the pain instead of a single entertainment site.

The edge condition is referring to the blocks that were rejected even before 0.8 was released. A perfectly valid block could be rejected by every Bitcoin node. Isn't this something that should never happen?
legendary
Activity: 2940
Merit: 1090
Running all versions that are not totally obsolete on testnet at same time as running new version on it might have caught this, maybe?

Sure only running the new version on testnet without any old versions there would not test their compatibility.

-MarkM-
hero member
Activity: 588
Merit: 500
Core Dev are always having to maintain the engines on a jet aeroplane flying at 35,000 feet. I don't notice any oil on your hands!

Yep.  Backseat driving is rampant on this forum.  We have geniuses coming out of the woodwork who demand Bitcoin developers be exempted from fundamental laws of mathematics and produce 100% perfect software.  

Hint: look up "Halting Problem".

There will be bugs.  Always.  Either contribute to the testing & development cycle with your time or money, or stop complaining.

hero member
Activity: 490
Merit: 500
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7

Indeed, the testing should have been conducted in the three years since Bitcoin was released. It's appalling how the edge conditions were never tested.

Not sure backward compatibility is an edge case.... generally its a big deal you plan a transition for.  What happened here was a rushed satoshi dice bailout with much discussion on filtering out their transactions while a real solution could be worked on.... which now leaves everyone feeling the pain instead of a single entertainment site.
legendary
Activity: 1246
Merit: 1077
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7

Indeed, the testing should have been conducted in the three years since Bitcoin was released. It's appalling how the edge conditions were never tested.
gst
newbie
Activity: 38
Merit: 0
What the hell are the devs thinking? What is the testnet for? Testnet is not only to test userland code, but it is a fine place to test mining code too damnit!

So are you paying the devs for developing the Bitcoin software? And why didn't YOU test the code in testnet before it was released as 0.8?
legendary
Activity: 1400
Merit: 1013
incompatibility between versions should be called (at least) an issue imho...
My point was that exhaustive testing of 0.8 would never have revealed the bug in 0.7 that nobody knew about.

Unit testing to make sure the code was actually capable of operating at the protocol limits would have caught the problem had it been performed on 0.7
sr. member
Activity: 532
Merit: 261
­バカ
Seriously, you made TWO major changes at once (block size and database type) at once... And deployed in production and partially only (because not all people upgraded).
The problem is older than you think. 0.8 is fine (at least with regards to the current problem). 0.7 had a bug in it and consequently is not capable of handling what it's supposed to be able to handle.
incompatibility between versions should be called (at least) an issue imho...
legendary
Activity: 1400
Merit: 1013
I wonder where Gavin is?

Did he make any statement? I dont see him posting comments in the sticky thread.

Probably has more important coding-related things to do right now.
sr. member
Activity: 462
Merit: 250
I wonder where Gavin is?

Did he make any statement? I dont see him posting comments in the sticky thread.
legendary
Activity: 1596
Merit: 1012
Democracy is vulnerable to a 51% attack.
Are my bitcoins worthless now?
If you've had bitcoins sitting in a wallet since before this happened, they are safe. Just don't do anything with them until the problem is resolved.
legendary
Activity: 1400
Merit: 1013
Ironically, more testing on testnet would not have helped this issue. Significantly less may have, as the network would have more time to upgrade.
This might have helped:

https://bitcointalksearch.org/topic/unit-tests-56323
legendary
Activity: 1078
Merit: 1006
100 satoshis -> ISO code
Seriously, you made TWO major changes at once (block size and database type) at once... And deployed in production and partially only (because not all people upgraded).

What the hell are the devs thinking? What is the testnet for? Testnet is not only to test userland code, but it is a fine place to test mining code too damnit!

Now know that from now on, you should ALWAYS test stuff like this on Testnet first.

Core Dev are always having to maintain the engines on a jet aeroplane flying at 35,000 feet. I don't notice any oil on your hands!
legendary
Activity: 1246
Merit: 1077
Ironically, more testing on testnet would not have helped this issue. Significantly less may have, as the network would have more time to upgrade.

I think the blame rests upon miners and merchants here. Miners should always upgrade and merchants should run FAN nodes.
legendary
Activity: 1400
Merit: 1013
Seriously, you made TWO major changes at once (block size and database type) at once... And deployed in production and partially only (because not all people upgraded).
The problem is older than you think. 0.8 is fine (at least with regards to the current problem). 0.7 had a bug in it and consequently is not capable of handling what it's supposed to be able to handle.
legendary
Activity: 1806
Merit: 1003
Seriously, you made TWO major changes at once (block size and database type) at once... And deployed in production and partially only (because not all people upgraded).

What the hell are the devs thinking? What is the testnet for? Testnet is not only to test userland code, but it is a fine place to test mining code too damnit!

Now know that from now on, you should ALWAYS test stuff like this on Testnet first.

I assume this has something to do with the kind of worrying "Critical: Current Bitcoin network fork. Action needed by mining pools. Merchants should hold transactions.".

Are my bitcoins worthless now?

Some people are reporting missing coins from very recent transactions, you better check your wallet to make sure.
hero member
Activity: 994
Merit: 501
PredX - AI-Powered Prediction Market
Seriously, you made TWO major changes at once (block size and database type) at once... And deployed in production and partially only (because not all people upgraded).

What the hell are the devs thinking? What is the testnet for? Testnet is not only to test userland code, but it is a fine place to test mining code too damnit!

Now know that from now on, you should ALWAYS test stuff like this on Testnet first.
Pages:
Jump to: