[ANN] NDL - The coin for Pastafarians - Flying Spaghetti Monster Cryptocurrency! - page 12.

Chicago

sr. member

Activity: 592

Merit: 259

Quote from: number435398 on November 14, 2018, 09:20:24 AM

I keep asking you to provide a measurable issue with the wallet, and you refuse to do so.

Your README.md says,

Code:

If you mine to an old address that is in a wallet.dat file that this wallet opens, it will reflect in this wallet.  If you mine to an address that is created by this wallet, your mining will NOT be reflected on the balance sheet.

Do you think that is a showstopper? I think it will make new users scared.

Chicago

sr. member

Activity: 592

Merit: 259

... the chutzpa on this guy, refusing a code review.

Most people would beg for someone to find and fix their bugs.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 09:15:47 AM

Quote from: number435398 on November 14, 2018, 09:12:31 AM

Wow, that is probably the weirdest response you could have given me.

I am detail oriented.
I already know the problem is that you're not familiar enough with git to use it correctly and so to provide a solution, I need to know what was done poorly.

Okay, I'm done entertaining you. I'm done with your direct insults, I'm done with your indirect insults. All you've done is waste my time. Those shell files requiring that you right click them is not relevant to the functionality of the wallet or the blockchain at all. If you don't like it, use the pre-compiled binaries. I keep asking you to provide a measurable issue with the wallet, and you refuse to do so. If you can't be detailed on that, then you aren't providing me with any detail of value.

Anyone else have any concerns regarding the wallet's functionality? Anyone testing it by chance?

Chicago

sr. member

Activity: 592

Merit: 259

Quote from: number435398 on November 14, 2018, 09:12:31 AM

Wow, that is probably the weirdest response you could have given me.

I am detail oriented.
I already know the problem is that you're not familiar enough with git to use it correctly and so to provide a solution, I need to know what was done poorly.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 09:04:42 AM

Quote from: number435398 on November 14, 2018, 09:01:52 AM

To what end?

To look for mistakes.

Wow, that is probably the weirdest response you could have given me. I think you've reached a point to where this has become an unhealthy obsession.

There aren't even any errors you're seeking to verify or confirm since you don't seem to be testing the new wallet. So...you don't even have anything specific you're looking for. Which seems to suggest you plan on going over every single line of code without a measurable issue to find.

If you want to help, test the working wallet.

If there were glitches we couldn't explain, that might make sense, but there's no confirmation of any issues that would require looking through every line of code I changed.

Chicago

sr. member

Activity: 592

Merit: 259

This snippet is pretty interesting from git.

It shows exactly which files had their mode changed from executable as well as all of the extra files which are only there because the start of your project was with a 0.16 branch clone.

Things beginning with "mode change" are files which should have stayed executable.
Things beginning with "create mode" are files which do not exist in Litecoin v0.15.1 but do exist in your repository.

Code:

[master 9099a2d] number435398
 615 files changed, 40819 insertions(+), 4627 deletions(-)
 rewrite README.md (92%)
 mode change 100755 => 100644 autogen.sh
 mode change 100755 => 100644 contrib/debian/rules
 mode change 100755 => 100644 contrib/devtools/check-doc.py
 create mode 100644 contrib/devtools/check-rpc-mappings.py
 mode change 100755 => 100644 contrib/devtools/clang-format-diff.py
 mode change 100755 => 100644 contrib/devtools/commit-script-check.sh
 mode change 100755 => 100644 contrib/devtools/copyright_header.py
 mode change 100755 => 100644 contrib/devtools/gen-manpages.sh
 mode change 100755 => 100644 contrib/devtools/git-subtree-check.sh
 mode change 100755 => 100644 contrib/devtools/github-merge.py
 create mode 100644 contrib/devtools/lint-all.sh
 create mode 100644 contrib/devtools/lint-python.sh
 create mode 100644 contrib/devtools/lint-whitespace.sh
 mode change 100755 => 100644 contrib/devtools/optimize-pngs.py
 mode change 100755 => 100644 contrib/devtools/security-check.py
 mode change 100755 => 100644 contrib/devtools/symbol-check.py
 mode change 100755 => 100644 contrib/devtools/test-security-check.py
 mode change 100755 => 100644 contrib/devtools/update-translations.py
 mode change 100755 => 100644 contrib/filter-lcov.py
 mode change 100755 => 100644 contrib/gitian-build.sh
 create mode 100644 contrib/gitian-keys/meshcollider-key.pgp
 create mode 100644 contrib/gitian-keys/sjors-key.pgp
 create mode 100644 contrib/gitian-keys/willyko-key.pgp
 create mode 100644 contrib/install_db4.sh
 mode change 100755 => 100644 contrib/linearize/linearize-data.py
 mode change 100755 => 100644 contrib/linearize/linearize-hashes.py
 mode change 100755 => 100644 contrib/macdeploy/custom_dsstore.py
 mode change 100755 => 100644 contrib/macdeploy/detached-sig-apply.sh
 mode change 100755 => 100644 contrib/macdeploy/detached-sig-create.sh
 mode change 100755 => 100644 contrib/macdeploy/extract-osx-sdk.sh
 mode change 100755 => 100644 contrib/macdeploy/macdeployqtplus
 rewrite contrib/qos/README.md (82%)
 mode change 100755 => 100644 contrib/seeds/generate-seeds.py
 mode change 100755 => 100644 contrib/seeds/makeseeds.py
 mode change 100755 => 100644 contrib/spendfrom/spendfrom.py
 mode change 100755 => 100644 contrib/testgen/gen_base58_test_vectors.py
 mode change 100755 => 100644 contrib/tidy_datadir.sh
 create mode 100644 contrib/valgrind.supp
 mode change 100755 => 100644 contrib/verify-commits/gpg.sh
 mode change 100755 => 100644 contrib/verify-commits/pre-push-hook.sh
 mode change 100755 => 100644 contrib/verify-commits/verify-commits.sh
 mode change 100755 => 100644 contrib/verifybinaries/verify.sh
 mode change 100755 => 100644 contrib/windeploy/detached-sig-create.sh
 mode change 100755 => 100644 contrib/zmq/zmq_sub.py
 mode change 100755 => 100644 contrib/zmq/zmq_sub3.4.py
 mode change 100755 => 100644 depends/config.guess
 mode change 100755 => 100644 depends/config.sub
 create mode 100644 doc/build-netbsd.md
 create mode 100644 doc/dependencies.md
 create mode 100644 doc/litecoin-release-notes/release-notes-0.15.1.md
 create mode 100644 doc/man/noodlyappendagecoin-cli.1
 create mode 100644 doc/man/noodlyappendagecoin-qt.1
 create mode 100644 doc/man/noodlyappendagecoin-tx.1
 create mode 100644 doc/man/noodlyappendagecoind.1
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.10.2.2.md
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.10.4.md
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.13.2.md
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.13.3.md
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.14.2.md
 create mode 100644 doc/noodlyappendagecoin-release-notes/release-notes-0.15.0.1.md
 create mode 100644 doc/release-notes/release-notes-0.15.1.md
 create mode 100644 noodlyappendagecoin-qt 32 bit with new pchmessage.exe
 create mode 100644 noodlyappendagecoin-qt 32 bit.exe
 create mode 100644 noodlyappendagecoin-qt TEST ONLY.exe
 create mode 100644 noodlyappendagecoin-qt with new pchmessage.exe
 create mode 100644 noodlyappendagecoin-qt.exe
 mode change 100755 => 100644 share/genbuild.sh
 mode change 100755 => 100644 share/qt/extract_strings_qt.py
 create mode 100644 share/rpcauth/README.md
 create mode 100644 share/rpcauth/rpcauth.py
 mode change 100755 => 100644 share/rpcuser/rpcuser.py
 create mode 100644 src/bech32.cpp
 create mode 100644 src/bech32.h
 mode change 100755 => 100644 src/bench/data/block413567.raw
 rewrite src/chainparamsseeds.h (98%)
 mode change 100755 => 100644 src/leveldb/build_detect_platform
 create mode 100644 src/qt/locale/bitcoin_am.ts
 create mode 100644 src/qt/locale/bitcoin_cs_CZ.ts
 create mode 100644 src/qt/locale/bitcoin_hu_HU.ts
 create mode 100644 src/qt/locale/bitcoin_is.ts
 create mode 100644 src/qt/locale/bitcoin_km_KH.ts
 create mode 100644 src/qt/locale/bitcoin_ko.ts
 create mode 100644 src/qt/locale/bitcoin_ml.ts
 create mode 100644 src/qt/locale/bitcoin_mr_IN.ts
 create mode 100644 src/qt/locale/bitcoin_ms.ts
 create mode 100644 src/qt/locale/bitcoin_pl_PL.ts
 create mode 100644 src/qt/locale/bitcoin_pt.ts
 create mode 100644 src/qt/locale/bitcoin_sn.ts
 create mode 100644 src/qt/locale/bitcoin_ta_IN.ts
 create mode 100644 src/qt/locale/bitcoin_zh-Hans.ts
 rewrite src/qt/res/icons/about.png (99%)
 rewrite src/qt/res/icons/about_qt.png (99%)
 rewrite src/qt/res/icons/add.png (98%)
 rewrite src/qt/res/icons/address-book.png (99%)
 rewrite src/qt/res/icons/bitcoin.icns (99%)
 rewrite src/qt/res/icons/bitcoin.ico (99%)
 mode change 100755 => 100644
 rewrite src/qt/res/icons/bitcoin.png (98%)
 mode change 100755 => 100644
 rewrite src/qt/res/icons/bitcoin_testnet.ico (97%)
 create mode 100644 src/qt/res/icons/bitcoin_testnet.png
 rewrite src/qt/res/icons/chevron.png (99%)
 rewrite src/qt/res/icons/clock1.png (99%)
 rewrite src/qt/res/icons/clock2.png (99%)
 rewrite src/qt/res/icons/clock3.png (99%)
 rewrite src/qt/res/icons/clock4.png (99%)
 rewrite src/qt/res/icons/clock5.png (99%)
 rewrite src/qt/res/icons/configure.png (99%)
 rewrite src/qt/res/icons/connect0.png (99%)
 create mode 100644 src/qt/res/icons/connect0_16.png
 rewrite src/qt/res/icons/connect1.png (99%)
 create mode 100644 src/qt/res/icons/connect1_16.png
 rewrite src/qt/res/icons/connect2.png (99%)
 create mode 100644 src/qt/res/icons/connect2_16.png
 rewrite src/qt/res/icons/connect3.png (99%)
 create mode 100644 src/qt/res/icons/connect3_16.png
 rewrite src/qt/res/icons/connect4.png (99%)
 create mode 100644 src/qt/res/icons/connect4_16.png
 rewrite src/qt/res/icons/debugwindow.png (99%)
 rewrite src/qt/res/icons/edit.png (99%)
 rewrite src/qt/res/icons/editcopy.png (99%)
 rewrite src/qt/res/icons/editpaste.png (99%)
 rewrite src/qt/res/icons/export.png (99%)
 rewrite src/qt/res/icons/eye.png (99%)
 rewrite src/qt/res/icons/eye_minus.png (99%)
 rewrite src/qt/res/icons/eye_plus.png (99%)
 create mode 100644 src/qt/res/icons/favicon.ico
 rewrite src/qt/res/icons/filesave.png (99%)
 rewrite src/qt/res/icons/fontbigger.png (99%)
 rewrite src/qt/res/icons/fontsmaller.png (99%)
 rewrite src/qt/res/icons/hd_disabled.png (99%)
 rewrite src/qt/res/icons/hd_enabled.png (99%)
 rewrite src/qt/res/icons/history.png (98%)
 rewrite src/qt/res/icons/info.png (99%)
 rewrite src/qt/res/icons/key.png (99%)
 create mode 100644 src/qt/res/icons/litecoin.icns
 create mode 100644 src/qt/res/icons/litecoin.ico
 create mode 100644 src/qt/res/icons/litecoin.png
 rewrite src/qt/res/icons/litecoin_splash.png (96%)
 mode change 100755 => 100644
 rewrite src/qt/res/icons/lock_closed.png (99%)
 rewrite src/qt/res/icons/lock_open.png (99%)
 create mode 100644 src/qt/res/icons/mining.png
 create mode 100644 src/qt/res/icons/mining_active.png
 create mode 100644 src/qt/res/icons/mining_inactive.png
 rewrite src/qt/res/icons/network_disabled.png (99%)
 create mode 100644 src/qt/res/icons/noodlyappendagecoin.icns
 create mode 100644 src/qt/res/icons/noodlyappendagecoin.ico
 create mode 100644 src/qt/res/icons/noodlyappendagecoin.png
 create mode 100644 src/qt/res/icons/noodlyappendagecoin_splash.png
 create mode 100644 src/qt/res/icons/notsynced.png
 rewrite src/qt/res/icons/open.png (99%)
 rewrite src/qt/res/icons/overview.png (99%)
 create mode 100644 src/qt/res/icons/qrcode.png
 rewrite src/qt/res/icons/quit.png (99%)
 rewrite src/qt/res/icons/receive.png (99%)
 rewrite src/qt/res/icons/remove.png (99%)
 rewrite src/qt/res/icons/send.png (99%)
 create mode 100644 src/qt/res/icons/splash_testnet.png
 rewrite src/qt/res/icons/synced.png (99%)
 create mode 100644 src/qt/res/icons/toolbar.png
 create mode 100644 src/qt/res/icons/toolbar_testnet.png
 rewrite src/qt/res/icons/transaction0.png (99%)
 rewrite src/qt/res/icons/transaction2.png (99%)
 rewrite src/qt/res/icons/transaction_abandoned.png (99%)
 create mode 100644 src/qt/res/icons/transaction_bandoned.png
 rewrite src/qt/res/icons/transaction_conflicted.png (99%)
 rewrite src/qt/res/icons/tx_inout.png (99%)
 rewrite src/qt/res/icons/tx_input.png (99%)
 rewrite src/qt/res/icons/tx_mined.png (99%)
 rewrite src/qt/res/icons/tx_output.png (99%)
 rewrite src/qt/res/icons/verify.png (99%)
 create mode 100644 src/qt/res/icons/wallet.png
 rewrite src/qt/res/icons/warning.png (99%)
 create mode 100644 src/qt/res/images/about.png
 create mode 100644 src/qt/res/images/splash.png
 create mode 100644 src/qt/res/images/splash_testnet.png
 create mode 100644 src/qt/res/images/wallet.png
 mode change 100755 => 100644 src/qt/res/movies/makespinner.sh
 create mode 100644 src/rpc/safemode.cpp
 create mode 100644 src/rpc/safemode.h
 create mode 100644 src/rpc/util.cpp
 create mode 100644 src/rpc/util.h
 mode change 100755 => 100644 src/secp256k1/autogen.sh
 mode change 100755 => 100644 src/secp256k1/src/modules/recovery/main_impl.h
 create mode 100644 src/test/bech32_tests.cpp
 create mode 100644 src/test/blockchain_tests.cpp
 create mode 100644 src/test/merkleblock_tests.cpp
 create mode 100644 src/test/txvalidation_tests.cpp
 create mode 100644 src/test/validation_block_tests.cpp
 create mode 100644 src/univalue/README.md
 mode change 100755 => 100644 src/univalue/autogen.sh
 create mode 100644 src/univalue/lib/univalue_get.cpp
 create mode 100644 src/univalue/test/fail42.json
 create mode 100644 src/univalue/test/fail44.json
 create mode 100644 src/univalue/test/no_nul.cpp
 create mode 100644 src/univalue/test/object.cpp
 create mode 100644 src/univalue/test/round3.json
 create mode 100644 src/univalue/test/round4.json
 create mode 100644 src/univalue/test/round5.json
 create mode 100644 src/univalue/test/round6.json
 create mode 100644 src/univalue/test/round7.json
 create mode 100644 src/univalue/test/test_json.cpp
 create mode 100644 src/wallet/fees.cpp
 create mode 100644 src/wallet/fees.h
 create mode 100644 src/wallet/init.cpp
 create mode 100644 src/wallet/init.h
 create mode 100644 src/wallet/walletutil.cpp
 create mode 100644 src/wallet/walletutil.h
 mode change 100755 => 100644 test/functional/abandonconflict.py
 mode change 100755 => 100644 test/functional/assumevalid.py
 mode change 100755 => 100644 test/functional/bip65-cltv-p2p.py
 mode change 100755 => 100644 test/functional/bip68-112-113-p2p.py
 mode change 100755 => 100644 test/functional/bip68-sequence.py
 mode change 100755 => 100644 test/functional/bip9-softforks.py
 mode change 100755 => 100644 test/functional/bipdersig-p2p.py
 mode change 100755 => 100644 test/functional/bitcoin_cli.py
 mode change 100755 => 100644 test/functional/blockchain.py
 mode change 100755 => 100644 test/functional/bumpfee.py
 mode change 100755 => 100644 test/functional/combine_logs.py
 mode change 100755 => 100644 test/functional/create_cache.py
 mode change 100755 => 100644 test/functional/dbcrash.py
 mode change 100755 => 100644 test/functional/decodescript.py
 mode change 100755 => 100644 test/functional/disablewallet.py
 mode change 100755 => 100644 test/functional/disconnect_ban.py
 mode change 100755 => 100644 test/functional/example_test.py
 create mode 100644 test/functional/feature_assumevalid.py
 create mode 100644 test/functional/feature_bip68_sequence.py
 create mode 100644 test/functional/feature_bip9_softforks.py
 create mode 100644 test/functional/feature_block.py
 create mode 100644 test/functional/feature_cltv.py
 create mode 100644 test/functional/feature_config_args.py
 create mode 100644 test/functional/feature_csv_activation.py
 create mode 100644 test/functional/feature_dbcrash.py
 create mode 100644 test/functional/feature_dersig.py
 create mode 100644 test/functional/feature_fee_estimation.py
 create mode 100644 test/functional/feature_help.py
 create mode 100644 test/functional/feature_logging.py
 create mode 100644 test/functional/feature_maxuploadtarget.py
 create mode 100644 test/functional/feature_minchainwork.py
 create mode 100644 test/functional/feature_notifications.py
 create mode 100644 test/functional/feature_nulldummy.py
 create mode 100644 test/functional/feature_proxy.py
 create mode 100644 test/functional/feature_pruning.py
 create mode 100644 test/functional/feature_rbf.py
 create mode 100644 test/functional/feature_reindex.py
 create mode 100644 test/functional/feature_segwit.py
 create mode 100644 test/functional/feature_uacomment.py
 create mode 100644 test/functional/feature_versionbits_warning.py
 mode change 100755 => 100644 test/functional/forknotify.py
 mode change 100755 => 100644 test/functional/fundrawtransaction.py
 mode change 100755 => 100644 test/functional/getblocktemplate_longpoll.py
 mode change 100755 => 100644 test/functional/getchaintips.py
 mode change 100755 => 100644 test/functional/httpbasics.py
 mode change 100755 => 100644 test/functional/import-rescan.py
 mode change 100755 => 100644 test/functional/importmulti.py
 mode change 100755 => 100644 test/functional/importprunedfunds.py
 create mode 100644 test/functional/interface_bitcoin_cli.py
 create mode 100644 test/functional/interface_http.py
 create mode 100644 test/functional/interface_rest.py
 create mode 100644 test/functional/interface_zmq.py
 mode change 100755 => 100644 test/functional/invalidateblock.py
 mode change 100755 => 100644 test/functional/invalidblockrequest.py
 mode change 100755 => 100644 test/functional/invalidtxrequest.py
 mode change 100755 => 100644 test/functional/keypool-topup.py
 mode change 100755 => 100644 test/functional/keypool.py
 mode change 100755 => 100644 test/functional/listsinceblock.py
 mode change 100755 => 100644 test/functional/listtransactions.py
 mode change 100755 => 100644 test/functional/maxuploadtarget.py
 mode change 100755 => 100644 test/functional/mempool_limit.py
 mode change 100755 => 100644 test/functional/mempool_packages.py
 mode change 100755 => 100644 test/functional/mempool_persist.py
 mode change 100755 => 100644 test/functional/mempool_reorg.py
 create mode 100644 test/functional/mempool_resurrect.py
 mode change 100755 => 100644 test/functional/mempool_resurrect_test.py
 create mode 100644 test/functional/mempool_spend_coinbase.py
 mode change 100755 => 100644 test/functional/mempool_spendcoinbase.py
 mode change 100755 => 100644 test/functional/merkle_blocks.py
 mode change 100755 => 100644 test/functional/minchainwork.py
 mode change 100755 => 100644 test/functional/mining.py
 create mode 100644 test/functional/mining_basic.py
 create mode 100644 test/functional/mining_getblocktemplate_longpoll.py
 create mode 100644 test/functional/mining_prioritisetransaction.py
 mode change 100755 => 100644 test/functional/multi_rpc.py
 mode change 100755 => 100644 test/functional/multiwallet.py
 mode change 100755 => 100644 test/functional/net.py
 mode change 100755 => 100644 test/functional/nulldummy.py
 mode change 100755 => 100644 test/functional/p2p-acceptblock.py
 mode change 100755 => 100644 test/functional/p2p-compactblocks.py
 mode change 100755 => 100644 test/functional/p2p-feefilter.py
 mode change 100755 => 100644 test/functional/p2p-fullblocktest.py
 mode change 100755 => 100644 test/functional/p2p-leaktests.py
 mode change 100755 => 100644 test/functional/p2p-mempool.py
 mode change 100755 => 100644 test/functional/p2p-segwit.py
 mode change 100755 => 100644 test/functional/p2p-timeouts.py
 mode change 100755 => 100644 test/functional/p2p-versionbits-warning.py
 create mode 100644 test/functional/p2p_compactblocks.py
 create mode 100644 test/functional/p2p_disconnect_ban.py
 create mode 100644 test/functional/p2p_feefilter.py
 create mode 100644 test/functional/p2p_fingerprint.py
 create mode 100644 test/functional/p2p_invalid_block.py
 create mode 100644 test/functional/p2p_invalid_tx.py
 create mode 100644 test/functional/p2p_leak.py
 create mode 100644 test/functional/p2p_mempool.py
 create mode 100644 test/functional/p2p_node_network_limited.py
 create mode 100644 test/functional/p2p_segwit.py
 create mode 100644 test/functional/p2p_sendheaders.py
 create mode 100644 test/functional/p2p_timeouts.py
 create mode 100644 test/functional/p2p_unrequested_blocks.py
 mode change 100755 => 100644 test/functional/preciousblock.py
 mode change 100755 => 100644 test/functional/prioritise_transaction.py
 mode change 100755 => 100644 test/functional/proxy_test.py
 mode change 100755 => 100644 test/functional/pruning.py
 mode change 100755 => 100644 test/functional/rawtransactions.py
 mode change 100755 => 100644 test/functional/receivedby.py
 mode change 100755 => 100644 test/functional/reindex.py
 mode change 100755 => 100644 test/functional/replace-by-fee.py
 mode change 100755 => 100644 test/functional/resendwallettransactions.py
 mode change 100755 => 100644 test/functional/rest.py
 create mode 100644 test/functional/rpc_bind.py
 create mode 100644 test/functional/rpc_blockchain.py
 create mode 100644 test/functional/rpc_decodescript.py
 create mode 100644 test/functional/rpc_deprecated.py
 create mode 100644 test/functional/rpc_fundrawtransaction.py
 create mode 100644 test/functional/rpc_getchaintips.py
 create mode 100644 test/functional/rpc_invalidateblock.py
 create mode 100644 test/functional/rpc_listtransactions.py
 create mode 100644 test/functional/rpc_named_arguments.py
 create mode 100644 test/functional/rpc_net.py
 create mode 100644 test/functional/rpc_preciousblock.py
 create mode 100644 test/functional/rpc_rawtransaction.py
 create mode 100644 test/functional/rpc_signmessage.py
 create mode 100644 test/functional/rpc_signrawtransaction.py
 create mode 100644 test/functional/rpc_txoutproof.py
 create mode 100644 test/functional/rpc_uptime.py
 create mode 100644 test/functional/rpc_users.py
 mode change 100755 => 100644 test/functional/rpcbind_test.py
 mode change 100755 => 100644 test/functional/rpcnamedargs.py
 mode change 100755 => 100644 test/functional/segwit.py
 mode change 100755 => 100644 test/functional/sendheaders.py
 mode change 100755 => 100644 test/functional/signmessages.py
 mode change 100755 => 100644 test/functional/signrawtransactions.py
 mode change 100755 => 100644 test/functional/smartfees.py
 mode change 100755 => 100644 test/functional/test_framework/comptool.py
 create mode 100644 test/functional/test_framework/messages.py
 mode change 100755 => 100644 test/functional/test_framework/mininode.py
 create mode 100644 test/functional/test_framework/segwit_addr.py
 mode change 100755 => 100644 test/functional/test_framework/test_framework.py
 mode change 100755 => 100644 test/functional/test_framework/test_node.py
 mode change 100755 => 100644 test/functional/test_runner.py
 mode change 100755 => 100644 test/functional/test_script_address2.py
 mode change 100755 => 100644 test/functional/txn_clone.py
 mode change 100755 => 100644 test/functional/txn_doublespend.py
 mode change 100755 => 100644 test/functional/uptime.py
 mode change 100755 => 100644 test/functional/wallet-accounts.py
 mode change 100755 => 100644 test/functional/wallet-dump.py
 mode change 100755 => 100644 test/functional/wallet-encryption.py
 mode change 100755 => 100644 test/functional/wallet-hd.py
 mode change 100755 => 100644 test/functional/wallet.py
 create mode 100644 test/functional/wallet_abandonconflict.py
 create mode 100644 test/functional/wallet_accounts.py
 create mode 100644 test/functional/wallet_address_types.py
 create mode 100644 test/functional/wallet_backup.py
 create mode 100644 test/functional/wallet_basic.py
 create mode 100644 test/functional/wallet_bumpfee.py
 create mode 100644 test/functional/wallet_disable.py
 create mode 100644 test/functional/wallet_dump.py
 create mode 100644 test/functional/wallet_encryption.py
 create mode 100644 test/functional/wallet_hd.py
 create mode 100644 test/functional/wallet_import_rescan.py
 create mode 100644 test/functional/wallet_importmulti.py
 create mode 100644 test/functional/wallet_importprunedfunds.py
 create mode 100644 test/functional/wallet_keypool.py
 create mode 100644 test/functional/wallet_keypool_topup.py
 create mode 100644 test/functional/wallet_listreceivedby.py
 create mode 100644 test/functional/wallet_listsinceblock.py
 create mode 100644 test/functional/wallet_multiwallet.py
 create mode 100644 test/functional/wallet_resendwallettransactions.py
 create mode 100644 test/functional/wallet_scriptaddress2.py
 create mode 100644 test/functional/wallet_txn_clone.py
 create mode 100644 test/functional/wallet_txn_doublespend.py
 create mode 100644 test/functional/wallet_zapwallettxes.py
 mode change 100755 => 100644 test/functional/walletbackup.py
 mode change 100755 => 100644 test/functional/zapwallettxes.py
 mode change 100755 => 100644 test/functional/zmq_test.py
 mode change 100755 => 100644 test/util/bitcoin-util-test.py
 create mode 100644 trythis

Chicago

sr. member

Activity: 592

Merit: 259

Quote from: number435398 on November 14, 2018, 09:01:52 AM

To what end?

To look for mistakes.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 08:52:55 AM

Side note, I made this repository which does a comparison of your work to Litecoin v0.15.1.
It shows all of the differences in this commit.

To what end?

Chicago

sr. member

Activity: 592

Merit: 259

Side note, I made this repository which does a comparison of your work to Litecoin v0.15.1.
It shows all of the differences in this commit.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 07:19:44 AM

Using unmodified Litecoin v0.15.1 as follows, there is no build error.
Hence, something must have become broken sometime between your clone and your commit to GitHub.

Code:

git clone https://github.com/litecoin-project/litecoin
cd litecoin/
git checkout v0.15.1
./autogen.sh 
./configure
make -j13
make check

I don't disagree. A rough edge at worse. Though, not being a functionality issue, I haven't prioritized fixing it. It can be fixed without the need of releasing a whole new version of the wallet.

The wallet being functional is the most important thing. Trivial compile issues that are easily fixed are just red herrings.

Look up Teslacoin. Their compile instructions didn't work for me, and they didn't even respond with a fix that was big, small, temporary, or long term. Its been 5 months. Their coin is worth upwards of like 200 satoshi each.

https://github.com/TeslacoinFoundation/TeslacoinCore/issues/11

At least mine can actually be compiled with a couple of extra steps.

Have you noticed any functionality issues with the compiled wallet? Transaction errors or the like?

Chicago

sr. member

Activity: 592

Merit: 259

Using unmodified Litecoin v0.15.1 as follows, there is no build error.
Hence, something must have become broken sometime between your clone and your commit to GitHub.

Code:

git clone https://github.com/litecoin-project/litecoin
cd litecoin/
git checkout v0.15.1
./autogen.sh 
./configure
make -j13
make check

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 05:30:14 AM

Files that are supposed to be executable aren't executable in your repository.

For example, autogen.sh needs to be executable but it isn't.
Also, /share/genbuild.sh needs to be executable but it isn't.

I suspect others will also run into Issue 510.

You are correct.

Quote from: number435398 on November 04, 2018, 02:26:18 PM

To build it, if you have all the dependencies type ./trythis; or edit the trythis file and you'll see the necessary commands, whichever you prefer. Just make sure trythis, autogen.sh, configure.ac and /share/genbuild.sh are set to "Allow executing file as program". For some reason I have to continually change that.

I referenced that as an issue that I was unaware of a solution to. You have to right click them, go to properties, then permissions, then select the "Execute file as program" check-box on each of those 4 files in ubuntu. You may have to do that to trythis as well as configure.ac. I'm guessing it *could* be some sort of security thing in ubuntu, I'm not really sure. If I take my main folder that contains the files and change them, then copy them to ubuntu, the copies lose that designation for some reason.

Edit: If you know an easy way to fix that, I would be happy to implement the fix.

Chicago

sr. member

Activity: 592

Merit: 259

Files that are supposed to be executable aren't executable in your repository.

For example, autogen.sh needs to be executable but it isn't.
Also, /share/genbuild.sh needs to be executable but it isn't.

I suspect others will also run into Issue 510.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 02:11:27 AM

Dude... first you tell us you're magically corrupting files when transferring them from Windows to Linux.

No, that was a flash drive I was using that was corrupting my files. It wasn't me.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet.

Quote

Then I see your repository starts with the 0.16 code and that you just added the 0.15 code on top of it.
Then you tell us "its all okay except it can't keep track of your balance or import a paper wallet"

Yes, I was keeping you apprised of my progress and issues I was working out. I was keeping you guys in the loop. Should I not have done that? Version 16 has a lot more code tweaks I couldn't account for and there were measurable issues. So I changed it. Therefor I stopped using it to avoid the measurable problems I had with it and began using v15 instead so that those issues no longer existed and I could release a functional wallet.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet.

Quote

Then I see you've selected yet another network ID to further disrupt consensus.

"Yet another"? I've been talking about changing the pchmessage code for a while now. At least since October 6th, before you released your fork. You were the one who changed it the first time, without consensus. You arbitrarily changed it for your own little fork, but if we're all updating to new wallets, it won't matter anyhow. We can change it to whatever we want and with only the new wallets working with the forks to begin with, its a perfect and rather ideal time to change the pchmessage code to something not shared by litecoin.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet.

Quote

Add to that not actually using Super Majority for BIP 66 and BIP 65.

So, what measurable harm is that doing? Nothing, as far as I can see.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet.

Quote

Add to that not using Gitian to produce deterministic builds.

That is in the category of "bells and whistles" and has no bearing on the functionality of the wallet or the blockchain itself and therefor not cause to dump my new version. Not to mention that can be done at a later time without impacting the wallet or releasing a new version.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet.

Quote

I don't want to start nitpicking, but look here.

Then look at this output and tell me why 1537616302 is in your code.

noodlyappendagecoind getblock d28dd9b4ae980c409440dfbd2d743696a88901dfc3520d70e8d69cb0416053ba
{
"hash" : "d28dd9b4ae980c409440dfbd2d743696a88901dfc3520d70e8d69cb0416053ba",
"confirmations" : 18904,
"size" : 189,
"height" : 1300000,
"version" : 2,
"merkleroot" : "d0244b9a2aca4d81c918fc0a8064bbaa91656c79b8743f4f7fb516cb0c0e4981",
"tx" : [
"d0244b9a2aca4d81c918fc0a8064bbaa91656c79b8743f4f7fb516cb0c0e4981"
],
"time" : 1538619046,
"nonce" : 21270,
"bits" : "1e0a3b9c",
"difficulty" : 0.00038173,
"previousblockhash" : "e506e0fed6f5922ec8cedf68df41ad0ab0c11aef9c10e3e3e631ad9783f10ab1",
"nextblockhash" : "16d37abd4cbbfe12b289c82f2c0e8e3e7a72da31059141b2ea298d62a4ff4c0e"
}

I don't mind nitpicking, as long as its valid. In the realm of functionality; this is not valid nitpicking and not significant to the concerns you have expressed.

Or are you just trying to dramatize the fact that I put the wrong time stamp in for the block? I think that's because I originally had a different "most recent" checkpoint block than 1300000, and then when I changed it to 1300000 I forgot to update it. It's a trivial error that has no functional impact on the wallet or the blockchain. I have updated the code to reflect the correct timestamp. When finalizing it with a much more recent block I would have changed it anyhow, but either way, that is an objective existing error you caught and I have fixed it.

At this time, this concern of yours has no measurable bearing on the functionality of my wallet (nor did it before I fixed it).

Nothing, thus far presented, negatively impacts the wallet or the blockchain in any measurable way. Therefor, there is no measurable reason to scrap my new wallet as of yet.

And if you're testing my wallet now, go ahead; wipe the noodlyappendagecoin folder clean and start it anew and make it download the whole blockchain. Takes a while, but some errors only crop up if you make it download the whole blockchain anew. How do I know? Because I had those errors and fixed them. Because I've already spent substantial amounts of time testing my wallet. Downloaded the whole blockchain over a dozen times. Why? To find the errors before others do; to streamline the process. Because I'm not trying to half-ass this thing like the dev that so concerned you with that "other" alt-coin.

Chicago

sr. member

Activity: 592

Merit: 259

Dude... first you tell us you're magically corrupting files when transferring them from Windows to Linux.
Then I see your repository starts with the 0.16 code and that you just added the 0.15 code on top of it.
Then you tell us "its all okay except it can't keep track of your balance or import a paper wallet"
Then I see you've selected yet another network ID to further disrupt consensus.
Add to that not actually using Super Majority for BIP 66 and BIP 65.
Add to that not using Gitian to produce deterministic builds.

I don't want to start nitpicking, but look here.

Then look at this output and tell me why 1537616302 is in your code.

Quote

noodlyappendagecoind getblock d28dd9b4ae980c409440dfbd2d743696a88901dfc3520d70e8d69cb0416053ba
{
"hash" : "d28dd9b4ae980c409440dfbd2d743696a88901dfc3520d70e8d69cb0416053ba",
"confirmations" : 18904,
"size" : 189,
"height" : 1300000,
"version" : 2,
"merkleroot" : "d0244b9a2aca4d81c918fc0a8064bbaa91656c79b8743f4f7fb516cb0c0e4981",
"tx" : [
"d0244b9a2aca4d81c918fc0a8064bbaa91656c79b8743f4f7fb516cb0c0e4981"
],
"time" : 1538619046,
"nonce" : 21270,
"bits" : "1e0a3b9c",
"difficulty" : 0.00038173,
"previousblockhash" : "e506e0fed6f5922ec8cedf68df41ad0ab0c11aef9c10e3e3e631ad9783f10ab1",
"nextblockhash" : "16d37abd4cbbfe12b289c82f2c0e8e3e7a72da31059141b2ea298d62a4ff4c0e"
}

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 14, 2018, 01:46:37 AM

Quote from: number435398 on November 14, 2018, 01:08:14 AM

What built in "fail safe? What "up stream best practices"?

I'm concerned that you keep coming up with weird reasons we can't use my code, but you won't test those reasons.

Its not like I changed 900 lines of code, added 67 lines with 3 new functions etc. I just tweaked a widely accepted coin (litecoin) wallet to work with our coin.

I'm concerned you're just throwing out hypotheticals about what could go wrong and claiming that means we should scrap everything without even verifying if your concerns are relevant.

DNP raised a point I can't dismiss; he was concerned there wasn't enough time for testing. Fine, fair enough, that's something we can talk about. But you just suggest we should scrap everything and that doesn't make any sense.

I tried for months to get someone to code for this wallet, DaveF tried a lot longer than I did. Most coders want hundreds of dollars up front and will charge upwards of a couple thousand dollars by the time they're done. But no one in this community was willing to pay (sans those who may have paid already). Finally, I started working on it (without compensation) and after months of testing and troubleshooting and coding it, I finally did it. Now you're saying we should scrap the thing we've been waiting for for upwards of a couple of years without even testing it because something you're afraid of "might" go wrong? I find fault with your logic.

Hi number435398,

Thanks for your candor.
I am glad we're getting this all out in the open.

I am sure if it were trivial to perform a non-disruptive protocol upgrade from 0.8 to 0.15 then everybody would be doing it.
I've already seen one reckless attempt for this on another coin where a developer came and went and then left consensus in a broken state.
Its true that after the BIPs activate, none of the 0.8 clients will be viable for mining or signing transactions which will require strict DER signatures.

After studying the code for a year, I have simply arrived at a different conclusion then you have.
The options I see moving forward include a 0.13.0 rebase with a hard fork to improve our difficulty adjustment algorithm.

You can try to discuss actual elements of the code or features in the client, but simply calling my criticisms bullshit will not result in a better network.

Best Regards,
-Chicago

I'm not the dev you referenced. I know old clients won't work anymore. Never hid that; we can't upgrade to the new BIPs to become eligible for exchanges without that. Absolute worst case scenario blockchains can be rolled back, but my testing does not indicate any problems at all. I resolved all address issues I could find.

You've come to a "different conclusion"? All you've referenced are "concerns", not actual issues. I get another dev makes you gun-shy but you still have to ground your concerns in actual measurable issues. If you identified a measurable issue, that'd be completely different. If my wallet was constantly deleting your wallet.dat file, yes, that'd be an issue, but that's not happening.

You are still failing in one point; you have yet to demonstrate any fault with my code. You continue to speak of hypothetical worries you have instead of specifically identifying actual issues.

I've posted the code, I've posted the exe's, its all there. Try it.

Worrying that something could go wrong and saying we shouldn't move forward where we can because of your worries is not productive. It's distracting. Pointing out an actual flaw; that'd be productive.

Think of how many things you could have tested on my wallet in the time it's taken you to converse with me regarding your mere hypothetical worries.

Chicago

sr. member

Activity: 592

Merit: 259

Quote from: number435398 on November 14, 2018, 01:08:14 AM

What built in "fail safe? What "up stream best practices"?

I'm concerned that you keep coming up with weird reasons we can't use my code, but you won't test those reasons.

Its not like I changed 900 lines of code, added 67 lines with 3 new functions etc. I just tweaked a widely accepted coin (litecoin) wallet to work with our coin.

I'm concerned you're just throwing out hypotheticals about what could go wrong and claiming that means we should scrap everything without even verifying if your concerns are relevant.

DNP raised a point I can't dismiss; he was concerned there wasn't enough time for testing. Fine, fair enough, that's something we can talk about. But you just suggest we should scrap everything and that doesn't make any sense.

I tried for months to get someone to code for this wallet, DaveF tried a lot longer than I did. Most coders want hundreds of dollars up front and will charge upwards of a couple thousand dollars by the time they're done. But no one in this community was willing to pay (sans those who may have paid already). Finally, I started working on it (without compensation) and after months of testing and troubleshooting and coding it, I finally did it. Now you're saying we should scrap the thing we've been waiting for for upwards of a couple of years without even testing it because something you're afraid of "might" go wrong? I find fault with your logic.

Hi number435398,

Thanks for your candor.
I am glad we're getting this all out in the open.

I am sure if it were trivial to perform a non-disruptive protocol upgrade from 0.8 to 0.15 then everybody would be doing it.
I've already seen one reckless attempt for this on another coin where a developer came and went and then left consensus in a broken state.
Its true that after the BIPs activate, none of the 0.8 clients will be viable for mining or signing transactions which will require strict DER signatures.

After studying the code for a year, I have simply arrived at a different conclusion then you have.
The options I see moving forward include a 0.13.0 rebase with a hard fork to improve our difficulty adjustment algorithm.

You can try to discuss actual elements of the code or features in the client, but simply calling my criticisms bullshit will not result in a better network.

Best Regards,
-Chicago

number435398

jr. member

Activity: 260

Merit: 6

Quote from: Chicago on November 13, 2018, 10:42:08 PM

Quote from: number435398 on November 13, 2018, 10:33:34 PM

Quote from: Chicago on November 04, 2018, 12:17:16 AM

I don't know whether my concerns are well founded.

I don't find your concerns to be well founded.

The difference is that my approach has a builtin fail safe and is done in accordance with the upstream best practices.

What built in "fail safe? What "up stream best practices"?

I'm concerned that you keep coming up with weird reasons we can't use my code, but you won't test those reasons.

Its not like I changed 900 lines of code, added 67 lines with 3 new functions etc. I just tweaked a widely accepted coin (litecoin) wallet to work with our coin.

I'm concerned you're just throwing out hypotheticals about what could go wrong and claiming that means we should scrap everything without even verifying if your concerns are relevant.

DNP raised a point I can't dismiss; he was concerned there wasn't enough time for testing. Fine, fair enough, that's something we can talk about. But you just suggest we should scrap everything and that doesn't make any sense.

I tried for months to get someone to code for this wallet, DaveF tried a lot longer than I did. Most coders want hundreds of dollars up front and will charge upwards of a couple thousand dollars by the time they're done. But no one in this community was willing to pay (sans those who may have paid already). Finally, I started working on it (without compensation) and after months of testing and troubleshooting and coding it, I finally did it. Now you're saying we should scrap the thing we've been waiting for for upwards of a couple of years without even testing it because something you're afraid of "might" go wrong? I find fault with your logic.

number435398

jr. member

Activity: 260

Merit: 6

Quote from: LoveStory on November 13, 2018, 10:47:14 PM

Hey tim, I can't find any information about this project, can you help me to provide the correct website link, because I can not open the site link of the website which are listed in the initial thread.

www.noodlyappendagecoin.net

number435398

jr. member

Activity: 260

Merit: 6

Quote from: dnp on November 13, 2018, 11:18:10 PM

Quote from: number435398 on November 13, 2018, 10:10:05 PM

I have also given people time to verify this themselves or bring up any concerns.

time? too funny ...less than a week.

Well no one's responded; it actually seemed like no one was even bothering. No one has specified an amount of time, no one has communicated anything. What did you want to test that would take more than a week? How long would you suggest we test for? I can't work with you guys if you don't talk to me.

edit: not to mention I've been testing it constantly and trying various manipulations.

Topic: [ANN] NDL - The coin for Pastafarians - Flying Spaghetti Monster Cryptocurrency! - page 12. (Read 125150 times)